Skip to content

Rename request body sampling env var - #11162

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
masterfrom
malvarez/appsec-rename-body-var
Jul 6, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
masterfrom
malvarez/appsec-rename-body-var

Conversation

@manuel-alvarez-alvarez

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Apr 20, 2026 •

Copy link
Copy Markdown
Member

What Does This Do

Renames the environment variable DD_API_SECURITY_DOWNSTREAM_REQUEST_BODY_ANALYSIS_SAMPLE_RATE to DD_API_SECURITY_DOWNSTREAM_BODY_ANALYSIS_SAMPLE_RATE keeping the aliases.

Motivation

The name of the previous variable was too long for certain languages so we had to crop it.

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-61153

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@manuel-alvarez-alvarez manuel-alvarez-alvarez added the tag: no release notes Changes to exclude from release notes label Apr 20, 2026
@manuel-alvarez-alvarez
manuel-alvarez-alvarez requested a review from a team as a code owner April 20, 2026 09:24
@manuel-alvarez-alvarez
manuel-alvarez-alvarez requested review from a team as code owners April 20, 2026 09:24
@manuel-alvarez-alvarez manuel-alvarez-alvarez added the comp: asm waf Application Security Management (WAF) label Apr 20, 2026
@manuel-alvarez-alvarez
manuel-alvarez-alvarez requested review from claponcet, dougqh and jandro996 and removed request for a team April 20, 2026 09:25

@jandro996 jandro996 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pr-commenter

pr-commenter Bot commented Apr 20, 2026 •

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-rename-body-var
git_commit_date 1777284879 1777287662
git_commit_sha 34333bb 271c2d3
release_version 1.62.0-SNAPSHOT~34333bb5c3 1.62.0-SNAPSHOT~271c2d3f17
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1777289370 1777289370
ci_job_id 1632933724 1632933724
ci_pipeline_id 109858933 109858933
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-lxalmfv2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-lxalmfv2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066598
Total [baseline] (8.871 s) : 0, 8870883
Agent [candidate] (1.055 s) : 0, 1054533
Total [candidate] (8.877 s) : 0, 8877165
section iast
Agent [baseline] (1.232 s) : 0, 1231571
Total [baseline] (9.557 s) : 0, 9556621
Agent [candidate] (1.236 s) : 0, 1235654
Total [candidate] (9.534 s) : 0, 9533679
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.232 s 164.973 ms (15.5%)
Total tracing 8.871 s -
Total iast 9.557 s 685.739 ms (7.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.236 s 181.121 ms (17.2%)
Total tracing 8.877 s -
Total iast 9.534 s 656.514 ms (7.4%)
gantt
    title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.247 ms) : 0, 1247
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (642.578 ms) : 0, 642578
BytebuddyAgent [candidate] (634.835 ms) : 0, 634835
AgentMeter [baseline] (29.846 ms) : 0, 29846
AgentMeter [candidate] (29.483 ms) : 0, 29483
GlobalTracer [baseline] (251.355 ms) : 0, 251355
GlobalTracer [candidate] (248.456 ms) : 0, 248456
AppSec [baseline] (32.69 ms) : 0, 32690
AppSec [candidate] (32.191 ms) : 0, 32191
Debugger [baseline] (60.092 ms) : 0, 60092
Debugger [candidate] (59.298 ms) : 0, 59298
Remote Config [baseline] (605.734 µs) : 0, 606
Remote Config [candidate] (592.265 µs) : 0, 592
Telemetry [baseline] (8.134 ms) : 0, 8134
Telemetry [candidate] (8.798 ms) : 0, 8798
Flare Poller [baseline] (3.667 ms) : 0, 3667
Flare Poller [candidate] (3.581 ms) : 0, 3581
section iast
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (810.221 ms) : 0, 810221
BytebuddyAgent [candidate] (811.768 ms) : 0, 811768
AgentMeter [baseline] (11.326 ms) : 0, 11326
AgentMeter [candidate] (11.438 ms) : 0, 11438
GlobalTracer [baseline] (239.106 ms) : 0, 239106
GlobalTracer [candidate] (240.723 ms) : 0, 240723
AppSec [baseline] (27.4 ms) : 0, 27400
AppSec [candidate] (31.392 ms) : 0, 31392
Debugger [baseline] (63.686 ms) : 0, 63686
Debugger [candidate] (62.727 ms) : 0, 62727
Remote Config [baseline] (534.529 µs) : 0, 535
Remote Config [candidate] (521.293 µs) : 0, 521
Telemetry [baseline] (7.692 ms) : 0, 7692
Telemetry [candidate] (7.822 ms) : 0, 7822
Flare Poller [baseline] (3.421 ms) : 0, 3421
Flare Poller [candidate] (3.423 ms) : 0, 3423
IAST [baseline] (30.905 ms) : 0, 30905
IAST [candidate] (28.587 ms) : 0, 28587
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059093
Total [baseline] (11.119 s) : 0, 11118971
Agent [candidate] (1.064 s) : 0, 1063770
Total [candidate] (10.989 s) : 0, 10989117
section appsec
Agent [baseline] (1.273 s) : 0, 1272649
Total [baseline] (11.076 s) : 0, 11075771
Agent [candidate] (1.272 s) : 0, 1271984
Total [candidate] (11.126 s) : 0, 11125826
section iast
Agent [baseline] (1.238 s) : 0, 1238146
Total [baseline] (11.25 s) : 0, 11250303
Agent [candidate] (1.238 s) : 0, 1238065
Total [candidate] (11.323 s) : 0, 11323282
section profiling
Agent [baseline] (1.183 s) : 0, 1183201
Total [baseline] (11.01 s) : 0, 11010095
Agent [candidate] (1.185 s) : 0, 1184944
Total [candidate] (11.083 s) : 0, 11083368
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent appsec 1.273 s 213.556 ms (20.2%)
Agent iast 1.238 s 179.052 ms (16.9%)
Agent profiling 1.183 s 124.108 ms (11.7%)
Total tracing 11.119 s -
Total appsec 11.076 s -43.201 ms (-0.4%)
Total iast 11.25 s 131.332 ms (1.2%)
Total profiling 11.01 s -108.876 ms (-1.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.272 s 208.214 ms (19.6%)
Agent iast 1.238 s 174.295 ms (16.4%)
Agent profiling 1.185 s 121.174 ms (11.4%)
Total tracing 10.989 s -
Total appsec 11.126 s 136.708 ms (1.2%)
Total iast 11.323 s 334.164 ms (3.0%)
Total profiling 11.083 s 94.25 ms (0.9%)
gantt
    title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.255 ms) : 0, 1255
crashtracking [candidate] (1.251 ms) : 0, 1251
BytebuddyAgent [baseline] (636.471 ms) : 0, 636471
BytebuddyAgent [candidate] (639.519 ms) : 0, 639519
AgentMeter [baseline] (29.517 ms) : 0, 29517
AgentMeter [candidate] (29.687 ms) : 0, 29687
GlobalTracer [baseline] (249.139 ms) : 0, 249139
GlobalTracer [candidate] (249.951 ms) : 0, 249951
AppSec [baseline] (32.299 ms) : 0, 32299
AppSec [candidate] (32.14 ms) : 0, 32140
Debugger [baseline] (60.39 ms) : 0, 60390
Debugger [candidate] (59.875 ms) : 0, 59875
Remote Config [baseline] (598.206 µs) : 0, 598
Remote Config [candidate] (591.087 µs) : 0, 591
Telemetry [baseline] (8.001 ms) : 0, 8001
Telemetry [candidate] (8.795 ms) : 0, 8795
Flare Poller [baseline] (5.187 ms) : 0, 5187
Flare Poller [candidate] (5.757 ms) : 0, 5757
section appsec
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (684.017 ms) : 0, 684017
BytebuddyAgent [candidate] (680.402 ms) : 0, 680402
AgentMeter [baseline] (12.423 ms) : 0, 12423
AgentMeter [candidate] (12.414 ms) : 0, 12414
GlobalTracer [baseline] (251.048 ms) : 0, 251048
GlobalTracer [candidate] (251.1 ms) : 0, 251100
AppSec [baseline] (187.301 ms) : 0, 187301
AppSec [candidate] (187.934 ms) : 0, 187934
Debugger [baseline] (64.131 ms) : 0, 64131
Debugger [candidate] (65.747 ms) : 0, 65747
Remote Config [baseline] (578.0 µs) : 0, 578
Remote Config [candidate] (595.567 µs) : 0, 596
Telemetry [baseline] (7.761 ms) : 0, 7761
Telemetry [candidate] (7.973 ms) : 0, 7973
Flare Poller [baseline] (3.415 ms) : 0, 3415
Flare Poller [candidate] (3.514 ms) : 0, 3514
IAST [baseline] (24.217 ms) : 0, 24217
IAST [candidate] (24.543 ms) : 0, 24543
section iast
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (813.439 ms) : 0, 813439
BytebuddyAgent [candidate] (812.704 ms) : 0, 812704
AgentMeter [baseline] (11.423 ms) : 0, 11423
AgentMeter [candidate] (11.474 ms) : 0, 11474
GlobalTracer [baseline] (239.953 ms) : 0, 239953
GlobalTracer [candidate] (241.163 ms) : 0, 241163
AppSec [baseline] (29.545 ms) : 0, 29545
AppSec [candidate] (27.781 ms) : 0, 27781
Debugger [baseline] (66.964 ms) : 0, 66964
Debugger [candidate] (64.942 ms) : 0, 64942
Remote Config [baseline] (536.297 µs) : 0, 536
Remote Config [candidate] (529.134 µs) : 0, 529
Telemetry [baseline] (7.856 ms) : 0, 7856
Telemetry [candidate] (7.786 ms) : 0, 7786
Flare Poller [baseline] (3.457 ms) : 0, 3457
Flare Poller [candidate] (3.468 ms) : 0, 3468
IAST [baseline] (27.63 ms) : 0, 27630
IAST [candidate] (31.016 ms) : 0, 31016
section profiling
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (691.045 ms) : 0, 691045
BytebuddyAgent [candidate] (691.987 ms) : 0, 691987
AgentMeter [baseline] (8.908 ms) : 0, 8908
AgentMeter [candidate] (8.893 ms) : 0, 8893
GlobalTracer [baseline] (207.467 ms) : 0, 207467
GlobalTracer [candidate] (207.387 ms) : 0, 207387
AppSec [baseline] (32.494 ms) : 0, 32494
AppSec [candidate] (32.587 ms) : 0, 32587
Debugger [baseline] (65.706 ms) : 0, 65706
Debugger [candidate] (65.568 ms) : 0, 65568
Remote Config [baseline] (575.208 µs) : 0, 575
Remote Config [candidate] (581.286 µs) : 0, 581
Telemetry [baseline] (7.767 ms) : 0, 7767
Telemetry [candidate] (7.859 ms) : 0, 7859
Flare Poller [baseline] (3.483 ms) : 0, 3483
Flare Poller [candidate] (3.548 ms) : 0, 3548
ProfilingAgent [baseline] (93.184 ms) : 0, 93184
ProfilingAgent [candidate] (93.878 ms) : 0, 93878
Profiling [baseline] (93.754 ms) : 0, 93754
Profiling [candidate] (94.437 ms) : 0, 94437
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-rename-body-var
git_commit_date 1777284879 1777287662
git_commit_sha 34333bb 271c2d3
release_version 1.62.0-SNAPSHOT~34333bb5c3 1.62.0-SNAPSHOT~271c2d3f17
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1777289870 1777289870
ci_job_id 1632933725 1632933725
ci_pipeline_id 109858933 109858933
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-6yreezb4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-6yreezb4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load better
[-497.929µs; -204.073µs] or [-9.012%; -3.693%]
better
[-1074.456µs; -340.437µs] or [-8.187%; -2.594%]
unstable
[-26.897op/s; +135.459op/s] or [-3.616%; +18.209%]
5.174ms 12.416ms 798.188op/s 5.525ms 13.124ms 743.906op/s
scenario:load:petclinic:iast:high_load same
[-359.722µs; +37.823µs] or [-2.049%; +0.215%]
better
[-1.789ms; -0.592ms] or [-6.114%; -2.024%]
unstable
[-22.162op/s; +31.287op/s] or [-8.591%; +12.128%]
17.399ms 28.074ms 262.531op/s 17.560ms 29.264ms 257.969op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.173 ms) : 17988, 18359
.   : milestone, 18173,
appsec (18.927 ms) : 18730, 19124
.   : milestone, 18927,
code_origins (17.877 ms) : 17698, 18056
.   : milestone, 17877,
iast (18.089 ms) : 17908, 18270
.   : milestone, 18089,
profiling (18.233 ms) : 18052, 18414
.   : milestone, 18233,
tracing (17.824 ms) : 17650, 17998
.   : milestone, 17824,
section candidate
no_agent (19.169 ms) : 18975, 19364
.   : milestone, 19169,
appsec (18.662 ms) : 18474, 18850
.   : milestone, 18662,
code_origins (17.849 ms) : 17671, 18027
.   : milestone, 17849,
iast (17.773 ms) : 17604, 17942
.   : milestone, 17773,
profiling (18.321 ms) : 18139, 18503
.   : milestone, 18321,
tracing (17.959 ms) : 17782, 18136
.   : milestone, 17959,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.173 ms [17.988 ms, 18.359 ms] -
appsec 18.927 ms [18.73 ms, 19.124 ms] 753.562 µs (4.1%)
code_origins 17.877 ms [17.698 ms, 18.056 ms] -296.064 µs (-1.6%)
iast 18.089 ms [17.908 ms, 18.27 ms] -84.228 µs (-0.5%)
profiling 18.233 ms [18.052 ms, 18.414 ms] 59.4 µs (0.3%)
tracing 17.824 ms [17.65 ms, 17.998 ms] -349.61 µs (-1.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.169 ms [18.975 ms, 19.364 ms] -
appsec 18.662 ms [18.474 ms, 18.85 ms] -507.445 µs (-2.6%)
code_origins 17.849 ms [17.671 ms, 18.027 ms] -1.32 ms (-6.9%)
iast 17.773 ms [17.604 ms, 17.942 ms] -1.397 ms (-7.3%)
profiling 18.321 ms [18.139 ms, 18.503 ms] -848.24 µs (-4.4%)
tracing 17.959 ms [17.782 ms, 18.136 ms] -1.21 ms (-6.3%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.251 ms) : 1239, 1264
.   : milestone, 1251,
iast (3.349 ms) : 3301, 3397
.   : milestone, 3349,
iast_FULL (6.219 ms) : 6155, 6283
.   : milestone, 6219,
iast_GLOBAL (3.835 ms) : 3776, 3893
.   : milestone, 3835,
profiling (2.175 ms) : 2156, 2194
.   : milestone, 2175,
tracing (2.006 ms) : 1988, 2023
.   : milestone, 2006,
section candidate
no_agent (1.245 ms) : 1234, 1257
.   : milestone, 1245,
iast (3.441 ms) : 3392, 3491
.   : milestone, 3441,
iast_FULL (5.792 ms) : 5734, 5851
.   : milestone, 5792,
iast_GLOBAL (3.775 ms) : 3711, 3840
.   : milestone, 3775,
profiling (2.208 ms) : 2188, 2228
.   : milestone, 2208,
tracing (1.949 ms) : 1930, 1968
.   : milestone, 1949,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.251 ms [1.239 ms, 1.264 ms] -
iast 3.349 ms [3.301 ms, 3.397 ms] 2.098 ms (167.7%)
iast_FULL 6.219 ms [6.155 ms, 6.283 ms] 4.968 ms (397.0%)
iast_GLOBAL 3.835 ms [3.776 ms, 3.893 ms] 2.583 ms (206.5%)
profiling 2.175 ms [2.156 ms, 2.194 ms] 923.918 µs (73.8%)
tracing 2.006 ms [1.988 ms, 2.023 ms] 754.411 µs (60.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.245 ms [1.234 ms, 1.257 ms] -
iast 3.441 ms [3.392 ms, 3.491 ms] 2.196 ms (176.3%)
iast_FULL 5.792 ms [5.734 ms, 5.851 ms] 4.547 ms (365.1%)
iast_GLOBAL 3.775 ms [3.711 ms, 3.84 ms] 2.53 ms (203.2%)
profiling 2.208 ms [2.188 ms, 2.228 ms] 962.452 µs (77.3%)
tracing 1.949 ms [1.93 ms, 1.968 ms] 703.514 µs (56.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-rename-body-var
git_commit_date 1777284879 1777287662
git_commit_sha 34333bb 271c2d3
release_version 1.62.0-SNAPSHOT~34333bb5c3 1.62.0-SNAPSHOT~271c2d3f17
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1777289497 1777289497
ci_job_id 1632933727 1632933727
ci_pipeline_id 109858933 109858933
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-et33ohka 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-et33ohka 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.989 s) : 14989000, 14989000
.   : milestone, 14989000,
appsec (14.525 s) : 14525000, 14525000
.   : milestone, 14525000,
iast (18.667 s) : 18667000, 18667000
.   : milestone, 18667000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
.   : milestone, 17985000,
profiling (15.468 s) : 15468000, 15468000
.   : milestone, 15468000,
tracing (14.971 s) : 14971000, 14971000
.   : milestone, 14971000,
section candidate
no_agent (15.516 s) : 15516000, 15516000
.   : milestone, 15516000,
appsec (14.725 s) : 14725000, 14725000
.   : milestone, 14725000,
iast (18.565 s) : 18565000, 18565000
.   : milestone, 18565000,
iast_GLOBAL (18.077 s) : 18077000, 18077000
.   : milestone, 18077000,
profiling (15.331 s) : 15331000, 15331000
.   : milestone, 15331000,
tracing (14.982 s) : 14982000, 14982000
.   : milestone, 14982000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.989 s [14.989 s, 14.989 s] -
appsec 14.525 s [14.525 s, 14.525 s] -464.0 ms (-3.1%)
iast 18.667 s [18.667 s, 18.667 s] 3.678 s (24.5%)
iast_GLOBAL 17.985 s [17.985 s, 17.985 s] 2.996 s (20.0%)
profiling 15.468 s [15.468 s, 15.468 s] 479.0 ms (3.2%)
tracing 14.971 s [14.971 s, 14.971 s] -18.0 ms (-0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.516 s [15.516 s, 15.516 s] -
appsec 14.725 s [14.725 s, 14.725 s] -791.0 ms (-5.1%)
iast 18.565 s [18.565 s, 18.565 s] 3.049 s (19.7%)
iast_GLOBAL 18.077 s [18.077 s, 18.077 s] 2.561 s (16.5%)
profiling 15.331 s [15.331 s, 15.331 s] -185.0 ms (-1.2%)
tracing 14.982 s [14.982 s, 14.982 s] -534.0 ms (-3.4%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.495 ms) : 1483, 1507
.   : milestone, 1495,
appsec (2.558 ms) : 2503, 2613
.   : milestone, 2558,
iast (2.293 ms) : 2223, 2363
.   : milestone, 2293,
iast_GLOBAL (2.332 ms) : 2262, 2403
.   : milestone, 2332,
profiling (2.124 ms) : 2069, 2179
.   : milestone, 2124,
tracing (2.091 ms) : 2037, 2145
.   : milestone, 2091,
section candidate
no_agent (1.498 ms) : 1487, 1510
.   : milestone, 1498,
appsec (3.825 ms) : 3602, 4048
.   : milestone, 3825,
iast (2.288 ms) : 2219, 2358
.   : milestone, 2288,
iast_GLOBAL (2.331 ms) : 2261, 2402
.   : milestone, 2331,
profiling (2.117 ms) : 2062, 2172
.   : milestone, 2117,
tracing (2.093 ms) : 2039, 2146
.   : milestone, 2093,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.495 ms [1.483 ms, 1.507 ms] -
appsec 2.558 ms [2.503 ms, 2.613 ms] 1.063 ms (71.1%)
iast 2.293 ms [2.223 ms, 2.363 ms] 797.736 µs (53.4%)
iast_GLOBAL 2.332 ms [2.262 ms, 2.403 ms] 837.258 µs (56.0%)
profiling 2.124 ms [2.069 ms, 2.179 ms] 628.962 µs (42.1%)
tracing 2.091 ms [2.037 ms, 2.145 ms] 595.915 µs (39.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.498 ms [1.487 ms, 1.51 ms] -
appsec 3.825 ms [3.602 ms, 4.048 ms] 2.326 ms (155.3%)
iast 2.288 ms [2.219 ms, 2.358 ms] 789.965 µs (52.7%)
iast_GLOBAL 2.331 ms [2.261 ms, 2.402 ms] 833.028 µs (55.6%)
profiling 2.117 ms [2.062 ms, 2.172 ms] 618.467 µs (41.3%)
tracing 2.093 ms [2.039 ms, 2.146 ms] 594.306 µs (39.7%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title chore(appsec): rename request body sampling env var Rename request body sampling env var Apr 27, 2026
@PerfectSlayer

Copy link
Copy Markdown
Collaborator

Is this PR still relevant? Should we refresh and merge it?

@manuel-alvarez-alvarez

Copy link
Copy Markdown
Member Author

Is this PR still relevant? Should we refresh and merge it?

@PerfectSlayer yes, it's still relevant, I'll update and merge.

@datadog-official

datadog-official Bot commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 56.94% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0d472a9 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.72 s 14.76 s [-1.0%; +0.4%] (no difference)
startup:insecure-bank:tracing:Agent 13.57 s 13.70 s [-1.7%; -0.3%] (maybe better)
startup:petclinic:appsec:Agent 16.90 s 17.33 s [-6.8%; +1.9%] (no difference)
startup:petclinic:iast:Agent 16.69 s 17.39 s [-8.2%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 16.84 s 17.22 s [-6.5%; +2.1%] (no difference)
startup:petclinic:sca:Agent 17.46 s 16.91 s [-2.5%; +8.9%] (unstable)
startup:petclinic:tracing:Agent 16.61 s 16.61 s [-1.1%; +1.0%] (no difference)

Commit: 0d472a94 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@manuel-alvarez-alvarez

Copy link
Copy Markdown
Member Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 6, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-06 14:42:04 UTC ℹ️ Start processing command /merge


2026-07-06 14:42:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-07-06 16:23:25 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-06 17:24:49 UTC ℹ️ MergeQueue: This merge request was merged

@manuel-alvarez-alvarez
manuel-alvarez-alvarez added this pull request to the merge queue Jul 6, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 6, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-06 16:23:05 UTC ℹ️ Start processing command /merge


2026-07-06 16:23:07 UTC ❌ MergeQueue

PR already in the queue with status waiting

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 6, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit bb66fe3 into master Jul 6, 2026
588 of 589 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the malvarez/appsec-rename-body-var branch July 6, 2026 17:24
@github-actions github-actions Bot added this to the 1.64.0 milestone Jul 6, 2026
kaahos pushed a commit that referenced this pull request Jul 8, 2026
chore(appsec): rename request body sampling env var

Merge branch 'master' into malvarez/appsec-rename-body-var

Merge branch 'master' into malvarez/appsec-rename-body-var

Merge branch 'master' into malvarez/appsec-rename-body-var

Update aliases as per feature parity

Merge branch 'master' into malvarez/appsec-rename-body-var

Co-authored-by: manuel.alvarezalvarez <manuel.alvarezalvarez@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: asm waf Application Security Management (WAF) tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants