Skip to content

Add Temurin JDK 24 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2025
Merged

Add Temurin JDK 24 #93

merged 6 commits into from
May 20, 2025

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Apr 30, 2025

Add Temurin JDK 24 to help with testing the latest version.

@sarahchen6 sarahchen6 marked this pull request as ready for review May 1, 2025 16:36
@sarahchen6 sarahchen6 requested a review from PerfectSlayer May 1, 2025 16:44
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-jdk-24 branch from 994b099 to 00ba2e2 Compare May 1, 2025 17:59
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: should we have it named 24 or latest? or both?

My point is we would have to update both CI (dd-trace-java and dd-trace-java-docker-build) every 6 months if we have a fixed name (ie 24) whereas we will only need to update the docker build if we name it latest.

@sarahchen6
Copy link
Contributor Author

General question: should we have it named 24 or latest? or both?

My point is we would have to update both CI (dd-trace-java and dd-trace-java-docker-build) every 6 months if we have a fixed name (ie 24) whereas we will only need to update the docker build if we name it latest.

Good point - I think it makes sense to name it latest, given that this isn't a LTS version.

@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-jdk-24 branch from 4f2146f to 44272b4 Compare May 4, 2025 18:42
@sarahchen6 sarahchen6 changed the title Add OpenJDK 24 Add Temurin JDK 24 May 6, 2025
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-jdk-24 branch from 07a708e to 926820f Compare May 6, 2025 20:20
@sarahchen6 sarahchen6 requested a review from smola May 7, 2025 20:11
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-jdk-24 branch from 926820f to cbc6f39 Compare May 13, 2025 21:29
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
My main question is about latest_stable being compute at check time versus build time -- check my comment for context 😉

@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-jdk-24 branch from cee1539 to 6078764 Compare May 14, 2025 20:09
@sarahchen6 sarahchen6 requested a review from PerfectSlayer May 14, 2025 20:10
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking all good! Thanks for the improvements and iterations

@smola
Copy link
Member

smola commented May 20, 2025

@sarahchen6 The remaining job failure (Keep repository alive...) can be ignored. Good to merge.

@sarahchen6 sarahchen6 merged commit dc4d8e1 into master May 20, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants