-
Notifications
You must be signed in to change notification settings - Fork 5
Add Temurin JDK 24 #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
994b099
to
00ba2e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question: should we have it named 24
or latest
? or both?
My point is we would have to update both CI (dd-trace-java and dd-trace-java-docker-build) every 6 months if we have a fixed name (ie 24) whereas we will only need to update the docker build if we name it latest.
Good point - I think it makes sense to name it |
4f2146f
to
44272b4
Compare
07a708e
to
926820f
Compare
926820f
to
cbc6f39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
My main question is about latest_stable
being compute at check time versus build time -- check my comment for context 😉
cee1539
to
6078764
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking all good! Thanks for the improvements and iterations
@sarahchen6 The remaining job failure ( |
Add Temurin JDK 24 to help with testing the latest version.