Skip to content

Implement DD_PROFILING_OUTPUT_DIR for dev/debug #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2021

Conversation

felixge
Copy link
Member

@felixge felixge commented May 12, 2021

This env variable can be used to quickly look at the pprof files
produced by the profiler locally. This is useful when developing new
profile types that are not yet understood by the backend. It might also
be useful when working with customers who are experiencing uploading
errors.

This env variable can be used to quickly look at the pprof files
produced by the profiler locally. This is useful when developing new
profile types that are not yet understood by the backend. It might also
be useful when working with customers who are experiencing uploading
errors.
@felixge felixge requested review from pmbauer and knusbaum May 12, 2021 09:45
@felixge felixge added this to the 1.31.0 milestone May 12, 2021
@felixge
Copy link
Member Author

felixge commented May 12, 2021

@pmbauer @knusbaum would love for you to review this. Hopefully it should be a simple change that's easy to confirm.

The reason I'm doing this right now is that I'm trying to provide sample pprof files for my #842 PR to Henrik so he can take a look as part of doing the backend integration work.

Copy link
Member

@pmbauer pmbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixge felixge merged commit 434d62f into v1 May 12, 2021
@felixge felixge deleted the felix.geisendoerfer/write-profiles-to-disk branch May 12, 2021 16:52
stlimtat pushed a commit to stlimtat/dd-trace-go that referenced this pull request May 17, 2021
* 'v1' of https://github.com/DataDog/dd-trace-go:
  Implement DD_PROFILING_OUTPUT_DIR for dev/debug (DataDog#924)
  contrib/go-pg/pg.v10: add INTEGRATION flag check for tests (DataDog#921)
  contrib/go-redis/redis.v8: optimize BeforeProcess and BeforeProcessPipeline (DataDog#920)
  CI: check go.sum is up-to-date (DataDog#918)
  README: Fix go get instructions (DataDog#913)
  internal/log: Improve API for testing (DataDog#916)
  ddtrace/tracer: add support for agent discovery endpoint, feature flags, stats & drops (DataDog#859)
  internal/version: bump to v1.31.0 (DataDog#910)
  CONTRIBUTING.md: add link to contrib/README.md (DataDog#802)
  profiler: Disable agentless mode for WithAPIKey (DataDog#906)
  contrib/Shopify/sarama: fix possible deadlock in WrapAsyncProducer (DataDog#907)
  contrib/database/sql.tracedConn implement driver.SessionResetter (DataDog#908)
  ddtrace/opentracer: consider FollowsFrom references as children (DataDog#905)
  ddtrace/opentracer: add support for opentracing.TracerContextWithSpanExtension (DataDog#855)
  ddtrace/tracer: follow noDebugStack setting when using SetTag with an error (DataDog#900)
  contrib/net/http: add a getter to retrieve original round tripper (DataDog#903)
  ddtrace/tracer: ensure Flush call is synchronous (DataDog#901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants