ddtrace/tracer: fix os version for builds on niche GOOS (e.g. freebsd, ...) #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
changed the title
aeneasr
added a commit
to ory/hydra
that referenced
this pull request
Oct 3, 2020
DataDog introduced an issue with freebsd builds (see DataDog/dd-trace-go#753) which has been removed while the fix (DataDog/dd-trace-go#754) is waiting to be merged.
aeneasr
added a commit
to ory/hydra
that referenced
this pull request
Oct 3, 2020
DataDog introduced an issue with freebsd builds (see DataDog/dd-trace-go#753) which has been removed while the fix (DataDog/dd-trace-go#754) is waiting to be merged.
gbbr
changed the title
|
Can we add a regression test for this? |
|
A linter would probably do better here.
… On 5. Oct 2020, at 08:35, Gabriel Aszalos ***@***.***> wrote:
Can we add a regression test for this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
gbbr
approved these changes
Oct 5, 2020
knusbaum
approved these changes
Oct 5, 2020
1 task
|
Would it be possible to release this? |
|
Sure! This is worthy of a patch release since it breaks the build on some OSs, here it is: https://github.com/DataDog/dd-trace-go/releases/tag/v1.27.1 |
|
Appreciate the quick turnaround, thanks! |
dannywieser-1p
pushed a commit
to agilebits/dd-trace-go
that referenced
this pull request
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #753