Skip to content

Comments

Ensure we publish all nuget packages during release#8234

Open
andrewlock wants to merge 1 commit intomasterfrom
andrew/push-openfeature-package
Open

Ensure we publish all nuget packages during release#8234
andrewlock wants to merge 1 commit intomasterfrom
andrew/push-openfeature-package

Conversation

@andrewlock
Copy link
Member

Summary of changes

Removes the "version number" filter from the "push packages" stage of our release

Reason for change

Just did a release, and noticed that the Datadog.FeatureFlags.OpenFeature package wasn't published. This is because we currently explicitly filter to only pushing packages for the current version (e.g. 3.38.0), but the Datadog.FeatureFlags.OpenFeature package is versioned independently (to match OpenFeature), so was not being automatically pushed.

Implementation details

  • Remove the version filter
  • Add --skip-duplicate to avoid erroring when we try to re-push the immutable packages (e.g. Datadog.Trace.Annotations).

Test coverage

Can't really test this, so 🤞 it works

Other details

Noticed while doing the recent release

@andrewlock andrewlock requested a review from a team as a code owner February 23, 2026 11:12
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Feb 23, 2026
@pr-commenter
Copy link

pr-commenter bot commented Feb 23, 2026

Benchmarks

Benchmark execution time: 2026-02-23 11:53:41

Comparing candidate commit 339aa3b in PR branch andrew/push-openfeature-package with baseline commit 7ff6b28 in branch master.

Found 12 performance improvements and 6 performance regressions! Performance is the same for 161 metrics, 13 unstable metrics.

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟩 execution_time [-102.628ms; -101.861ms] or [-50.267%; -49.892%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+91.564ms; +91.907ms] or [+83.046%; +83.357%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟩 execution_time [-28.628ms; -21.807ms] or [-12.838%; -9.779%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟥 execution_time [+10.474ms; +15.638ms] or [+5.337%; +7.968%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+101.581ms; +102.624ms] or [+104.327%; +105.398%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • 🟩 execution_time [-90.164ms; -86.063ms] or [-45.961%; -43.870%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+21.108ms; +26.570ms] or [+12.288%; +15.467%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟩 throughput [+92.684op/s; +232.608op/s] or [+6.063%; +15.215%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • 🟩 execution_time [-94.392µs; -90.608µs] or [-6.328%; -6.074%]
  • 🟩 throughput [+43.424op/s; +45.207op/s] or [+6.478%; +6.744%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟩 execution_time [-88.542µs; -82.978µs] or [-8.065%; -7.558%]
  • 🟩 throughput [+74.767op/s; +79.558op/s] or [+8.209%; +8.735%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-321.001µs; -235.386µs] or [-14.472%; -10.612%]
  • 🟩 throughput [+55.455op/s; +74.745op/s] or [+12.296%; +16.573%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟥 throughput [-3397.692op/s; -1490.719op/s] or [-13.997%; -6.141%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 execution_time [-25.495ms; -22.260ms] or [-12.907%; -11.269%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟩 throughput [+12214.367op/s; +13951.350op/s] or [+5.488%; +6.268%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟥 throughput [-108237.005op/s; -99578.447op/s] or [-9.747%; -8.967%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants