Skip to content

Comments

[AAP] API10 initial implementation#8232

Draft
daniel-romano-DD wants to merge 1 commit intomasterfrom
dani/asm/API10
Draft

[AAP] API10 initial implementation#8232
daniel-romano-DD wants to merge 1 commit intomasterfrom
dani/asm/API10

Conversation

@daniel-romano-DD
Copy link
Contributor

Summary of changes

Implement needed changes to handle API10 (downstream request) vulnerability in RASP

Reason for change

Implementation details

Test coverage

Other details

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8232) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.54 ± (73.50 - 73.77) ms72.72 ± (72.73 - 73.04) ms-1.1%
.NET Framework 4.8 - Bailout
duration78.50 ± (78.35 - 78.72) ms77.13 ± (77.01 - 77.34) ms-1.7%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1064.73 ± (1065.87 - 1072.43) ms1062.54 ± (1062.10 - 1067.99) ms-0.2%
.NET Core 3.1 - Baseline
process.internal_duration_ms22.52 ± (22.48 - 22.57) ms22.66 ± (22.62 - 22.70) ms+0.6%✅⬆️
process.time_to_main_ms84.68 ± (84.51 - 84.85) ms84.46 ± (84.30 - 84.62) ms-0.3%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.91 ± (10.90 - 10.91) MB10.92 ± (10.92 - 10.93) MB+0.2%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms22.38 ± (22.34 - 22.42) ms22.59 ± (22.55 - 22.63) ms+1.0%✅⬆️
process.time_to_main_ms86.01 ± (85.83 - 86.18) ms85.68 ± (85.52 - 85.83) ms-0.4%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.95 ± (10.95 - 10.96) MB10.96 ± (10.95 - 10.96) MB+0.0%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms254.46 ± (250.67 - 258.25) ms251.20 ± (247.37 - 255.03) ms-1.3%
process.time_to_main_ms484.52 ± (483.85 - 485.19) ms484.70 ± (484.05 - 485.35) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed47.64 ± (47.62 - 47.66) MB47.63 ± (47.61 - 47.65) MB-0.0%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.24 ± (21.20 - 21.28) ms21.24 ± (21.19 - 21.28) ms-0.0%
process.time_to_main_ms73.24 ± (73.08 - 73.40) ms73.37 ± (73.19 - 73.55) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.62 ± (10.61 - 10.62) MB10.65 ± (10.64 - 10.65) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms21.25 ± (21.20 - 21.29) ms21.06 ± (21.02 - 21.09) ms-0.9%
process.time_to_main_ms74.66 ± (74.48 - 74.84) ms73.94 ± (73.75 - 74.13) ms-1.0%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.68 ± (10.67 - 10.68) MB10.76 ± (10.75 - 10.76) MB+0.7%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms254.11 ± (251.26 - 256.95) ms259.68 ± (258.28 - 261.09) ms+2.2%✅⬆️
process.time_to_main_ms467.54 ± (466.99 - 468.08) ms464.15 ± (463.58 - 464.72) ms-0.7%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.35 ± (48.33 - 48.38) MB48.40 ± (48.37 - 48.43) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.2%
.NET 8 - Baseline
process.internal_duration_ms19.57 ± (19.54 - 19.61) ms19.45 ± (19.41 - 19.49) ms-0.6%
process.time_to_main_ms73.43 ± (73.27 - 73.59) ms72.66 ± (72.51 - 72.81) ms-1.0%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.67 ± (7.66 - 7.68) MB7.68 ± (7.67 - 7.68) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms19.54 ± (19.49 - 19.58) ms19.38 ± (19.33 - 19.42) ms-0.8%
process.time_to_main_ms74.47 ± (74.30 - 74.65) ms73.60 ± (73.46 - 73.74) ms-1.2%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.72 ± (7.71 - 7.73) MB7.73 ± (7.72 - 7.74) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms189.47 ± (188.58 - 190.36) ms186.54 ± (185.70 - 187.38) ms-1.5%
process.time_to_main_ms447.57 ± (446.73 - 448.42) ms445.12 ± (444.42 - 445.81) ms-0.5%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.03 ± (35.99 - 36.08) MB36.02 ± (35.99 - 36.05) MB-0.0%
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.2%

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.40 ± (193.48 - 194.24) ms193.77 ± (193.53 - 194.41) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration196.66 ± (196.44 - 196.91) ms196.91 ± (196.74 - 197.48) ms+0.1%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1136.77 ± (1138.50 - 1145.52) ms1141.77 ± (1144.90 - 1153.35) ms+0.4%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.91 ± (187.64 - 188.18) ms188.39 ± (188.03 - 188.74) ms+0.3%✅⬆️
process.time_to_main_ms81.22 ± (81.01 - 81.43) ms81.77 ± (81.55 - 81.99) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.18 ± (16.15 - 16.21) MB16.09 ± (16.07 - 16.12) MB-0.6%
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+0.3%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.83 ± (187.49 - 188.17) ms187.83 ± (187.47 - 188.20) ms+0.0%✅⬆️
process.time_to_main_ms82.59 ± (82.44 - 82.73) ms82.92 ± (82.78 - 83.07) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.24 ± (16.22 - 16.27) MB16.17 ± (16.14 - 16.19) MB-0.5%
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.3%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms439.29 ± (436.39 - 442.19) ms437.01 ± (434.40 - 439.63) ms-0.5%
process.time_to_main_ms474.47 ± (473.84 - 475.10) ms474.49 ± (473.97 - 475.00) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed57.63 ± (57.51 - 57.76) MB57.94 ± (57.82 - 58.06) MB+0.5%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms192.48 ± (192.04 - 192.92) ms192.10 ± (191.74 - 192.46) ms-0.2%
process.time_to_main_ms70.62 ± (70.39 - 70.85) ms70.69 ± (70.51 - 70.87) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.09 ± (15.96 - 16.22) MB16.34 ± (16.25 - 16.42) MB+1.6%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.3%
.NET 6 - Bailout
process.internal_duration_ms191.79 ± (191.43 - 192.15) ms191.56 ± (191.25 - 191.87) ms-0.1%
process.time_to_main_ms71.30 ± (71.18 - 71.41) ms71.65 ± (71.51 - 71.78) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.24 ± (16.12 - 16.36) MB16.06 ± (15.92 - 16.21) MB-1.1%
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)-1.7%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms451.52 ± (449.66 - 453.37) ms451.14 ± (448.99 - 453.29) ms-0.1%
process.time_to_main_ms449.44 ± (448.80 - 450.09) ms449.59 ± (449.14 - 450.04) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed57.98 ± (57.84 - 58.11) MB57.99 ± (57.87 - 58.10) MB+0.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%
.NET 8 - Baseline
process.internal_duration_ms190.63 ± (190.34 - 190.93) ms189.63 ± (189.34 - 189.93) ms-0.5%
process.time_to_main_ms69.98 ± (69.78 - 70.18) ms69.71 ± (69.54 - 69.88) ms-0.4%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.73 ± (11.70 - 11.75) MB11.74 ± (11.72 - 11.77) MB+0.2%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.2%
.NET 8 - Bailout
process.internal_duration_ms189.31 ± (189.04 - 189.57) ms189.11 ± (188.82 - 189.40) ms-0.1%
process.time_to_main_ms70.96 ± (70.84 - 71.08) ms70.77 ± (70.65 - 70.89) ms-0.3%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.84 ± (11.81 - 11.87) MB11.82 ± (11.79 - 11.85) MB-0.2%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.4%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms365.12 ± (363.73 - 366.51) ms367.75 ± (366.29 - 369.20) ms+0.7%✅⬆️
process.time_to_main_ms435.14 ± (434.33 - 435.96) ms434.43 ± (433.82 - 435.05) ms-0.2%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed47.75 ± (47.72 - 47.78) MB47.74 ± (47.71 - 47.77) MB-0.0%
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.3%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8232) - mean (73ms)  : 71, 75
    master - mean (74ms)  : 72, 75

    section Bailout
    This PR (8232) - mean (77ms)  : 75, 79
    master - mean (79ms)  : 77, 80

    section CallTarget+Inlining+NGEN
    This PR (8232) - mean (1,065ms)  : 1023, 1107
    master - mean (1,069ms)  : 1022, 1117

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8232) - mean (114ms)  : 111, 117
    master - mean (114ms)  : 111, 117

    section Bailout
    This PR (8232) - mean (115ms)  : 113, 117
    master - mean (115ms)  : 113, 118

    section CallTarget+Inlining+NGEN
    This PR (8232) - mean (769ms)  : 706, 832
    master - mean (767ms)  : 707, 826

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8232) - mean (101ms)  : 99, 103
    master - mean (101ms)  : 98, 104

    section Bailout
    This PR (8232) - mean (101ms)  : 99, 104
    master - mean (102ms)  : 99, 105

    section CallTarget+Inlining+NGEN
    This PR (8232) - mean (759ms)  : 726, 792
    master - mean (755ms)  : 702, 809

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8232) - mean (100ms)  : 96, 103
    master - mean (101ms)  : 98, 103

    section Bailout
    This PR (8232) - mean (101ms)  : 99, 102
    master - mean (102ms)  : 99, 104

    section CallTarget+Inlining+NGEN
    This PR (8232) - mean (662ms)  : 644, 679
    master - mean (665ms)  : 649, 681

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8232) - mean (194ms)  : 190, 198
    master - mean (194ms)  : 190, 198

    section Bailout
    This PR (8232) - mean (197ms)  : 193, 201
    master - mean (197ms)  : 194, 199

    section CallTarget+Inlining+NGEN
    This PR (8232) - mean (1,149ms)  : 1088, 1210
    master - mean (1,142ms)  : 1091, 1193

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8232) - mean (279ms)  : 273, 284
    master - mean (278ms)  : 273, 282

    section Bailout
    This PR (8232) - mean (279ms)  : 274, 283
    master - mean (279ms)  : 275, 283

    section CallTarget+Inlining+NGEN
    This PR (8232) - mean (941ms)  : 898, 984
    master - mean (940ms)  : 885, 995

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8232) - mean (271ms)  : 266, 276
    master - mean (271ms)  : 265, 277

    section Bailout
    This PR (8232) - mean (271ms)  : 267, 275
    master - mean (271ms)  : 267, 276

    section CallTarget+Inlining+NGEN
    This PR (8232) - mean (931ms)  : 905, 958
    master - mean (930ms)  : 912, 948

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8232) - mean (269ms)  : 265, 274
    master - mean (271ms)  : 266, 276

    section Bailout
    This PR (8232) - mean (269ms)  : 266, 273
    master - mean (270ms)  : 266, 273

    section CallTarget+Inlining+NGEN
    This PR (8232) - mean (833ms)  : 817, 849
    master - mean (831ms)  : 814, 848

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant