Draft
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8232) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8232) - mean (73ms) : 71, 75
master - mean (74ms) : 72, 75
section Bailout
This PR (8232) - mean (77ms) : 75, 79
master - mean (79ms) : 77, 80
section CallTarget+Inlining+NGEN
This PR (8232) - mean (1,065ms) : 1023, 1107
master - mean (1,069ms) : 1022, 1117
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8232) - mean (114ms) : 111, 117
master - mean (114ms) : 111, 117
section Bailout
This PR (8232) - mean (115ms) : 113, 117
master - mean (115ms) : 113, 118
section CallTarget+Inlining+NGEN
This PR (8232) - mean (769ms) : 706, 832
master - mean (767ms) : 707, 826
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8232) - mean (101ms) : 99, 103
master - mean (101ms) : 98, 104
section Bailout
This PR (8232) - mean (101ms) : 99, 104
master - mean (102ms) : 99, 105
section CallTarget+Inlining+NGEN
This PR (8232) - mean (759ms) : 726, 792
master - mean (755ms) : 702, 809
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8232) - mean (100ms) : 96, 103
master - mean (101ms) : 98, 103
section Bailout
This PR (8232) - mean (101ms) : 99, 102
master - mean (102ms) : 99, 104
section CallTarget+Inlining+NGEN
This PR (8232) - mean (662ms) : 644, 679
master - mean (665ms) : 649, 681
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8232) - mean (194ms) : 190, 198
master - mean (194ms) : 190, 198
section Bailout
This PR (8232) - mean (197ms) : 193, 201
master - mean (197ms) : 194, 199
section CallTarget+Inlining+NGEN
This PR (8232) - mean (1,149ms) : 1088, 1210
master - mean (1,142ms) : 1091, 1193
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8232) - mean (279ms) : 273, 284
master - mean (278ms) : 273, 282
section Bailout
This PR (8232) - mean (279ms) : 274, 283
master - mean (279ms) : 275, 283
section CallTarget+Inlining+NGEN
This PR (8232) - mean (941ms) : 898, 984
master - mean (940ms) : 885, 995
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8232) - mean (271ms) : 266, 276
master - mean (271ms) : 265, 277
section Bailout
This PR (8232) - mean (271ms) : 267, 275
master - mean (271ms) : 267, 276
section CallTarget+Inlining+NGEN
This PR (8232) - mean (931ms) : 905, 958
master - mean (930ms) : 912, 948
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8232) - mean (269ms) : 265, 274
master - mean (271ms) : 266, 276
section Bailout
This PR (8232) - mean (269ms) : 266, 273
master - mean (270ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (8232) - mean (833ms) : 817, 849
master - mean (831ms) : 814, 848
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Implement needed changes to handle API10 (downstream request) vulnerability in RASP
Reason for change
Implementation details
Test coverage
Other details