Skip to content

Transient shutdown timeout #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NachoEchevarria wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

Transient shutdown timeout #8217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tracer/build/_build/Build.Steps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2506,6 +2506,8 @@ string NormalizedPath(AbsolutePath ap)
new(@".*Noop\dArgumentsVoidIntegration\.OnMethodBegin.*CallTargetNativeTest.*", RegexOptions.Compiled | RegexOptions.Singleline),
new(@".*Noop\dArgumentsVoidIntegration\.OnMethodEnd.*CallTargetNativeTest.*", RegexOptions.Compiled | RegexOptions.Singleline),
new(@".*System.Threading.ThreadAbortException: Thread was being aborted\.", RegexOptions.Compiled),
// Transient shutdown timeout - LifetimeManager hooks may not complete within 30s under CI resource pressure
Copy link
Member

@andrewlock andrewlock Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little hesitant about this one tbh... I understand why we might want to add this, but if this started happening all the time, we would really want to know about it, so I'm not sure we should skip it 🤔

Copy link
Collaborator Author

@NachoEchevarria NachoEchevarria Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Maybe increasing the timeout to 60 secs woud be a better option? This way, if its a matter of time, we could fix it, but if it's something else, it will keep failing. WDYT?

new(@".*Error running shutdown hooks System\.TimeoutException.*", RegexOptions.Compiled),
new(@".*System.InvalidOperationException: Module Samples.Trimming.dll has no HINSTANCE.*", RegexOptions.Compiled),
// CI Visibility known errors
new(@".*The Git repository couldn't be automatically extracted.*", RegexOptions.Compiled),
Expand Down
Loading