feat(telemetry): implement app-extended-heartbeat timer#8215
Draft
khanayan123 wants to merge 1 commit intomasterfrom
Draft
feat(telemetry): implement app-extended-heartbeat timer#8215khanayan123 wants to merge 1 commit intomasterfrom
khanayan123 wants to merge 1 commit intomasterfrom
Conversation
Add timer-based scheduling for app-extended-heartbeat telemetry events. Sends configuration, dependencies, and integrations data every 24 hours to improve reliability in long-running sessions. Changes: - Add ExtendedHeartbeatInterval setting to TelemetrySettings - Add TelemetryExtendedHeartbeatInterval configuration key - Implement _extendedHeartbeatTimer in TelemetryController - Wire up PushExtendedHeartbeat() method - Update test files with new configuration parameter - Reuse existing BuildExtendedHeartbeatData() payload builder Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8215) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8215) - mean (77ms) : 75, 79
master - mean (78ms) : 76, 80
section Bailout
This PR (8215) - mean (81ms) : 80, 83
master - mean (83ms) : 81, 85
section CallTarget+Inlining+NGEN
This PR (8215) - mean (1,103ms) : 1051, 1154
master - mean (1,101ms) : 1050, 1153
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8215) - mean (120ms) : 117, 123
master - mean (120ms) : 117, 123
section Bailout
This PR (8215) - mean (121ms) : 118, 124
master - mean (121ms) : 119, 124
section CallTarget+Inlining+NGEN
This PR (8215) - mean (774ms) : 706, 842
master - mean (780ms) : 716, 844
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8215) - mean (107ms) : 103, 110
master - mean (107ms) : 103, 110
section Bailout
This PR (8215) - mean (108ms) : 105, 110
master - mean (108ms) : 105, 110
section CallTarget+Inlining+NGEN
This PR (8215) - mean (760ms) : 679, 841
master - mean (757ms) : 683, 831
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8215) - mean (105ms) : 102, 107
master - mean (105ms) : 102, 109
section Bailout
This PR (8215) - mean (106ms) : 104, 108
master - mean (107ms) : 104, 109
section CallTarget+Inlining+NGEN
This PR (8215) - mean (695ms) : 675, 714
master - mean (689ms) : 666, 713
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8215) - mean (208ms) : 194, 221
master - mean (209ms) : 190, 228
section Bailout
This PR (8215) - mean (217ms) : 196, 238
master - mean (210ms) : 199, 222
section CallTarget+Inlining+NGEN
This PR (8215) - mean (1,206ms) : 1141, 1272
master - mean (1,220ms) : 1151, 1290
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8215) - mean (305ms) : 275, 334
master - mean (311ms) : 284, 337
section Bailout
This PR (8215) - mean (300ms) : 276, 324
master - mean (303ms) : 279, 328
section CallTarget+Inlining+NGEN
This PR (8215) - mean (994ms) : 928, 1060
master - mean (995ms) : 918, 1071
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8215) - mean (298ms) : 273, 323
master - mean (308ms) : 279, 336
section Bailout
This PR (8215) - mean (289ms) : 267, 312
master - mean (312ms) : 281, 343
section CallTarget+Inlining+NGEN
This PR (8215) - mean (983ms) : 916, 1051
master - mean (988ms) : 898, 1077
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8215) - mean (294ms) : 268, 321
master - mean (310ms) : 266, 354
section Bailout
This PR (8215) - mean (287ms) : 267, 307
master - mean (306ms) : 275, 336
section CallTarget+Inlining+NGEN
This PR (8215) - mean (959ms) : 818, 1099
master - mean (959ms) : 831, 1086
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add timer-based scheduling for app-extended-heartbeat telemetry events. Sends configuration, dependencies, and integrations data every 24 hours to improve reliability in long-running sessions.
Changes:
Summary of changes
Reason for change
Implementation details
Test coverage
Other details