Open
Conversation
anna-git
force-pushed
the
anna/config-registry-only-one-yaml
branch
from
511740d to
4ff6413
Compare
BenchmarksBenchmark execution time: 2026-02-21 17:05:13 Comparing candidate commit 78bf847 in PR branch Found 10 performance improvements and 4 performance regressions! Performance is the same for 163 metrics, 15 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8206) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8206) - mean (75ms) : 73, 78
master - mean (74ms) : 72, 75
section Bailout
This PR (8206) - mean (80ms) : 78, 81
master - mean (79ms) : 77, 80
section CallTarget+Inlining+NGEN
This PR (8206) - mean (1,084ms) : 1038, 1130
master - mean (1,069ms) : 1022, 1117
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8206) - mean (116ms) : 113, 120
master - mean (114ms) : 111, 117
section Bailout
This PR (8206) - mean (117ms) : 115, 120
master - mean (115ms) : 113, 118
section CallTarget+Inlining+NGEN
This PR (8206) - mean (762ms) : 697, 828
master - mean (767ms) : 707, 826
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8206) - mean (104ms) : 101, 107
master - mean (101ms) : 98, 104
section Bailout
This PR (8206) - mean (105ms) : 104, 107
master - mean (102ms) : 99, 105
section CallTarget+Inlining+NGEN
This PR (8206) - mean (760ms) : 694, 827
master - mean (755ms) : 702, 809
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8206) - mean (103ms) : 100, 106
master - mean (101ms) : 98, 103
section Bailout
This PR (8206) - mean (104ms) : 102, 106
master - mean (102ms) : 99, 104
section CallTarget+Inlining+NGEN
This PR (8206) - mean (674ms) : 658, 689
master - mean (665ms) : 649, 681
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8206) - mean (194ms) : 189, 198
master - mean (194ms) : 190, 198
section Bailout
This PR (8206) - mean (198ms) : 195, 200
master - mean (197ms) : 194, 199
section CallTarget+Inlining+NGEN
This PR (8206) - mean (1,151ms) : 1097, 1206
master - mean (1,142ms) : 1091, 1193
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8206) - mean (277ms) : 273, 282
master - mean (278ms) : 273, 282
section Bailout
This PR (8206) - mean (278ms) : 272, 284
master - mean (279ms) : 275, 283
section CallTarget+Inlining+NGEN
This PR (8206) - mean (944ms) : 899, 989
master - mean (940ms) : 885, 995
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8206) - mean (271ms) : 266, 277
master - mean (271ms) : 265, 277
section Bailout
This PR (8206) - mean (270ms) : 267, 274
master - mean (271ms) : 267, 276
section CallTarget+Inlining+NGEN
This PR (8206) - mean (930ms) : 909, 951
master - mean (930ms) : 912, 948
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8206) - mean (270ms) : 265, 275
master - mean (271ms) : 266, 276
section Bailout
This PR (8206) - mean (271ms) : 267, 275
master - mean (270ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (8206) - mean (832ms) : 805, 859
master - mean (831ms) : 814, 848
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
anna-git
force-pushed
the
anna/config-registry-only-one-yaml
branch
2 times, most recently
from
28f8bb4 to
c6b0b1f
Compare
Member
|
The PR description says Also, not a blocker (I can do it later), but do you mind updating the references in Lines 401 to 403 in 8941a2d |
lucaspimentel
approved these changes
Feb 19, 2026
Member
lucaspimentel
left a comment
lucaspimentel
left a comment
There was a problem hiding this comment.
Nice. Really liking all this automation.
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6b0b1f568
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+45
to
+48
| // Skip comments | ||
| if (trimmedLine.StartsWith("#", StringComparison.Ordinal)) | ||
| { | ||
| continue; |
There was a problem hiding this comment.
# as comment inside docs blocks
YamlReader.ParseSupportedConfigurations skips any line whose trimmed text starts with # before checking parser state, so lines like # Heading inside a valid documentation: |- block are dropped from the generated XML docs. This is a regression from the previous YAML-doc parser behavior and will silently strip documentation content whenever markdown headings (or other hash-prefixed text) are added to supported-configurations.yaml.
Useful? React with 👍 / 👎.
Contributor
Author
thank you good catch @lucaspimentel !!! |
anna-git
force-pushed
the
anna/config-registry-only-one-yaml
branch
from
160e1dd to
130566c
Compare
| /// <summary> | ||
| /// Controls how often remote configuration is polled, in seconds. Values must be greater than 0 and no more than 5 | ||
| /// </summary> | ||
| public const string PollIntervalInternal = "DD_INTERNAL_RCM_POLL_INTERVAL"; |
Contributor
There was a problem hiding this comment.
FYI: It seems like we don't actually read the environment variable DD_INTERNAL_RCM_POLL_INTERVAL anymore. Should/can we remove it?
| /// <summary> | ||
| /// The _DD_EXTENSION_ENDPOINT isn't a standard, globally recognized AWS environment variable or service, but likely refers to a custom or specific endpoint for a DataDog (DD) integration/extension within AWS, often used in Lambda functions or containerized apps via ECS/Fargate to send metrics/logs to Datadog's services (Agent/API), especially when using Datadog's AWS integrations or extensions for seamless observability | ||
| /// </summary> | ||
| public const string ExtensionEndpoint = "_DD_EXTENSION_ENDPOINT"; |
Contributor
There was a problem hiding this comment.
Not required for this PR to be submitted, but @lucaspimentel do you have an idea of a better description for this? This descriptions seems like an AI result that's not sure of the actual purpose
zacharycmontoya
approved these changes
Feb 19, 2026
Contributor
zacharycmontoya
left a comment
zacharycmontoya
left a comment
There was a problem hiding this comment.
LGTM with some small comments for configuration updates
anna-git
force-pushed
the
anna/config-registry-only-one-yaml
branch
from
3a9c738 to
514b73d
Compare
anna-git
force-pushed
the
anna/config-registry-only-one-yaml
branch
from
514b73d to
347ac59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Most changes here are generated files regenerated for minor modifications
Removes:
Adds:
Reason for change
documentationa mandatory field on every configuration key, enforced at build time via diagnosticDDSG0008Implementation details
DDSG0008error if missing).csproj: supported-configurations.yaml is now provided asAdditionalFiles; added MSBuild target to generate supported-configurations.json from YAML for backward compatibilityvalidate_supported_configurationsjob to use the v2 YAML-based validation templateTest coverage