[tracing] Create and reparent span for Azure API Management#7806
[tracing] Create and reparent span for Azure API Management#7806
Conversation
BenchmarksBenchmark execution time: 2026-02-23 20:59:14 Comparing candidate commit c17569d in PR branch Found 11 performance improvements and 3 performance regressions! Performance is the same for 159 metrics, 19 unstable metrics. scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0
scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7806) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7806) - mean (77ms) : 74, 80
master - mean (74ms) : 72, 76
section Bailout
This PR (7806) - mean (81ms) : 79, 84
master - mean (78ms) : 76, 80
section CallTarget+Inlining+NGEN
This PR (7806) - mean (1,098ms) : 1056, 1140
master - mean (1,071ms) : 1026, 1117
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7806) - mean (120ms) : 116, 123
master - mean (114ms) : 111, 117
section Bailout
This PR (7806) - mean (120ms) : 118, 123
master - mean (115ms) : 113, 117
section CallTarget+Inlining+NGEN
This PR (7806) - mean (779ms) : 705, 852
master - mean (757ms) : 693, 822
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7806) - mean (107ms) : 104, 110
master - mean (102ms) : 98, 105
section Bailout
This PR (7806) - mean (108ms) : 105, 111
master - mean (103ms) : 101, 105
section CallTarget+Inlining+NGEN
This PR (7806) - mean (770ms) : 693, 846
master - mean (759ms) : 712, 805
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7806) - mean (106ms) : 103, 109
master - mean (101ms) : 98, 104
section Bailout
This PR (7806) - mean (107ms) : 105, 109
master - mean (102ms) : 100, 105
section CallTarget+Inlining+NGEN
This PR (7806) - mean (689ms) : 668, 709
master - mean (672ms) : 653, 692
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7806) - mean (201ms) : 195, 207
master - mean (192ms) : 187, 198
section Bailout
This PR (7806) - mean (201ms) : 195, 208
master - mean (195ms) : 192, 197
section CallTarget+Inlining+NGEN
This PR (7806) - mean (1,172ms) : 1107, 1237
master - mean (1,139ms) : 1087, 1191
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7806) - mean (288ms) : 276, 299
master - mean (275ms) : 270, 280
section Bailout
This PR (7806) - mean (287ms) : 275, 298
master - mean (275ms) : 271, 280
section CallTarget+Inlining+NGEN
This PR (7806) - mean (957ms) : 892, 1022
master - mean (934ms) : 890, 978
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7806) - mean (279ms) : 267, 290
master - mean (268ms) : 264, 273
section Bailout
This PR (7806) - mean (278ms) : 266, 289
master - mean (268ms) : 264, 271
section CallTarget+Inlining+NGEN
This PR (7806) - mean (943ms) : 898, 988
master - mean (926ms) : 907, 945
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7806) - mean (275ms) : 265, 285
master - mean (267ms) : 262, 271
section Bailout
This PR (7806) - mean (272ms) : 266, 278
master - mean (267ms) : 262, 272
section CallTarget+Inlining+NGEN
This PR (7806) - mean (846ms) : 819, 874
master - mean (824ms) : 808, 841
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This comment has been minimized.
This comment has been minimized.
…race-dotnet into storms/add-azure-apim-proxy
tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Proxy/AzureApiManagementExtractor.cs
Outdated
Show resolved
Hide resolved
...er/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Azure/Functions/AzureFunctionsCommon.cs
Outdated
Show resolved
Hide resolved
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 10 occurrences of : - span.kind: internal,
+ span.kind: server,
|
Summary of changes
span.kindtoserverinstead ofinternalto follow this specNote: This PR does not include functions using ASP.NET Core and will be added later
Reason for change
This is a frequently requested feature for proper distributed tracing with Azure Functions using APIM
APMSVLS-245
Implementation details
Test coverage
Other details