-
Notifications
You must be signed in to change notification settings - Fork 150
Bump xunit.v3 from 3.1.0 to 3.2.0 #7756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
dependabot
wants to merge
1
commit into
master
from
dependabot/nuget/tracer/dependabot/integrations/xunit.v3-3.2.0
Closed
Bump xunit.v3 from 3.1.0 to 3.2.0 #7756
dependabot
wants to merge
1
commit into
master
from
dependabot/nuget/tracer/dependabot/integrations/xunit.v3-3.2.0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- updated-dependencies: - dependency-name: xunit.v3 dependency-version: 3.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
BenchmarksBenchmarks Report for benchmark platform 🐌Benchmarks for #7756 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations
|
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 | 6 KB | 6.15 KB | 155 B | 2.58% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 10.9μs | 55.8ns | 262ns | 0 | 0 | 0 | 5.52 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 13.6μs | 70.2ns | 337ns | 0 | 0 | 0 | 5.73 KB |
| master | StartStopWithChild |
net472 | 21.8μs | 122ns | 819ns | 0.858 | 0.322 | 0 | 6 KB |
| #7756 | StartStopWithChild |
net6.0 | 10.6μs | 57.9ns | 347ns | 0 | 0 | 0 | 5.5 KB |
| #7756 | StartStopWithChild |
netcoreapp3.1 | 14.1μs | 49.3ns | 191ns | 0 | 0 | 0 | 5.71 KB |
| #7756 | StartStopWithChild |
net472 | 21.9μs | 111ns | 508ns | 0.88 | 0.22 | 0 | 6.15 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 935μs | 153ns | 574ns | 0 | 0 | 0 | 2.71 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.01ms | 58.6ns | 203ns | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 1.2ms | 54.1ns | 195ns | 0 | 0 | 0 | 3.35 KB |
| #7756 | WriteAndFlushEnrichedTraces |
net6.0 | 932μs | 117ns | 437ns | 0 | 0 | 0 | 2.71 KB |
| #7756 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.03ms | 195ns | 756ns | 0 | 0 | 0 | 2.7 KB |
| #7756 | WriteAndFlushEnrichedTraces |
net472 | 1.2ms | 88.2ns | 330ns | 0 | 0 | 0 | 3.35 KB |
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | AllCycleSimpleBody |
net6.0 | 1.1μs | 6.12ns | 38.7ns | 0 | 0 | 0 | 1.22 KB |
| master | AllCycleSimpleBody |
netcoreapp3.1 | 1.41μs | 7.33ns | 35.1ns | 0 | 0 | 0 | 1.2 KB |
| master | AllCycleSimpleBody |
net472 | 1.03μs | 0.499ns | 1.87ns | 0.191 | 0 | 0 | 1.23 KB |
| master | AllCycleMoreComplexBody |
net6.0 | 7.11μs | 35.4ns | 162ns | 0 | 0 | 0 | 4.72 KB |
| master | AllCycleMoreComplexBody |
netcoreapp3.1 | 8.87μs | 41.3ns | 170ns | 0 | 0 | 0 | 4.62 KB |
| master | AllCycleMoreComplexBody |
net472 | 7.58μs | 4.19ns | 15.7ns | 0.72 | 0 | 0 | 4.74 KB |
| master | ObjectExtractorSimpleBody |
net6.0 | 317ns | 1.78ns | 11.3ns | 0 | 0 | 0 | 280 B |
| master | ObjectExtractorSimpleBody |
netcoreapp3.1 | 403ns | 2.07ns | 9.93ns | 0 | 0 | 0 | 272 B |
| master | ObjectExtractorSimpleBody |
net472 | 301ns | 0.0836ns | 0.324ns | 0.0433 | 0 | 0 | 281 B |
| master | ObjectExtractorMoreComplexBody |
net6.0 | 6.23μs | 31.6ns | 145ns | 0 | 0 | 0 | 3.78 KB |
| master | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.83μs | 39ns | 161ns | 0 | 0 | 0 | 3.69 KB |
| master | ObjectExtractorMoreComplexBody |
net472 | 6.67μs | 1.69ns | 6.53ns | 0.571 | 0 | 0 | 3.8 KB |
| #7756 | AllCycleSimpleBody |
net6.0 | 1.12μs | 5.83ns | 28.5ns | 0 | 0 | 0 | 1.22 KB |
| #7756 | AllCycleSimpleBody |
netcoreapp3.1 | 1.39μs | 7.53ns | 39.8ns | 0 | 0 | 0 | 1.2 KB |
| #7756 | AllCycleSimpleBody |
net472 | 1.04μs | 0.606ns | 2.35ns | 0.191 | 0 | 0 | 1.23 KB |
| #7756 | AllCycleMoreComplexBody |
net6.0 | 7.13μs | 36.1ns | 144ns | 0 | 0 | 0 | 4.72 KB |
| #7756 | AllCycleMoreComplexBody |
netcoreapp3.1 | 8.92μs | 32.5ns | 122ns | 0 | 0 | 0 | 4.62 KB |
| #7756 | AllCycleMoreComplexBody |
net472 | 7.56μs | 4.77ns | 18.5ns | 0.72 | 0 | 0 | 4.74 KB |
| #7756 | ObjectExtractorSimpleBody |
net6.0 | 324ns | 1.71ns | 8.37ns | 0 | 0 | 0 | 280 B |
| #7756 | ObjectExtractorSimpleBody |
netcoreapp3.1 | 405ns | 0.116ns | 0.418ns | 0 | 0 | 0 | 272 B |
| #7756 | ObjectExtractorSimpleBody |
net472 | 297ns | 0.0209ns | 0.078ns | 0.0441 | 0 | 0 | 281 B |
| #7756 | ObjectExtractorMoreComplexBody |
net6.0 | 6.33μs | 29.9ns | 116ns | 0 | 0 | 0 | 3.78 KB |
| #7756 | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.85μs | 31.2ns | 121ns | 0 | 0 | 0 | 3.69 KB |
| #7756 | ObjectExtractorMoreComplexBody |
net472 | 6.79μs | 7.48ns | 29ns | 0.575 | 0 | 0 | 3.8 KB |
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EncodeArgs |
net6.0 | 77.3μs | 229ns | 887ns | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
netcoreapp3.1 | 96.5μs | 302ns | 1.13μs | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
net472 | 110μs | 13.3ns | 51.4ns | 4.95 | 0 | 0 | 32.51 KB |
| master | EncodeLegacyArgs |
net6.0 | 145μs | 26.9ns | 101ns | 0 | 0 | 0 | 2.15 KB |
| master | EncodeLegacyArgs |
netcoreapp3.1 | 199μs | 140ns | 541ns | 0 | 0 | 0 | 2.14 KB |
| master | EncodeLegacyArgs |
net472 | 263μs | 276ns | 1.07μs | 0 | 0 | 0 | 2.16 KB |
| #7756 | EncodeArgs |
net6.0 | 76.4μs | 313ns | 1.17μs | 0 | 0 | 0 | 32.4 KB |
| #7756 | EncodeArgs |
netcoreapp3.1 | 95.8μs | 277ns | 1.07μs | 0 | 0 | 0 | 32.4 KB |
| #7756 | EncodeArgs |
net472 | 109μs | 13.6ns | 52.7ns | 4.94 | 0 | 0 | 32.5 KB |
| #7756 | EncodeLegacyArgs |
net6.0 | 147μs | 121ns | 453ns | 0 | 0 | 0 | 2.14 KB |
| #7756 | EncodeLegacyArgs |
netcoreapp3.1 | 197μs | 175ns | 678ns | 0 | 0 | 0 | 2.14 KB |
| #7756 | EncodeLegacyArgs |
net472 | 262μs | 29.4ns | 114ns | 0 | 0 | 0 | 2.16 KB |
Benchmarks.Trace.Asm.AppSecWafBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #7756
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1
2.074
854,922.78
412,196.98
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 | 2.074 | 854,922.78 | 412,196.98 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunWafRealisticBenchmark |
net6.0 | 391μs | 153ns | 591ns | 0 | 0 | 0 | 4.55 KB |
| master | RunWafRealisticBenchmark |
netcoreapp3.1 | 822μs | 11.2μs | 112μs | 0 | 0 | 0 | 4.48 KB |
| master | RunWafRealisticBenchmark |
net472 | 430μs | 44.9ns | 168ns | 0 | 0 | 0 | 4.66 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net6.0 | 285μs | 71.8ns | 278ns | 0 | 0 | 0 | 2.24 KB |
| master | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 299μs | 58.6ns | 211ns | 0 | 0 | 0 | 2.22 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net472 | 309μs | 26.2ns | 101ns | 0 | 0 | 0 | 2.29 KB |
| #7756 | RunWafRealisticBenchmark |
net6.0 | 393μs | 92.6ns | 358ns | 0 | 0 | 0 | 4.55 KB |
| #7756 | RunWafRealisticBenchmark |
netcoreapp3.1 | 412μs | 97.1ns | 336ns | 0 | 0 | 0 | 4.48 KB |
| #7756 | RunWafRealisticBenchmark |
net472 | 448μs | 102ns | 394ns | 0 | 0 | 0 | 4.66 KB |
| #7756 | RunWafRealisticBenchmarkWithAttack |
net6.0 | 286μs | 32.1ns | 124ns | 0 | 0 | 0 | 2.24 KB |
| #7756 | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 298μs | 35.6ns | 128ns | 0 | 0 | 0 | 2.22 KB |
| #7756 | RunWafRealisticBenchmarkWithAttack |
net472 | 309μs | 51.9ns | 201ns | 0 | 0 | 0 | 2.29 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 62.1μs | 215ns | 804ns | 0 | 0 | 0 | 14.52 KB |
| master | SendRequest |
netcoreapp3.1 | 72.1μs | 126ns | 454ns | 0 | 0 | 0 | 17.42 KB |
| master | SendRequest |
net472 | 0.00351ns | 0.00142ns | 0.0055ns | 0 | 0 | 0 | 0 b |
| #7756 | SendRequest |
net6.0 | 61.1μs | 50.7ns | 196ns | 0 | 0 | 0 | 14.52 KB |
| #7756 | SendRequest |
netcoreapp3.1 | 72μs | 58ns | 209ns | 0 | 0 | 0 | 17.42 KB |
| #7756 | SendRequest |
net472 | 0.00303ns | 0.00121ns | 0.00467ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ More allocations ⚠️
Slower ⚠️ in #7756
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0
1.284
794,809.38
1,020,886.67
More allocations ⚠️ in #7756
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0
1 B
4 B
3 B
300.00%
Fewer allocations 🎉 in #7756
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0
7 B
4 B
-3 B
-42.86%
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 | 1.284 | 794,809.38 | 1,020,886.67 |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 | 1 B | 4 B | 3 B | 300.00% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 | 7 B | 4 B | -3 B | -42.86% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | OriginalCharSlice |
net6.0 | 1.92ms | 6.42μs | 24μs | 0 | 0 | 0 | 640.01 KB |
| master | OriginalCharSlice |
netcoreapp3.1 | 2.1ms | 3.29μs | 11.9μs | 0 | 0 | 0 | 640 KB |
| master | OriginalCharSlice |
net472 | 2.63ms | 110ns | 395ns | 100 | 0 | 0 | 641.95 KB |
| master | OptimizedCharSlice |
net6.0 | 1.39ms | 194ns | 752ns | 0 | 0 | 0 | 7 B |
| master | OptimizedCharSlice |
netcoreapp3.1 | 1.68ms | 544ns | 2.11μs | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSlice |
net472 | 1.94ms | 169ns | 653ns | 0 | 0 | 0 | 0 b |
| master | OptimizedCharSliceWithPool |
net6.0 | 795μs | 30.3ns | 117ns | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSliceWithPool |
netcoreapp3.1 | 800μs | 130ns | 503ns | 0 | 0 | 0 | 0 b |
| master | OptimizedCharSliceWithPool |
net472 | 1.15ms | 62.2ns | 233ns | 0 | 0 | 0 | 0 b |
| #7756 | OriginalCharSlice |
net6.0 | 1.93ms | 3.22μs | 11.6μs | 0 | 0 | 0 | 640.01 KB |
| #7756 | OriginalCharSlice |
netcoreapp3.1 | 2.08ms | 6.38μs | 23.9μs | 0 | 0 | 0 | 640 KB |
| #7756 | OriginalCharSlice |
net472 | 2.63ms | 210ns | 757ns | 100 | 0 | 0 | 641.95 KB |
| #7756 | OptimizedCharSlice |
net6.0 | 1.36ms | 375ns | 1.45μs | 0 | 0 | 0 | 4 B |
| #7756 | OptimizedCharSlice |
netcoreapp3.1 | 1.7ms | 281ns | 1.09μs | 0 | 0 | 0 | 1 B |
| #7756 | OptimizedCharSlice |
net472 | 1.97ms | 289ns | 1.12μs | 0 | 0 | 0 | 0 b |
| #7756 | OptimizedCharSliceWithPool |
net6.0 | 1.02ms | 56.7ns | 219ns | 0 | 0 | 0 | 4 B |
| #7756 | OptimizedCharSliceWithPool |
netcoreapp3.1 | 878μs | 77.5ns | 300ns | 0 | 0 | 0 | 0 b |
| #7756 | OptimizedCharSliceWithPool |
net472 | 1.13ms | 138ns | 534ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 702μs | 3.9μs | 24.3μs | 0 | 0 | 0 | 41.74 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 717μs | 3.33μs | 13.7μs | 0 | 0 | 0 | 42.07 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 866μs | 2.7μs | 9.35μs | 4.46 | 0 | 0 | 55.83 KB |
| #7756 | WriteAndFlushEnrichedTraces |
net6.0 | 694μs | 3.83μs | 23.9μs | 0 | 0 | 0 | 41.86 KB |
| #7756 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 687μs | 3.21μs | 13.2μs | 0 | 0 | 0 | 42.04 KB |
| #7756 | WriteAndFlushEnrichedTraces |
net472 | 869μs | 2.55μs | 9.55μs | 4.46 | 0 | 0 | 55.82 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.93μs | 9.02ns | 36.1ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 2.52μs | 11.2ns | 43.5ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.91μs | 3.13ns | 12.1ns | 0.144 | 0.0144 | 0 | 987 B |
| #7756 | ExecuteNonQuery |
net6.0 | 1.93μs | 5.9ns | 22.9ns | 0 | 0 | 0 | 1.02 KB |
| #7756 | ExecuteNonQuery |
netcoreapp3.1 | 2.76μs | 4.5ns | 17.4ns | 0 | 0 | 0 | 1.02 KB |
| #7756 | ExecuteNonQuery |
net472 | 2.88μs | 4.3ns | 16.7ns | 0.156 | 0.0141 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.7μs | 8.55ns | 39.2ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
netcoreapp3.1 | 2.17μs | 10.8ns | 44.5ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
net472 | 3.63μs | 3.45ns | 12.4ns | 0.163 | 0 | 0 | 1.04 KB |
| master | CallElasticsearchAsync |
net6.0 | 1.86μs | 5.12ns | 19.8ns | 0 | 0 | 0 | 1.01 KB |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 2.43μs | 6.67ns | 25.8ns | 0 | 0 | 0 | 1.08 KB |
| master | CallElasticsearchAsync |
net472 | 3.72μs | 2.09ns | 8.11ns | 0.167 | 0 | 0 | 1.1 KB |
| #7756 | CallElasticsearch |
net6.0 | 1.78μs | 0.515ns | 1.99ns | 0 | 0 | 0 | 1.03 KB |
| #7756 | CallElasticsearch |
netcoreapp3.1 | 2.2μs | 8.58ns | 33.2ns | 0 | 0 | 0 | 1.03 KB |
| #7756 | CallElasticsearch |
net472 | 3.53μs | 3.89ns | 15.1ns | 0.159 | 0 | 0 | 1.04 KB |
| #7756 | CallElasticsearchAsync |
net6.0 | 1.91μs | 9.39ns | 40.9ns | 0 | 0 | 0 | 1.01 KB |
| #7756 | CallElasticsearchAsync |
netcoreapp3.1 | 2.34μs | 10.7ns | 41.3ns | 0 | 0 | 0 | 1.08 KB |
| #7756 | CallElasticsearchAsync |
net472 | 3.68μs | 2.14ns | 7.42ns | 0.168 | 0 | 0 | 1.1 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.86μs | 8.11ns | 31.4ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 2.52μs | 9.97ns | 37.3ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 2.53μs | 1.22ns | 4.74ns | 0.139 | 0 | 0 | 915 B |
| #7756 | ExecuteAsync |
net6.0 | 1.84μs | 2.58ns | 10ns | 0 | 0 | 0 | 952 B |
| #7756 | ExecuteAsync |
netcoreapp3.1 | 2.46μs | 4.75ns | 17.8ns | 0 | 0 | 0 | 952 B |
| #7756 | ExecuteAsync |
net472 | 2.54μs | 1.56ns | 6.05ns | 0.14 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 6.91μs | 18.2ns | 68ns | 0 | 0 | 0 | 2.36 KB |
| master | SendAsync |
netcoreapp3.1 | 8.87μs | 13.3ns | 51.7ns | 0 | 0 | 0 | 2.9 KB |
| master | SendAsync |
net472 | 12.4μs | 5.95ns | 22.3ns | 0.495 | 0 | 0 | 3.18 KB |
| #7756 | SendAsync |
net6.0 | 7.07μs | 8.87ns | 34.4ns | 0 | 0 | 0 | 2.36 KB |
| #7756 | SendAsync |
netcoreapp3.1 | 8.7μs | 8.69ns | 32.5ns | 0 | 0 | 0 | 2.9 KB |
| #7756 | SendAsync |
net472 | 12.1μs | 9.64ns | 37.3ns | 0.486 | 0 | 0 | 3.18 KB |
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7756
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1
42.8 KB
86.26 KB
43.46 KB
101.53%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472
57.34 KB
65.54 KB
8.19 KB
14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0
44.41 KB
45.06 KB
648 B
1.46%
Fewer allocations 🎉 in #7756
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472
286.72 KB
278.53 KB
-8.19 KB
-2.86%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0
276.93 KB
259.02 KB
-17.9 KB
-6.47%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1
274.86 KB
248.12 KB
-26.74 KB
-9.73%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 | 42.8 KB | 86.26 KB | 43.46 KB | 101.53% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 | 57.34 KB | 65.54 KB | 8.19 KB | 14.29% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 | 44.41 KB | 45.06 KB | 648 B | 1.46% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 | 286.72 KB | 278.53 KB | -8.19 KB | -2.86% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 276.93 KB | 259.02 KB | -17.9 KB | -6.47% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 274.86 KB | 248.12 KB | -26.74 KB | -9.73% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark |
net6.0 | 50.6μs | 414ns | 3.88μs | 0 | 0 | 0 | 44.41 KB |
| master | StringConcatBenchmark |
netcoreapp3.1 | 49.8μs | 283ns | 2.02μs | 0 | 0 | 0 | 42.8 KB |
| master | StringConcatBenchmark |
net472 | 57.4μs | 253ns | 1.07μs | 0 | 0 | 0 | 57.34 KB |
| master | StringConcatAspectBenchmark |
net6.0 | 492μs | 2.04μs | 7.36μs | 0 | 0 | 0 | 276.93 KB |
| master | StringConcatAspectBenchmark |
netcoreapp3.1 | 482μs | 5.6μs | 55.4μs | 0 | 0 | 0 | 274.86 KB |
| master | StringConcatAspectBenchmark |
net472 | 409μs | 2.15μs | 10.5μs | 0 | 0 | 0 | 286.72 KB |
| #7756 | StringConcatBenchmark |
net6.0 | 50.6μs | 618ns | 6.15μs | 0 | 0 | 0 | 45.06 KB |
| #7756 | StringConcatBenchmark |
netcoreapp3.1 | 48.3μs | 279ns | 2.27μs | 0 | 0 | 0 | 86.26 KB |
| #7756 | StringConcatBenchmark |
net472 | 57μs | 96.2ns | 347ns | 0 | 0 | 0 | 65.54 KB |
| #7756 | StringConcatAspectBenchmark |
net6.0 | 480μs | 2.07μs | 8.77μs | 0 | 0 | 0 | 259.02 KB |
| #7756 | StringConcatAspectBenchmark |
netcoreapp3.1 | 510μs | 2.31μs | 8.65μs | 0 | 0 | 0 | 248.12 KB |
| #7756 | StringConcatAspectBenchmark |
net472 | 401μs | 2.09μs | 10.9μs | 0 | 0 | 0 | 278.53 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.66μs | 2.98ns | 11.5ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.6μs | 15.7ns | 58.7ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
net472 | 4.03μs | 5.09ns | 19.7ns | 0.241 | 0 | 0 | 1.64 KB |
| #7756 | EnrichedLog |
net6.0 | 2.68μs | 3.1ns | 12ns | 0 | 0 | 0 | 1.7 KB |
| #7756 | EnrichedLog |
netcoreapp3.1 | 3.66μs | 14.9ns | 57.6ns | 0 | 0 | 0 | 1.7 KB |
| #7756 | EnrichedLog |
net472 | 4.04μs | 6.14ns | 23.8ns | 0.259 | 0 | 0 | 1.64 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 137μs | 665ns | 2.66μs | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
netcoreapp3.1 | 141μs | 666ns | 2.58μs | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
net472 | 169μs | 35ns | 126ns | 0 | 0 | 0 | 4.52 KB |
| #7756 | EnrichedLog |
net6.0 | 124μs | 145ns | 560ns | 0 | 0 | 0 | 4.31 KB |
| #7756 | EnrichedLog |
netcoreapp3.1 | 128μs | 73.6ns | 255ns | 0 | 0 | 0 | 4.31 KB |
| #7756 | EnrichedLog |
net472 | 167μs | 89.9ns | 336ns | 0 | 0 | 0 | 4.52 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 5.13μs | 20ns | 77.4ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
netcoreapp3.1 | 6.81μs | 8.17ns | 31.6ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
net472 | 7.53μs | 6.93ns | 26.8ns | 0.302 | 0 | 0 | 2.08 KB |
| #7756 | EnrichedLog |
net6.0 | 4.92μs | 22.8ns | 91ns | 0 | 0 | 0 | 2.26 KB |
| #7756 | EnrichedLog |
netcoreapp3.1 | 6.95μs | 19.3ns | 74.6ns | 0 | 0 | 0 | 2.26 KB |
| #7756 | EnrichedLog |
net472 | 7.54μs | 7.31ns | 28.3ns | 0.301 | 0 | 0 | 2.08 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 2.02μs | 10.3ns | 44.8ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
netcoreapp3.1 | 2.65μs | 13.3ns | 61ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
net472 | 3.17μs | 3.01ns | 11.7ns | 0.19 | 0 | 0 | 1.2 KB |
| #7756 | SendReceive |
net6.0 | 2.02μs | 1.57ns | 6.06ns | 0 | 0 | 0 | 1.2 KB |
| #7756 | SendReceive |
netcoreapp3.1 | 2.66μs | 12.4ns | 51.2ns | 0 | 0 | 0 | 1.2 KB |
| #7756 | SendReceive |
net472 | 3.06μs | 4.86ns | 18.8ns | 0.184 | 0 | 0 | 1.2 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.29μs | 6.52ns | 25.2ns | 0 | 0 | 0 | 1.58 KB |
| master | EnrichedLog |
netcoreapp3.1 | 5.5μs | 14.2ns | 53.2ns | 0 | 0 | 0 | 1.63 KB |
| master | EnrichedLog |
net472 | 6.57μs | 5.17ns | 20ns | 0.295 | 0 | 0 | 2.03 KB |
| #7756 | EnrichedLog |
net6.0 | 4.21μs | 14.3ns | 55.4ns | 0 | 0 | 0 | 1.58 KB |
| #7756 | EnrichedLog |
netcoreapp3.1 | 5.7μs | 10.9ns | 42.3ns | 0 | 0 | 0 | 1.63 KB |
| #7756 | EnrichedLog |
net472 | 6.46μs | 9.48ns | 36.7ns | 0.29 | 0 | 0 | 2.03 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 783ns | 0.287ns | 1.11ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 974ns | 5.05ns | 24.2ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 936ns | 0.628ns | 2.43ns | 0.0897 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 910ns | 4.47ns | 20ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 1.17μs | 6.23ns | 31.1ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 1.14μs | 0.734ns | 2.84ns | 0.102 | 0 | 0 | 658 B |
| #7756 | StartFinishSpan |
net6.0 | 762ns | 4.15ns | 21.6ns | 0 | 0 | 0 | 576 B |
| #7756 | StartFinishSpan |
netcoreapp3.1 | 977ns | 4.66ns | 18.6ns | 0 | 0 | 0 | 576 B |
| #7756 | StartFinishSpan |
net472 | 922ns | 0.962ns | 3.73ns | 0.0882 | 0 | 0 | 578 B |
| #7756 | StartFinishScope |
net6.0 | 921ns | 4.41ns | 17.1ns | 0 | 0 | 0 | 696 B |
| #7756 | StartFinishScope |
netcoreapp3.1 | 1.21μs | 1.34ns | 5.19ns | 0 | 0 | 0 | 696 B |
| #7756 | StartFinishScope |
net472 | 1.11μs | 0.579ns | 2.24ns | 0.1 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 1.11μs | 1.58ns | 6.14ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1.4μs | 5.93ns | 23ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.48μs | 1.35ns | 5.23ns | 0.104 | 0 | 0 | 658 B |
| #7756 | RunOnMethodBegin |
net6.0 | 1.07μs | 5.73ns | 26.9ns | 0 | 0 | 0 | 696 B |
| #7756 | RunOnMethodBegin |
netcoreapp3.1 | 1.45μs | 6.89ns | 27.6ns | 0 | 0 | 0 | 696 B |
| #7756 | RunOnMethodBegin |
net472 | 1.49μs | 1.3ns | 5.02ns | 0.103 | 0 | 0 | 658 B |
|
Looks like xunit.v3 is no longer updatable, so this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated xunit.v3 from 3.1.0 to 3.2.0.
Release notes
Sourced from xunit.v3's releases.
No release notes found for this version range.
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)