Handle changes to MutableSettings and ExporterSettings without rebuilding
#7724
+3,717
−1,424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2025
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tracer/src/Datadog.Trace/LibDatadog/DataPipeline/ManagedTraceExporter.cs
Outdated
Show resolved
Hide resolved
andrewlock
force-pushed
the
andrew/settings/5-remove-mutablesettings
branch
3 times, most recently
from
2bc63f6 to
34f0d90
Compare
andrewlock
force-pushed
the
andrew/settings/5-move-mutable-settings-off-tracer-settings
branch
from
e347879 to
8c472a5
Compare
andrewlock
force-pushed
the
andrew/settings/5-remove-mutablesettings
branch
from
34f0d90 to
f1e1c7e
Compare
andrewlock
force-pushed
the
andrew/settings/5-move-mutable-settings-off-tracer-settings
branch
from
8c472a5 to
8e19e3a
Compare
This comment has been minimized.
This comment has been minimized.
andrewlock
force-pushed
the
andrew/settings/5-remove-mutablesettings
branch
from
f1e1c7e to
c2b6a1c
Compare
andrewlock
force-pushed
the
andrew/settings/5-move-mutable-settings-off-tracer-settings
branch
from
8e19e3a to
7940c31
Compare
andrewlock
force-pushed
the
andrew/settings/5-remove-mutablesettings
branch
from
c2b6a1c to
48c7644
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7724) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7724) - mean (74ms) : 69, 79
master - mean (75ms) : 68, 82
section Bailout
This PR (7724) - mean (78ms) : 72, 85
master - mean (79ms) : 74, 84
section CallTarget+Inlining+NGEN
This PR (7724) - mean (1,102ms) : 1042, 1163
master - mean (1,097ms) : 1039, 1155
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7724) - mean (116ms) : 108, 123
master - mean (118ms) : 110, 126
section Bailout
This PR (7724) - mean (117ms) : 108, 126
master - mean (118ms) : 113, 124
section CallTarget+Inlining+NGEN
This PR (7724) - mean (792ms) : 762, 823
master - mean (805ms) : 777, 834
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7724) - mean (102ms) : 96, 108
master - mean (104ms) : 98, 109
section Bailout
This PR (7724) - mean (103ms) : 98, 107
master - mean (105ms) : 99, 111
section CallTarget+Inlining+NGEN
This PR (7724) - mean (735ms) : 706, 764
master - mean (759ms) : 726, 792
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7724) - mean (101ms) : 95, 107
master - mean (103ms) : 95, 111
section Bailout
This PR (7724) - mean (102ms) : 96, 108
master - mean (103ms) : 98, 109
section CallTarget+Inlining+NGEN
This PR (7724) - mean (698ms) : 668, 728
master - mean (719ms) : 694, 744
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7724) - mean (192ms) : 188, 196
master - mean (191ms) : 188, 195
section Bailout
This PR (7724) - mean (196ms) : 193, 199
master - mean (195ms) : 191, 198
section CallTarget+Inlining+NGEN
This PR (7724) - mean (1,162ms) : 1114, 1211
master - mean (1,166ms) : 1090, 1241
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7724) - mean (276ms) : 271, 281
master - mean (275ms) : 269, 281
section Bailout
This PR (7724) - mean (277ms) : 272, 282
master - mean (275ms) : 271, 280
section CallTarget+Inlining+NGEN
This PR (7724) - mean (944ms) : 898, 990
master - mean (943ms) : 904, 981
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7724) - mean (268ms) : 263, 273
master - mean (267ms) : 261, 273
section Bailout
This PR (7724) - mean (268ms) : 265, 272
master - mean (269ms) : 262, 276
section CallTarget+Inlining+NGEN
This PR (7724) - mean (911ms) : 878, 945
master - mean (925ms) : 878, 973
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7724) - mean (268ms) : 263, 272
master - mean (267ms) : 261, 272
section Bailout
This PR (7724) - mean (268ms) : 264, 273
master - mean (268ms) : 260, 275
section CallTarget+Inlining+NGEN
This PR (7724) - mean (845ms) : 820, 870
master - mean (849ms) : 822, 877
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Also: - slight refactor of LogFormatter to reduce some allocation - ignore "previous" when creating DirectLogSubmissionManager (seeing as that won't be a thing soon)
…n't respond to changes I left it like this because the debugger already doesn't respond to changes like other services do
- Move statsd instance creation to separate factory - Create a StatsdManager to handle automatic updating in response to setting changes - Always create a statsd instance, as it's hard to know if we're _ever_ going to need one, and reduces some of the compexity
… reconfiguration is not allowed
…s though, and doesn't respond to changes
This isn't necessary with the current design, and it causes issues today
andrewlock
force-pushed
the
andrew/settings/5-remove-mutablesettings
branch
from
85a6731 to
5ee2a7f
Compare
andrewlock
force-pushed
the
andrew/settings/5-move-mutable-settings-off-tracer-settings
branch
from
10c89c9 to
741db4f
Compare
andrewlock
force-pushed
the
andrew/settings/5-remove-mutablesettings
branch
from
5ee2a7f to
53d59b0
Compare
Make sure we can't dispose a stats consumer that's in use (as it will throw) Rework to use a "lease" mechanism to track usages Make passing in a statsmanager required
andrewlock
force-pushed
the
andrew/settings/5-remove-mutablesettings
branch
from
53d59b0 to
95e3713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
This is the "endpoint" that we've been heading for - services only being disposed/rebuilt at the end of the app, and otherwise only rebuilding the necessary parts. For example - we don't need to tear down all the API factories when a customer changes a global tag via remote config; they only need to change if the
ExporterSettingschange.The hope is that overall this reduces the overhead of using configuration in code and/or remote configuration, while also reducing the number of issues due to managing disposal of services.
Implementation details
Overall, this PR is kind of a pain. Moving from the "rebuild everything" to "reconfigure each service" couldn't be done piecemeal, so this is the one-shot PR. What's more, different services need different patterns (though we can probably consolidate some of them, this has taken a lot of work and I likely changed patterns unnecessarily in some places).
In general, there's a couple of patterns:
Managed*versions of some servicesVolatile.Read()(to ensure changes are visible) and are generally cached to a local variable (as the underlying field may be updated in the background).Test coverage
In the vast majority of places, this should be covered by existing tests
I plan to add some additional integration tests around reconfiguring and a bunch of manual testing to make sure I'm confident.
Other details
I strongly recommend reviewing commit-by-commit. They're generally self-contained, and hopefully simple enough to understand one commit at a time.
https://datadoghq.atlassian.net/browse/LANGPLAT-819
Part of a config stack
MutableSettingsfromTracerSettings#7522MutableSettingson dynamic config changes #7525DefaultServiceNametoMutableSettings#7530PerTraceSettings.GetServiceName()#7532TracerSettingsto useMutableSettingswhere appropriate #7543IsIntegrationEnabled(),IsErrorStatusCode(), andGetIntegrationAnalyticsSampleRate()#7544DictionaryExtensions.SequenceEqual#7722SettingsManagerfor managing mutable settings and ExporterSettings #7695TracerSettingswhich can change at runtime #7723MutableSettingsandExporterSettingswithout rebuilding #7724 👈This isn't the final PR in the stack, as there will be a bunch of cleaning up to do, but it's the final "implementation" PR