Skip to content

Conversation

anna-git
Copy link
Contributor

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@anna-git anna-git changed the title Anna/config inversion platformkeys check [Config Inversion] Platformkeys check Sep 29, 2025
@anna-git anna-git changed the title [Config Inversion] Platformkeys check [Config Inversion] Analyzers for ConfigurationBuilder Sep 29, 2025
@anna-git anna-git force-pushed the anna/config-inversion-aliases-handling branch from d273ab2 to 69d1378 Compare September 29, 2025 12:27
@anna-git anna-git force-pushed the anna/config-inversion-platformkeys-check branch 4 times, most recently from 7186a16 to 4b7bede Compare September 29, 2025 14:07
@anna-git anna-git force-pushed the anna/config-inversion-aliases-handling branch 2 times, most recently from 0ac2639 to fa3c30d Compare September 29, 2025 14:15
@anna-git anna-git force-pushed the anna/config-inversion-platformkeys-check branch 2 times, most recently from 77649c3 to 932c3c6 Compare September 29, 2025 14:52
Copy link

datadog-official bot commented Sep 29, 2025

⚠️ Tests

⚠️ Warnings

🧪 5 Tests failed

Telemetry_Agentless_IsSentOnAppClose from Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryTests (Datadog)
Expected config.Value to be "Datadog,tracecontext,baggage", but found <null>.
Telemetry_Agentless_IsSentOnAppClose from Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryTests (Datadog)
Expected config.Value to be "Datadog,tracecontext,baggage", but found <null>.
Telemetry_Agentless_IsSentOnAppClose from Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryTests (Datadog)
Expected config.Value to be "Datadog,tracecontext,baggage", but found <null>.
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d8a7e8f | Docs | Was this helpful? Give us feedback!

@anna-git anna-git force-pushed the anna/config-inversion-aliases-handling branch from fa3c30d to 554b7d0 Compare September 29, 2025 15:07
@anna-git anna-git force-pushed the anna/config-inversion-platformkeys-check branch from 932c3c6 to 63f9685 Compare September 29, 2025 15:11
@anna-git anna-git force-pushed the anna/config-inversion-aliases-handling branch from 554b7d0 to dcd0751 Compare September 29, 2025 15:37
@anna-git anna-git force-pushed the anna/config-inversion-platformkeys-check branch from 63f9685 to b9187b9 Compare September 29, 2025 15:37
@anna-git anna-git force-pushed the anna/config-inversion-aliases-handling branch from dcd0751 to a70649e Compare September 29, 2025 15:52
@anna-git anna-git force-pushed the anna/config-inversion-platformkeys-check branch from b9187b9 to 7bae444 Compare September 29, 2025 15:52
@anna-git anna-git force-pushed the anna/config-inversion-aliases-handling branch from a70649e to c69d700 Compare September 29, 2025 17:34
@anna-git anna-git force-pushed the anna/config-inversion-platformkeys-check branch from 7bae444 to 9e24d0b Compare September 29, 2025 17:34
@anna-git anna-git force-pushed the anna/config-inversion-aliases-handling branch from c69d700 to afe38ff Compare October 2, 2025 09:49
@anna-git anna-git force-pushed the anna/config-inversion-platformkeys-check branch from 9e24d0b to 0dead4a Compare October 2, 2025 09:49
@anna-git anna-git force-pushed the anna/config-inversion-aliases-handling branch 2 times, most recently from 98c0725 to e83c851 Compare October 2, 2025 19:04
@anna-git anna-git force-pushed the anna/config-inversion-platformkeys-check branch from 0dead4a to da3bfea Compare October 2, 2025 19:04
@anna-git anna-git force-pushed the anna/config-inversion-aliases-handling branch from e83c851 to a24c630 Compare October 2, 2025 20:07
@anna-git anna-git force-pushed the anna/config-inversion-platformkeys-check branch from da3bfea to 450ef3f Compare October 2, 2025 20:07
@anna-git anna-git force-pushed the anna/config-inversion-aliases-handling branch from a24c630 to f82f250 Compare October 3, 2025 10:33
@anna-git anna-git force-pushed the anna/config-inversion-platformkeys-check branch from 450ef3f to d8a7e8f Compare October 3, 2025 10:33
@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7575) - mean (75ms)  : 72, 78
     .   : milestone, 75,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7575) - mean (72ms)  : 67, 78
     .   : milestone, 72,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7575) - mean (1,092ms)  : 1014, 1170
     .   : milestone, 1092,
    master - mean (1,047ms)  : 997, 1097
     .   : milestone, 1047,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7575) - mean (111ms)  : 108, 114
     .   : milestone, 111,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7575) - mean (110ms)  : 106, 114
     .   : milestone, 110,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7575) - mean (763ms)  : 738, 788
     .   : milestone, 763,
    master - mean (741ms)  : 719, 764
     .   : milestone, 741,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7575) - mean (106ms)  : crit, 103, 109
     .   : crit, milestone, 106,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7575) - mean (104ms)  : 101, 107
     .   : milestone, 104,
    master - mean (94ms)  : 91, 96
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7575) - mean (803ms)  : crit, 759, 847
     .   : crit, milestone, 803,
    master - mean (701ms)  : 684, 719
     .   : milestone, 701,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7575) - mean (98ms)  : crit, 94, 101
     .   : crit, milestone, 98,
    master - mean (92ms)  : 91, 94
     .   : milestone, 92,

    section Baseline
    This PR (7575) - mean (96ms)  : 92, 100
     .   : milestone, 96,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7575) - mean (677ms)  : 657, 697
     .   : milestone, 677,
    master - mean (666ms)  : 648, 683
     .   : milestone, 666,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7575) - mean (200ms)  : 197, 204
     .   : milestone, 200,
    master - mean (199ms)  : 195, 202
     .   : milestone, 199,

    section Baseline
    This PR (7575) - mean (197ms)  : 193, 201
     .   : milestone, 197,
    master - mean (196ms)  : 191, 201
     .   : milestone, 196,

    section CallTarget+Inlining+NGEN
    This PR (7575) - mean (1,191ms)  : 1133, 1249
     .   : milestone, 1191,
    master - mean (1,180ms)  : 1114, 1246
     .   : milestone, 1180,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7575) - mean (282ms)  : 276, 289
     .   : milestone, 282,
    master - mean (282ms)  : 276, 287
     .   : milestone, 282,

    section Baseline
    This PR (7575) - mean (282ms)  : 276, 288
     .   : milestone, 282,
    master - mean (282ms)  : 277, 286
     .   : milestone, 282,

    section CallTarget+Inlining+NGEN
    This PR (7575) - mean (961ms)  : 920, 1002
     .   : milestone, 961,
    master - mean (943ms)  : 905, 982
     .   : milestone, 943,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7575) - mean (287ms)  : 281, 293
     .   : milestone, 287,
    master - mean (275ms)  : 270, 280
     .   : milestone, 275,

    section Baseline
    This PR (7575) - mean (287ms)  : 279, 295
     .   : milestone, 287,
    master - mean (276ms)  : 270, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (7575) - mean (1,013ms)  : crit, 972, 1053
     .   : crit, milestone, 1013,
    master - mean (931ms)  : 891, 971
     .   : milestone, 931,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7575) - mean (274ms)  : 270, 279
     .   : milestone, 274,
    master - mean (276ms)  : 269, 282
     .   : milestone, 276,

    section Baseline
    This PR (7575) - mean (274ms)  : 267, 282
     .   : milestone, 274,
    master - mean (273ms)  : 268, 278
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (7575) - mean (865ms)  : 848, 881
     .   : milestone, 865,
    master - mean (863ms)  : 843, 883
     .   : milestone, 863,

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant