Skip to content

Bump libdatadog from 19.0.1 to 19.1.0. #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

Bump libdatadog from 19.0.1 to 19.1.0. #7232

merged 1 commit into from
Jul 21, 2025

Conversation

@hoolioh
Copy link
Contributor

@hoolioh hoolioh commented Jul 17, 2025

Summary of changes

Bump libdatadog from 19.0.1 to 19.1.0.

Reason for change

New datadog version integrates new features:

API changes:

  • ddog_trace_exporter_config_set_connection_timeout: this is aimed to solve span duplications in the test enviroment due to the current timeout is very short.
  • ddog_trace_exporter_config_set_rates_payload_version: this will avoid caching the agent response which was used to check if there were changes in the sample rates.

Improvements:

  • Prevent panics from unwinding in the host language so we can avoid undefined behavior (#1083).

Other details

Libdd release page.

@hoolioh hoolioh requested a review from a team as a code owner July 17, 2025 12:14
@hoolioh hoolioh added the libdatadog Updates to the libdatadog library and Rust integration label Jul 17, 2025
andrewlock
andrewlock approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hoolioh hoolioh force-pushed the julio/update-libdatadog branch from 4b45bb7 to 9e6aec1 Compare July 17, 2025 12:21
@hoolioh hoolioh requested a review from a team as a code owner July 17, 2025 12:46
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2025

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

@pr-commenter
Copy link

pr-commenter bot commented Jul 17, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7232 compared to master:

  • 9 benchmarks are slower, with geometric mean 1.641
  • 42 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 6.04 KB -44 B -0.72%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.71 KB -46 B -0.80%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.5 KB -81 B -1.45%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7232 StartStopWithChild net6.0 10.4μs 59.2ns 435ns 0 0 0 5.5 KB
#7232 StartStopWithChild netcoreapp3.1 13.4μs 71.2ns 356ns 0 0 0 5.71 KB
#7232 StartStopWithChild net472 21.5μs 106ns 473ns 0.996 0.332 0.111 6.04 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7232 WriteAndFlushEnrichedTraces net6.0 935μs 136ns 492ns 0 0 0 2.71 KB
#7232 WriteAndFlushEnrichedTraces netcoreapp3.1 1.07ms 823ns 3.08μs 0 0 0 2.7 KB
#7232 WriteAndFlushEnrichedTraces net472 1.22ms 96.9ns 336ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 239.66 KB 3.3 KB 1.40%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 243.17 KB 3.3 KB 1.38%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7232 AllCycleSimpleBody net6.0 331μs 1.47μs 5.5μs 0 0 0 197.61 KB
#7232 AllCycleSimpleBody netcoreapp3.1 480μs 148ns 553ns 0 0 0 205.37 KB
#7232 AllCycleSimpleBody net472 442μs 108ns 419ns 36.6 2.16 0 239.66 KB
#7232 AllCycleMoreComplexBody net6.0 341μs 1.74μs 8.34μs 0 0 0 201.12 KB
#7232 AllCycleMoreComplexBody netcoreapp3.1 484μs 964ns 3.73μs 0 0 0 208.78 KB
#7232 AllCycleMoreComplexBody net472 454μs 173ns 670ns 37.9 2.23 0 243.17 KB
#7232 ObjectExtractorSimpleBody net6.0 317ns 1.63ns 7.45ns 0 0 0 280 B
#7232 ObjectExtractorSimpleBody netcoreapp3.1 404ns 2.15ns 8.59ns 0 0 0 272 B
#7232 ObjectExtractorSimpleBody net472 306ns 0.0345ns 0.134ns 0.0433 0 0 281 B
#7232 ObjectExtractorMoreComplexBody net6.0 6.24μs 30.4ns 136ns 0 0 0 3.78 KB
#7232 ObjectExtractorMoreComplexBody netcoreapp3.1 7.88μs 9.17ns 35.5ns 0 0 0 3.69 KB
#7232 ObjectExtractorMoreComplexBody net472 6.78μs 9.47ns 36.7ns 0.574 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.14 KB -12 B -0.56%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7232 EncodeArgs net6.0 77.7μs 23.2ns 86.7ns 0 0 0 32.4 KB
#7232 EncodeArgs netcoreapp3.1 99.9μs 83.4ns 312ns 0 0 0 32.4 KB
#7232 EncodeArgs net472 110μs 16.8ns 64.9ns 4.95 0 0 32.51 KB
#7232 EncodeLegacyArgs net6.0 147μs 28.9ns 112ns 0 0 0 2.14 KB
#7232 EncodeLegacyArgs netcoreapp3.1 201μs 745ns 2.89μs 0 0 0 2.14 KB
#7232 EncodeLegacyArgs net472 263μs 27.2ns 105ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7232

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 3.643 198,578.46 723,408.18
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 2.902 293,157.49 850,818.75
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net6.0 1.586 181,119.78 287,229.51
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net472 1.494 206,733.04 308,817.07
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑net6.0 1.448 271,505.69 393,135.69
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑net472 1.392 306,857.62 427,291.04

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7232 RunWafRealisticBenchmark net6.0 393μs 53.7ns 208ns 0 0 0 4.55 KB
#7232 RunWafRealisticBenchmark netcoreapp3.1 801μs 10.6μs 105μs 0 0 0 4.48 KB
#7232 RunWafRealisticBenchmark net472 427μs 58.2ns 225ns 0 0 0 4.66 KB
#7232 RunWafRealisticBenchmarkWithAttack net6.0 287μs 111ns 430ns 0 0 0 2.24 KB
#7232 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 715μs 4.98μs 49.6μs 0 0 0 2.22 KB
#7232 RunWafRealisticBenchmarkWithAttack net472 309μs 43.2ns 167ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7232 SendRequest net6.0 62.3μs 82.1ns 296ns 0 0 0 14.52 KB
#7232 SendRequest netcoreapp3.1 71.1μs 140ns 485ns 0 0 0 17.43 KB
#7232 SendRequest net472 0.00993ns 0.00251ns 0.00971ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
#7232 OriginalCharSlice net6.0 1.94ms 4.89μs 18.9μs 0 0 0 640.01 KB
#7232 OriginalCharSlice netcoreapp3.1 2.16ms 9.96μs 38.6μs 0 0 0 640 KB
#7232 OriginalCharSlice net472 2.65ms 426ns 1.65μs 100 0 0 641.95 KB
#7232 OptimizedCharSlice net6.0 1.38ms 257ns 963ns 0 0 0 7 B
#7232 OptimizedCharSlice netcoreapp3.1 1.77ms 287ns 1.07μs 0 0 0 1 B
#7232 OptimizedCharSlice net472 2.02ms 401ns 1.55μs 0 0 0 73 B
#7232 OptimizedCharSliceWithPool net6.0 797μs 66.5ns 258ns 0 0 0 1 B
#7232 OptimizedCharSliceWithPool netcoreapp3.1 817μs 127ns 492ns 0 0 0 1 B
#7232 OptimizedCharSliceWithPool net472 1.18ms 102ns 395ns 0 0 0 51 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7232

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.181 645,405.00 762,012.50
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.144 631,437.50 722,211.03

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7232 WriteAndFlushEnrichedTraces net6.0 762μs 771ns 2.98μs 0 0 0 41.56 KB
#7232 WriteAndFlushEnrichedTraces netcoreapp3.1 721μs 3.61μs 16.5μs 0 0 0 42.01 KB
#7232 WriteAndFlushEnrichedTraces net472 866μs 4.05μs 15.7μs 4.46 0 0 55.94 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7232 ExecuteNonQuery net6.0 1.86μs 8.62ns 33.4ns 0 0 0 1.02 KB
#7232 ExecuteNonQuery netcoreapp3.1 2.59μs 10.5ns 40.5ns 0 0 0 1.02 KB
#7232 ExecuteNonQuery net472 2.7μs 1.56ns 6.06ns 0.148 0.0135 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7232 CallElasticsearch net6.0 1.8μs 1.08ns 4.18ns 0 0 0 1.03 KB
#7232 CallElasticsearch netcoreapp3.1 2.3μs 7.97ns 30.9ns 0 0 0 1.03 KB
#7232 CallElasticsearch net472 3.64μs 2.95ns 11.4ns 0.164 0 0 1.04 KB
#7232 CallElasticsearchAsync net6.0 1.86μs 3.89ns 15.1ns 0 0 0 1.01 KB
#7232 CallElasticsearchAsync netcoreapp3.1 2.44μs 8.35ns 32.3ns 0 0 0 1.08 KB
#7232 CallElasticsearchAsync net472 3.72μs 2.14ns 8.02ns 0.167 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7232 ExecuteAsync net6.0 1.83μs 6.65ns 25.8ns 0 0 0 952 B
#7232 ExecuteAsync netcoreapp3.1 2.36μs 11.2ns 43.2ns 0 0 0 952 B
#7232 ExecuteAsync net472 2.55μs 3.43ns 13.3ns 0.139 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7232 SendAsync net6.0 7.04μs 9.89ns 38.3ns 0 0 0 2.36 KB
#7232 SendAsync netcoreapp3.1 8.37μs 21.2ns 79.4ns 0 0 0 2.9 KB
#7232 SendAsync net472 12.4μs 6.59ns 24.7ns 0.495 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7232

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.266 413,700.00 523,800.00

More allocations ⚠️ in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.64 KB 42.86 KB 216 B 0.51%

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.83 KB 43.15 KB -680 B -1.55%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7232 StringConcatBenchmark net6.0 44.1μs 226ns 1.49μs 0 0 0 43.15 KB
#7232 StringConcatBenchmark netcoreapp3.1 50.9μs 299ns 2.69μs 0 0 0 42.86 KB
#7232 StringConcatBenchmark net472 57.5μs 215ns 833ns 0 0 0 65.54 KB
#7232 StringConcatAspectBenchmark net6.0 474μs 1.97μs 6.83μs 0 0 0 260.9 KB
#7232 StringConcatAspectBenchmark netcoreapp3.1 526μs 2.51μs 10.3μs 0 0 0 274.28 KB
#7232 StringConcatAspectBenchmark net472 411μs 2.12μs 10.6μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7232 EnrichedLog net6.0 2.64μs 1.36ns 5.28ns 0 0 0 1.7 KB
#7232 EnrichedLog netcoreapp3.1 3.52μs 4.86ns 18.8ns 0 0 0 1.7 KB
#7232 EnrichedLog net472 3.83μs 4.48ns 17.4ns 0.247 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.51 KB -60 B -1.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7232 EnrichedLog net6.0 122μs 130ns 486ns 0 0 0 4.31 KB
#7232 EnrichedLog netcoreapp3.1 127μs 22.2ns 80.2ns 0 0 0 4.31 KB
#7232 EnrichedLog net472 166μs 98.5ns 381ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7232 EnrichedLog net6.0 5.05μs 17.9ns 69.1ns 0 0 0 2.26 KB
#7232 EnrichedLog netcoreapp3.1 6.75μs 17.3ns 66.9ns 0 0 0 2.26 KB
#7232 EnrichedLog net472 7.69μs 5.81ns 22.5ns 0.308 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7232 SendReceive net6.0 2.01μs 10ns 44.7ns 0 0 0 1.2 KB
#7232 SendReceive netcoreapp3.1 2.61μs 7.06ns 27.4ns 0 0 0 1.2 KB
#7232 SendReceive net472 3.31μs 1.49ns 5.37ns 0.179 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7232 EnrichedLog net6.0 4.26μs 2.13ns 7.67ns 0 0 0 1.58 KB
#7232 EnrichedLog netcoreapp3.1 5.48μs 20.1ns 78ns 0 0 0 1.63 KB
#7232 EnrichedLog net472 6.53μs 5.04ns 18.9ns 0.294 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7232 StartFinishSpan net6.0 768ns 0.639ns 2.39ns 0 0 0 576 B
#7232 StartFinishSpan netcoreapp3.1 961ns 0.513ns 1.99ns 0 0 0 576 B
#7232 StartFinishSpan net472 900ns 0.281ns 1.09ns 0.09 0 0 578 B
#7232 StartFinishScope net6.0 881ns 4.16ns 17.7ns 0 0 0 696 B
#7232 StartFinishScope netcoreapp3.1 1.14μs 5.95ns 30.9ns 0 0 0 696 B
#7232 StartFinishScope net472 1.1μs 0.659ns 2.55ns 0.103 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7232

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7232 RunOnMethodBegin net6.0 1.03μs 5.57ns 31ns 0 0 0 696 B
#7232 RunOnMethodBegin netcoreapp3.1 1.39μs 5.4ns 20.2ns 0 0 0 696 B
#7232 RunOnMethodBegin net472 1.37μs 1.13ns 4.37ns 0.103 0 0 658 B

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Jul 17, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7232) - mean (72ms)  : 71, 72
     .   : milestone, 72,
    master - mean (71ms)  : 70, 72
     .   : milestone, 71,

    section Baseline
    This PR (7232) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (68ms)  : 65, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7232) - mean (1,022ms)  : 992, 1052
     .   : milestone, 1022,
    master - mean (1,018ms)  : 998, 1039
     .   : milestone, 1018,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7232) - mean (106ms)  : 105, 107
     .   : milestone, 106,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7232) - mean (105ms)  : 103, 108
     .   : milestone, 105,
    master - mean (105ms)  : 103, 108
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7232) - mean (705ms)  : 686, 723
     .   : milestone, 705,
    master - mean (711ms)  : 692, 731
     .   : milestone, 711,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7232) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7232) - mean (94ms)  : 92, 96
     .   : milestone, 94,
    master - mean (94ms)  : 92, 96
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7232) - mean (670ms)  : 645, 695
     .   : milestone, 670,
    master - mean (666ms)  : 644, 687
     .   : milestone, 666,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7232) - mean (196ms)  : 191, 202
     .   : milestone, 196,
    master - mean (195ms)  : 189, 200
     .   : milestone, 195,

    section Baseline
    This PR (7232) - mean (194ms)  : 188, 201
     .   : milestone, 194,
    master - mean (192ms)  : 185, 199
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (7232) - mean (1,140ms)  : 1112, 1169
     .   : milestone, 1140,
    master - mean (1,136ms)  : 1111, 1160
     .   : milestone, 1136,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7232) - mean (278ms)  : 269, 287
     .   : milestone, 278,
    master - mean (277ms)  : 268, 286
     .   : milestone, 277,

    section Baseline
    This PR (7232) - mean (278ms)  : 270, 286
     .   : milestone, 278,
    master - mean (278ms)  : 270, 285
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (7232) - mean (907ms)  : 880, 934
     .   : milestone, 907,
    master - mean (904ms)  : 875, 934
     .   : milestone, 904,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7232) - mean (272ms)  : 265, 280
     .   : milestone, 272,
    master - mean (272ms)  : 265, 278
     .   : milestone, 272,

    section Baseline
    This PR (7232) - mean (271ms)  : 263, 279
     .   : milestone, 271,
    master - mean (271ms)  : 262, 280
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (7232) - mean (897ms)  : 870, 924
     .   : milestone, 897,
    master - mean (891ms)  : 858, 925
     .   : milestone, 891,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7232) - mean (268ms)  : 261, 276
     .   : milestone, 268,
    master - mean (268ms)  : 260, 277
     .   : milestone, 268,

    section Baseline
    This PR (7232) - mean (270ms)  : 263, 276
     .   : milestone, 270,
    master - mean (270ms)  : 263, 276
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7232) - mean (804ms)  : 781, 828
     .   : milestone, 804,
    master - mean (797ms)  : 776, 819
     .   : milestone, 797,
Loading

@hoolioh hoolioh force-pushed the julio/update-libdatadog branch 5 times, most recently from 59802d3 to d314909 Compare July 19, 2025 17:32
@hoolioh hoolioh force-pushed the julio/update-libdatadog branch from d314909 to 5bf45fe Compare July 19, 2025 19:26
@hoolioh hoolioh merged commit ff6c096 into master Jul 21, 2025
150 checks passed
@hoolioh hoolioh deleted the julio/update-libdatadog branch July 21, 2025 07:11
@github-actions github-actions bot added this to the vNext-v3 milestone Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

libdatadog Updates to the libdatadog library and Rust integration

Projects

None yet

Milestone

3.22.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hoolioh @andrewlock