Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish artifacts to S3 in packaging build #686

Merged
merged 10 commits into from
Mar 31, 2020

Conversation

zacharycmontoya
Copy link
Contributor

@zacharycmontoya zacharycmontoya commented Mar 27, 2020

Improve the packaging Azure DevOps pipeline for building/deploying/testing master:

  • Run the packaging pipeline on each commit to master
  • Upload the following files to s3 for testing:
    • datadog-dotnet-apm-${MAJOR_MINOR_PATCH_WITH_PRERELEASE}-x64.msi
    • datadog-dotnet-apm-${MAJOR_MINOR_PATCH}-amd64.deb
    • index.txt that has supplementary information about the latest commit

The index.txt file contains the branch, SHA, filename (or wildcard) for installing, and the author:

zach/reliability-env/packaging
4f7ebb128af5b1ec5dea07c31e73ab2dd73cfded
datadog-dotnet-apm-1.15.0-*
zach.montoya@datadoghq.com

@DataDog/apm-dotnet

@zacharycmontoya zacharycmontoya added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Mar 27, 2020
@zacharycmontoya zacharycmontoya self-assigned this Mar 27, 2020
@zacharycmontoya zacharycmontoya changed the title Modify packaging to publish artifacts to S3 for testing Publish artifacts to S3 in packaging build Mar 30, 2020
@zacharycmontoya zacharycmontoya marked this pull request as ready for review March 30, 2020 20:30
@zacharycmontoya zacharycmontoya requested a review from a team as a code owner March 30, 2020 20:30
@lucaspimentel
Copy link
Member

If I understand correctly, this will keep uploading new packages with version 1.15.0 until we bump the version number. Isn't this going to be an issue? Should we use the output from GitVersion or the commit hash to generate a unique version number for each master commit?

@zacharycmontoya
Copy link
Contributor Author

Your understanding is correct: until we increase the version number, the artifacts will overwrite on each publish. I don't see this as an issue because we only care about measuring one non-Release commit at a time, which is the head of master. Am I missing something?

@lucaspimentel
Copy link
Member

Nope, just checking. Thanks!

@zacharycmontoya zacharycmontoya merged commit 9cfca30 into master Mar 31, 2020
@zacharycmontoya zacharycmontoya deleted the zach/reliability-env/packaging branch March 31, 2020 16:30
@lucaspimentel lucaspimentel added this to the 1.16.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants