Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiler] Add logs for the different profilers configuration #6739

Merged
merged 5 commits into from
Mar 6, 2025
Merged

[Profiler] Add logs for the different profilers configuration #6739

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f05ff2
Add logs for the different profilers configuration
chrisnas Mar 4, 2025
2480748
Add integration tests
chrisnas Mar 4, 2025
8d324a0
Merge remote-tracking branch 'origin' into chrisnas/add_config_logs
chrisnas Mar 4, 2025
0bd58ae
merge
chrisnas Mar 5, 2025
0de0e79
Merge remote-tracking branch 'origin' into chrisnas/add_config_logs
chrisnas Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add integration tests
  • Loading branch information
@chrisnas
chrisnas committed Mar 4, 2025
commit 24807486fe413b22b430d4acbc32f376a612c3be
205 changes: 205 additions & 0 deletions profiler/test/Datadog.Profiler.IntegrationTests/Configuration/ConfigurationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,205 @@
// <copyright file="ConfigurationTest.cs" company="Datadog">
// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2022 Datadog, Inc.
// </copyright>

using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Security.Cryptography;
using System.Text;
using Datadog.Profiler.IntegrationTests.Helpers;
using FluentAssertions;
using Xunit;
using Xunit.Abstractions;

namespace Datadog.Profiler.IntegrationTests.Exceptions
{
public class ConfigurationTest
{
private const string Scenario1 = "--scenario 18";

private readonly ITestOutputHelper _output;

public ConfigurationTest(ITestOutputHelper output)
{
_output = output;
}

// NOTE: we don't need to validate ALL runtimes but just one
//

[TestAppFact("Samples.Computer01", new[] { "net9.0" })]
public void CheckEnvVarsInLogWithDefaultProfilers(string appName, string framework, string appAssembly)
{
var runner = new TestApplicationRunner(appName, framework, appAssembly, _output, commandLine: Scenario1);
// EnvironmentHelper.DisableDefaultProfilers(runner);

using var agent = MockDatadogAgent.CreateHttpAgent(runner.XUnitLogger);
runner.Run(agent);

bool cpuIsLogged = false;
bool walltimeIsLogged = false;
bool exceptionIsLogged = false;
bool allocationIsLogged = false;
bool lockIsLogged = false;
bool gcIsLogged = false;
bool heapIsLogged = false;
bool serviceIsLogged = false;
bool etwIsLogged = false;

var logFile = Directory.GetFiles(runner.Environment.LogDir)
.Single(f => Path.GetFileName(f).StartsWith("DD-DotNet-Profiler-Native-"));

foreach (var line in File.ReadLines(logFile))
{
if (line.Contains("DD_PROFILING_CPU_ENABLED"))
{
cpuIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_WALLTIME_ENABLED"))
{
walltimeIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_EXCEPTION_ENABLED"))
{
exceptionIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_ALLOCATION_ENABLED"))
{
allocationIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_CONTENTION_ENABLED"))
{
lockIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_GC_ENABLED"))
{
gcIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_HEAP_ENABLED"))
{
heapIsLogged = true;
}
else
if (line.Contains("DD_SERVICE"))
{
serviceIsLogged = true;
}
else
if (line.Contains("DD_INTERNAL_PROFILING_ETW_ENABLED"))
{
etwIsLogged = true;
}
else if (line.Contains("] Configuration: DD_"))
{
// This is the default value
Assert.Fail($"unexpected configuration log - {line}");
}
}

cpuIsLogged.Should().BeTrue();
walltimeIsLogged.Should().BeTrue();
exceptionIsLogged.Should().BeTrue();
allocationIsLogged.Should().BeTrue();
lockIsLogged.Should().BeTrue();
gcIsLogged.Should().BeTrue();
heapIsLogged.Should().BeTrue();
serviceIsLogged.Should().BeTrue();
etwIsLogged.Should().BeTrue();
}

[TestAppFact("Samples.Computer01", new[] { "net9.0" })]
public void CheckEnvVarsInLogWithDisabledProfilers(string appName, string framework, string appAssembly)
{
var runner = new TestApplicationRunner(appName, framework, appAssembly, _output, commandLine: Scenario1);
EnvironmentHelper.DisableDefaultProfilers(runner);

using var agent = MockDatadogAgent.CreateHttpAgent(runner.XUnitLogger);
runner.Run(agent);

bool cpuIsLogged = false;
bool walltimeIsLogged = false;
bool exceptionIsLogged = false;
bool allocationIsLogged = false;
bool lockIsLogged = false;
bool gcIsLogged = false;
bool heapIsLogged = false;
bool serviceIsLogged = false;
bool etwIsLogged = false;

var logFile = Directory.GetFiles(runner.Environment.LogDir)
.Single(f => Path.GetFileName(f).StartsWith("DD-DotNet-Profiler-Native-"));

foreach (var line in File.ReadLines(logFile))
{
if (line.Contains("DD_PROFILING_CPU_ENABLED"))
{
cpuIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_WALLTIME_ENABLED"))
{
walltimeIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_EXCEPTION_ENABLED"))
{
exceptionIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_ALLOCATION_ENABLED"))
{
allocationIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_LOCK_ENABLED"))
{
lockIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_GC_ENABLED"))
{
gcIsLogged = true;
}
else
if (line.Contains("DD_PROFILING_HEAP_ENABLED"))
{
heapIsLogged = true;
}
else
if (line.Contains("DD_SERVICE"))
{
serviceIsLogged = true;
}
else
if (line.Contains("DD_INTERNAL_PROFILING_ETW_ENABLED"))
{
etwIsLogged = true;
}
else if (line.Contains("] Configuration: DD_"))
{
// This is the default value
Assert.Fail($"unexpected configuration log - {line}");
}
}

cpuIsLogged.Should().BeTrue();
walltimeIsLogged.Should().BeTrue();
exceptionIsLogged.Should().BeTrue();
allocationIsLogged.Should().BeTrue();
lockIsLogged.Should().BeTrue();
gcIsLogged.Should().BeTrue();
heapIsLogged.Should().BeTrue();
serviceIsLogged.Should().BeTrue();
etwIsLogged.Should().BeTrue();
}
}
}