Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add Google Protobuf Instrumentation (#6166)" #6642

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Revert "Add Google Protobuf Instrumentation (#6166)" #6642

merged 1 commit into from
Feb 10, 2025

Conversation

andrewlock
Copy link
Member

Summary of changes

This reverts commit 02d20a4.

Reason for change

This has broken the master build, so reverting to unblock the pipeline

Implementation details

Test coverage

Other details

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Feb 10, 2025
@andrewlock andrewlock requested review from a team as code owners February 10, 2025 09:53
daniel-romano-DD
daniel-romano-DD approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6642) - mean (69ms)  : 66, 73
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6642) - mean (991ms)  : 972, 1011
     .   : milestone, 991,
    master - mean (990ms)  : 968, 1011
     .   : milestone, 990,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6642) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6642) - mean (671ms)  : 652, 691
     .   : milestone, 671,
    master - mean (675ms)  : 660, 691
     .   : milestone, 675,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6642) - mean (90ms)  : 88, 92
     .   : milestone, 90,
    master - mean (93ms)  : 83, 103
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6642) - mean (635ms)  : 618, 652
     .   : milestone, 635,
    master - mean (632ms)  : 612, 651
     .   : milestone, 632,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6642) - mean (190ms)  : 186, 193
     .   : milestone, 190,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6642) - mean (1,099ms)  : 1060, 1138
     .   : milestone, 1099,
    master - mean (1,100ms)  : 1068, 1131
     .   : milestone, 1100,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6642) - mean (270ms)  : 264, 276
     .   : milestone, 270,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6642) - mean (866ms)  : 834, 899
     .   : milestone, 866,
    master - mean (861ms)  : 838, 884
     .   : milestone, 861,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6642) - mean (261ms)  : 257, 265
     .   : milestone, 261,
    master - mean (262ms)  : 257, 267
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6642) - mean (846ms)  : 809, 882
     .   : milestone, 846,
    master - mean (843ms)  : 811, 874
     .   : milestone, 843,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6642 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.152
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.68μs 41.9ns 268ns 0.0194 0.00776 0 5.61 KB
master StartStopWithChild netcoreapp3.1 9.89μs 54.7ns 350ns 0.0229 0.00918 0 5.8 KB
master StartStopWithChild net472 15.9μs 65.4ns 253ns 1.04 0.315 0.0945 6.21 KB
#6642 StartStopWithChild net6.0 7.89μs 38.4ns 154ns 0.0151 0.00755 0 5.62 KB
#6642 StartStopWithChild netcoreapp3.1 10.3μs 57.5ns 394ns 0.0259 0.0103 0 5.8 KB
#6642 StartStopWithChild net472 15.9μs 56.3ns 218ns 1.05 0.31 0.101 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 488μs 382ns 1.43μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 646μs 415ns 1.55μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 877μs 2.4μs 9.28μs 0.431 0 0 3.3 KB
#6642 WriteAndFlushEnrichedTraces net6.0 481μs 344ns 1.33μs 0 0 0 2.7 KB
#6642 WriteAndFlushEnrichedTraces netcoreapp3.1 646μs 516ns 1.86μs 0 0 0 2.7 KB
#6642 WriteAndFlushEnrichedTraces net472 862μs 582ns 2.18μs 0.431 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 128μs 456ns 1.77μs 0.194 0 0 14.47 KB
master SendRequest netcoreapp3.1 144μs 412ns 1.59μs 0.211 0 0 17.28 KB
master SendRequest net472 0.0079ns 0.00219ns 0.00848ns 0 0 0 0 b
#6642 SendRequest net6.0 131μs 332ns 1.29μs 0.191 0 0 14.47 KB
#6642 SendRequest netcoreapp3.1 140μs 615ns 2.38μs 0.203 0 0 17.27 KB
#6642 SendRequest net472 0.0063ns 0.00201ns 0.00778ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 548μs 1.08μs 3.74μs 0.571 0 0 41.51 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 686μs 3.78μs 24.2μs 0.326 0 0 41.75 KB
master WriteAndFlushEnrichedTraces net472 877μs 3.99μs 16μs 8.45 2.53 0.422 53.34 KB
#6642 WriteAndFlushEnrichedTraces net6.0 570μs 2.68μs 10.4μs 0.556 0 0 41.58 KB
#6642 WriteAndFlushEnrichedTraces netcoreapp3.1 686μs 3.91μs 28.5μs 0.338 0 0 41.73 KB
#6642 WriteAndFlushEnrichedTraces net472 849μs 3.84μs 14.9μs 8.42 2.66 0.443 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.27μs 1.07ns 4.01ns 0.0147 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 1.88ns 7.3ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.02μs 2.72ns 10.5ns 0.156 0.00101 0 987 B
#6642 ExecuteNonQuery net6.0 1.26μs 1.32ns 5.1ns 0.0145 0 0 1.02 KB
#6642 ExecuteNonQuery netcoreapp3.1 1.79μs 1.74ns 6.51ns 0.0135 0 0 1.02 KB
#6642 ExecuteNonQuery net472 2.11μs 2.42ns 9.37ns 0.156 0.00106 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.26μs 0.565ns 2.19ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.52μs 0.813ns 3.04ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.62μs 1.73ns 6.7ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.32μs 0.428ns 1.66ns 0.0132 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.69μs 1.12ns 4.2ns 0.0136 0 0 1.02 KB
master CallElasticsearchAsync net472 2.61μs 2.39ns 9.25ns 0.167 0 0 1.05 KB
#6642 CallElasticsearch net6.0 1.22μs 2.3ns 8.29ns 0.0134 0 0 976 B
#6642 CallElasticsearch netcoreapp3.1 1.58μs 1.19ns 4.13ns 0.0127 0 0 976 B
#6642 CallElasticsearch net472 2.62μs 1.53ns 5.92ns 0.158 0 0 995 B
#6642 CallElasticsearchAsync net6.0 1.34μs 0.696ns 2.6ns 0.0134 0 0 952 B
#6642 CallElasticsearchAsync netcoreapp3.1 1.66μs 2.15ns 8.06ns 0.0133 0 0 1.02 KB
#6642 CallElasticsearchAsync net472 2.62μs 0.932ns 3.36ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.52μs 0.958ns 3.71ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.6μs 0.69ns 2.67ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.83μs 0.234ns 0.874ns 0.145 0 0 915 B
#6642 ExecuteAsync net6.0 1.44μs 0.975ns 3.78ns 0.0132 0 0 952 B
#6642 ExecuteAsync netcoreapp3.1 1.59μs 1.25ns 4.83ns 0.0128 0 0 952 B
#6642 ExecuteAsync net472 1.87μs 0.541ns 2.03ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.38μs 1.72ns 6.19ns 0.0327 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.36μs 2.67ns 10.3ns 0.0376 0 0 2.85 KB
master SendAsync net472 7.44μs 4.13ns 15.4ns 0.492 0 0 3.12 KB
#6642 SendAsync net6.0 4.46μs 2.28ns 8.52ns 0.0313 0 0 2.31 KB
#6642 SendAsync netcoreapp3.1 5.32μs 2.4ns 9.28ns 0.0369 0 0 2.85 KB
#6642 SendAsync net472 7.36μs 1.45ns 5.6ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 0.859ns 3.1ns 0.0231 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.15μs 0.703ns 2.43ns 0.0226 0 0 1.64 KB
master EnrichedLog net472 2.48μs 0.699ns 2.62ns 0.249 0 0 1.57 KB
#6642 EnrichedLog net6.0 1.47μs 0.689ns 2.58ns 0.0227 0 0 1.64 KB
#6642 EnrichedLog netcoreapp3.1 2.1μs 1.07ns 4.02ns 0.0226 0 0 1.64 KB
#6642 EnrichedLog net472 2.67μs 1.12ns 4.35ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 127ns 491ns 0.0556 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 116μs 103ns 384ns 0.058 0 0 4.28 KB
master EnrichedLog net472 151μs 373ns 1.44μs 0.681 0.227 0 4.46 KB
#6642 EnrichedLog net6.0 113μs 56.5ns 211ns 0.0565 0 0 4.28 KB
#6642 EnrichedLog netcoreapp3.1 115μs 74.5ns 269ns 0.0574 0 0 4.28 KB
#6642 EnrichedLog net472 153μs 141ns 544ns 0.688 0.229 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.12μs 3.28ns 12.3ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.25μs 1.31ns 5.07ns 0.0298 0 0 2.2 KB
master EnrichedLog net472 4.94μs 1.45ns 5.62ns 0.319 0 0 2.02 KB
#6642 EnrichedLog net6.0 3.08μs 0.535ns 2ns 0.0308 0 0 2.2 KB
#6642 EnrichedLog netcoreapp3.1 4.2μs 7.29ns 28.2ns 0.0295 0 0 2.2 KB
#6642 EnrichedLog net472 4.7μs 1.38ns 5.36ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.45μs 1.79ns 6.95ns 0.0157 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.75μs 0.79ns 3.06ns 0.0154 0 0 1.14 KB
master SendReceive net472 2.13μs 1.68ns 6.52ns 0.184 0 0 1.16 KB
#6642 SendReceive net6.0 1.31μs 0.91ns 3.52ns 0.0157 0 0 1.14 KB
#6642 SendReceive netcoreapp3.1 1.85μs 1.24ns 4.79ns 0.0157 0 0 1.14 KB
#6642 SendReceive net472 2.04μs 0.541ns 2.02ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 0.678ns 2.63ns 0.0214 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.74μs 7.02ns 27.2ns 0.0224 0 0 1.65 KB
master EnrichedLog net472 4.48μs 2.52ns 9.74ns 0.323 0 0 2.04 KB
#6642 EnrichedLog net6.0 2.71μs 0.832ns 3.22ns 0.0217 0 0 1.6 KB
#6642 EnrichedLog netcoreapp3.1 3.97μs 2.02ns 7.81ns 0.0219 0 0 1.65 KB
#6642 EnrichedLog net472 4.44μs 2.42ns 9.37ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6642

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.152 687.41 791.61

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 447ns 0.765ns 2.96ns 0.00807 0 0 576 B
master StartFinishSpan netcoreapp3.1 565ns 0.832ns 3.11ns 0.0078 0 0 576 B
master StartFinishSpan net472 625ns 1.81ns 7ns 0.0918 0 0 578 B
master StartFinishScope net6.0 489ns 0.715ns 2.77ns 0.00968 0 0 696 B
master StartFinishScope netcoreapp3.1 688ns 1.65ns 6.4ns 0.00937 0 0 696 B
master StartFinishScope net472 751ns 1.82ns 6.8ns 0.105 0 0 658 B
#6642 StartFinishSpan net6.0 474ns 0.97ns 3.76ns 0.00809 0 0 576 B
#6642 StartFinishSpan netcoreapp3.1 597ns 0.71ns 2.66ns 0.00778 0 0 576 B
#6642 StartFinishSpan net472 624ns 0.857ns 3.32ns 0.0918 0 0 578 B
#6642 StartFinishScope net6.0 487ns 0.798ns 3.09ns 0.00969 0 0 696 B
#6642 StartFinishScope netcoreapp3.1 791ns 1.02ns 3.94ns 0.00953 0 0 696 B
#6642 StartFinishScope net472 780ns 0.801ns 2.89ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 645ns 1.11ns 4.3ns 0.00974 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 914ns 1.54ns 5.95ns 0.00914 0 0 696 B
master RunOnMethodBegin net472 1.08μs 2.66ns 10.3ns 0.104 0 0 658 B
#6642 RunOnMethodBegin net6.0 671ns 0.527ns 2.04ns 0.00963 0 0 696 B
#6642 RunOnMethodBegin netcoreapp3.1 923ns 1.08ns 4.17ns 0.00916 0 0 696 B
#6642 RunOnMethodBegin net472 1μs 1.77ns 6.86ns 0.104 0 0 658 B

@andrewlock andrewlock merged commit 344c304 into master Feb 10, 2025
137 of 143 checks passed
@andrewlock andrewlock deleted the andrew/revert-broekn-build branch February 10, 2025 11:21
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevingosse kevingosse kevingosse approved these changes

@daniel-romano-DD daniel-romano-DD daniel-romano-DD approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewlock @kevingosse @daniel-romano-DD