-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler/Crashtracker] Bump libdatadog 16.0.3 #6589
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 253072 Passed, 2963 Skipped, 20h 6m 6.22s Total Time |
e8ff9f1
to
3ed3ff9
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6589) - mean (70ms) : 65, 75
. : milestone, 70,
master - mean (69ms) : 65, 73
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6589) - mean (1,009ms) : 978, 1041
. : milestone, 1009,
master - mean (1,001ms) : 978, 1024
. : milestone, 1001,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6589) - mean (104ms) : 102, 106
. : milestone, 104,
master - mean (102ms) : 100, 105
. : milestone, 102,
section CallTarget+Inlining+NGEN
This PR (6589) - mean (677ms) : 663, 692
. : milestone, 677,
master - mean (676ms) : 659, 693
. : milestone, 676,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6589) - mean (89ms) : 87, 92
. : milestone, 89,
master - mean (89ms) : 87, 91
. : milestone, 89,
section CallTarget+Inlining+NGEN
This PR (6589) - mean (643ms) : 614, 672
. : milestone, 643,
master - mean (632ms) : 616, 648
. : milestone, 632,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6589) - mean (191ms) : 186, 196
. : milestone, 191,
master - mean (191ms) : 187, 195
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6589) - mean (1,108ms) : 1086, 1130
. : milestone, 1108,
master - mean (1,108ms) : 1072, 1144
. : milestone, 1108,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6589) - mean (272ms) : 267, 277
. : milestone, 272,
master - mean (270ms) : 264, 276
. : milestone, 270,
section CallTarget+Inlining+NGEN
This PR (6589) - mean (865ms) : 835, 895
. : milestone, 865,
master - mean (863ms) : 834, 892
. : milestone, 863,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6589) - mean (263ms) : 259, 266
. : milestone, 263,
master - mean (263ms) : 259, 267
. : milestone, 263,
section CallTarget+Inlining+NGEN
This PR (6589) - mean (848ms) : 806, 890
. : milestone, 848,
master - mean (844ms) : 806, 882
. : milestone, 844,
|
ca59430
to
86d92df
Compare
Benchmarks Report for tracer 🐌Benchmarks for #6589 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 | 1.199 | 1,271.89 | 1,524.93 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.27μs | 0.38ns | 1.47ns | 0.0159 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.77μs | 0.486ns | 1.68ns | 0.015 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.12μs | 2.85ns | 11.1ns | 0.183 | 0 | 0 | 1.16 KB |
#6589 | SendReceive |
net6.0 | 1.52μs | 1.24ns | 4.81ns | 0.0159 | 0 | 0 | 1.14 KB |
#6589 | SendReceive |
netcoreapp3.1 | 1.69μs | 0.781ns | 3.02ns | 0.0159 | 0 | 0 | 1.14 KB |
#6589 | SendReceive |
net472 | 2.19μs | 0.825ns | 3.2ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.77μs | 1.19ns | 4.44ns | 0.022 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.97μs | 5.6ns | 20.9ns | 0.0217 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.3μs | 3.26ns | 12.6ns | 0.323 | 0 | 0 | 2.04 KB |
#6589 | EnrichedLog |
net6.0 | 2.78μs | 2.75ns | 10.3ns | 0.0222 | 0 | 0 | 1.6 KB |
#6589 | EnrichedLog |
netcoreapp3.1 | 3.92μs | 1.99ns | 7.73ns | 0.0216 | 0 | 0 | 1.65 KB |
#6589 | EnrichedLog |
net472 | 4.22μs | 2.84ns | 11ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 391ns | 0.461ns | 1.79ns | 0.00817 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 557ns | 0.82ns | 3.18ns | 0.00784 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 584ns | 1.27ns | 4.91ns | 0.0915 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 515ns | 0.487ns | 1.89ns | 0.00983 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 742ns | 1.68ns | 6.07ns | 0.00932 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 839ns | 2.27ns | 8.78ns | 0.105 | 0 | 0 | 658 B |
#6589 | StartFinishSpan |
net6.0 | 387ns | 0.587ns | 2.27ns | 0.00805 | 0 | 0 | 576 B |
#6589 | StartFinishSpan |
netcoreapp3.1 | 615ns | 1.17ns | 4.54ns | 0.00772 | 0 | 0 | 576 B |
#6589 | StartFinishSpan |
net472 | 620ns | 1.02ns | 3.94ns | 0.0915 | 0 | 0 | 578 B |
#6589 | StartFinishScope |
net6.0 | 466ns | 0.929ns | 3.6ns | 0.0098 | 0 | 0 | 696 B |
#6589 | StartFinishScope |
netcoreapp3.1 | 679ns | 1.05ns | 3.93ns | 0.00958 | 0 | 0 | 696 B |
#6589 | StartFinishScope |
net472 | 841ns | 1.83ns | 7.1ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6589
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.206
731.18
606.26
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.206 | 731.18 | 606.26 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 733ns | 1.3ns | 5.05ns | 0.00951 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 907ns | 1.48ns | 5.73ns | 0.00936 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.16μs | 1.52ns | 5.88ns | 0.105 | 0 | 0 | 658 B |
#6589 | RunOnMethodBegin |
net6.0 | 607ns | 0.764ns | 2.96ns | 0.00989 | 0 | 0 | 696 B |
#6589 | RunOnMethodBegin |
netcoreapp3.1 | 948ns | 1.33ns | 5.13ns | 0.00945 | 0 | 0 | 696 B |
#6589 | RunOnMethodBegin |
net472 | 1.13μs | 2.64ns | 10.2ns | 0.104 | 0 | 0 | 658 B |
9822db6
to
08b889b
Compare
0bf6824
to
c51cf91
Compare
674746c
to
97591c5
Compare
67ced7d
to
734bc52
Compare
445ad63
to
eab3518
Compare
profiler/src/ProfilerEngine/Datadog.Profiler.Native/CrashReportingHelper.hpp
Show resolved
Hide resolved
profiler/src/ProfilerEngine/Datadog.Profiler.Native/CrashReporting.cpp
Outdated
Show resolved
Hide resolved
0f35271
to
e35c475
Compare
Summary of changes
Bump libdatadog to v16.0.3
Reason for change
Benefit from updates and new crash report.
Implementation details
Update package version and ajust api calls + testing.
Test coverage
Other details