Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiler/Crashtracker] Bump libdatadog 16.0.3 #6589

Merged
merged 24 commits into from
Feb 19, 2025

Conversation

gleocadie
Copy link
Collaborator

@gleocadie gleocadie commented Jan 23, 2025

Summary of changes

Bump libdatadog to v16.0.3

Reason for change

Benefit from updates and new crash report.

Implementation details

Update package version and ajust api calls + testing.

Test coverage

Other details

@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Jan 23, 2025
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 23, 2025

Datadog Report

Branch report: gleocadie/bump-libdatadog-15
Commit report: a4db16e
Test service: dd-trace-dotnet

✅ 0 Failed, 253072 Passed, 2963 Skipped, 20h 6m 6.22s Total Time

@gleocadie gleocadie force-pushed the gleocadie/bump-libdatadog-15 branch from e8ff9f1 to 3ed3ff9 Compare January 23, 2025 17:57
@andrewlock
Copy link
Member

andrewlock commented Jan 23, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6589) - mean (70ms)  : 65, 75
     .   : milestone, 70,
    master - mean (69ms)  : 65, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6589) - mean (1,009ms)  : 978, 1041
     .   : milestone, 1009,
    master - mean (1,001ms)  : 978, 1024
     .   : milestone, 1001,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6589) - mean (104ms)  : 102, 106
     .   : milestone, 104,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6589) - mean (677ms)  : 663, 692
     .   : milestone, 677,
    master - mean (676ms)  : 659, 693
     .   : milestone, 676,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6589) - mean (89ms)  : 87, 92
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6589) - mean (643ms)  : 614, 672
     .   : milestone, 643,
    master - mean (632ms)  : 616, 648
     .   : milestone, 632,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6589) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6589) - mean (1,108ms)  : 1086, 1130
     .   : milestone, 1108,
    master - mean (1,108ms)  : 1072, 1144
     .   : milestone, 1108,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6589) - mean (272ms)  : 267, 277
     .   : milestone, 272,
    master - mean (270ms)  : 264, 276
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (6589) - mean (865ms)  : 835, 895
     .   : milestone, 865,
    master - mean (863ms)  : 834, 892
     .   : milestone, 863,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6589) - mean (263ms)  : 259, 266
     .   : milestone, 263,
    master - mean (263ms)  : 259, 267
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (6589) - mean (848ms)  : 806, 890
     .   : milestone, 848,
    master - mean (844ms)  : 806, 882
     .   : milestone, 844,

Loading

@gleocadie gleocadie force-pushed the gleocadie/bump-libdatadog-15 branch from ca59430 to 86d92df Compare January 23, 2025 19:54
@andrewlock
Copy link
Member

andrewlock commented Jan 23, 2025

Benchmarks Report for tracer 🐌

Benchmarks for #6589 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.206
  • 1 benchmarks are slower, with geometric mean 1.199
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.86μs 43ns 262ns 0.0203 0.00811 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 55.5ns 324ns 0.0199 0.00996 0 5.8 KB
master StartStopWithChild net472 15.9μs 38.1ns 142ns 1.04 0.307 0.0944 6.21 KB
#6589 StartStopWithChild net6.0 7.9μs 42.7ns 238ns 0.012 0.00398 0 5.6 KB
#6589 StartStopWithChild netcoreapp3.1 10.2μs 54.3ns 277ns 0.0201 0.00502 0 5.81 KB
#6589 StartStopWithChild net472 15.8μs 47.4ns 177ns 1.06 0.326 0.106 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 492μs 486ns 1.82μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 700μs 282ns 1.05μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 848μs 626ns 2.34μs 0.422 0 0 3.3 KB
#6589 WriteAndFlushEnrichedTraces net6.0 488μs 238ns 890ns 0 0 0 2.7 KB
#6589 WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 354ns 1.37μs 0 0 0 2.7 KB
#6589 WriteAndFlushEnrichedTraces net472 845μs 529ns 1.98μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 132μs 417ns 1.61μs 0.135 0 0 14.47 KB
master SendRequest netcoreapp3.1 147μs 396ns 1.53μs 0.22 0 0 17.27 KB
master SendRequest net472 0.00199ns 0.000288ns 0.00112ns 0 0 0 0 b
#6589 SendRequest net6.0 132μs 279ns 1.08μs 0.196 0 0 14.47 KB
#6589 SendRequest netcoreapp3.1 148μs 142ns 551ns 0.221 0 0 17.27 KB
#6589 SendRequest net472 0.000231ns 0.000163ns 0.000632ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 608μs 3.32μs 18.8μs 0.604 0 0 41.87 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 670μs 3.78μs 27.5μs 0.338 0 0 41.69 KB
master WriteAndFlushEnrichedTraces net472 840μs 2.83μs 10.6μs 8.22 2.47 0.411 53.34 KB
#6589 WriteAndFlushEnrichedTraces net6.0 579μs 2.76μs 17.9μs 0.527 0 0 41.73 KB
#6589 WriteAndFlushEnrichedTraces netcoreapp3.1 671μs 3.41μs 17.7μs 0.343 0 0 41.74 KB
#6589 WriteAndFlushEnrichedTraces net472 858μs 4.22μs 17.4μs 8.47 2.42 0.403 53.3 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.44μs 2.09ns 8.1ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.75μs 2.38ns 9.22ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.07μs 4.15ns 16.1ns 0.156 0.00103 0 987 B
#6589 ExecuteNonQuery net6.0 1.34μs 1.7ns 6.36ns 0.0141 0 0 1.02 KB
#6589 ExecuteNonQuery netcoreapp3.1 1.81μs 2.82ns 10.9ns 0.0136 0 0 1.02 KB
#6589 ExecuteNonQuery net472 2.09μs 1.57ns 6.09ns 0.156 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 0.404ns 1.51ns 0.0139 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.5μs 0.958ns 3.59ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.46μs 2.36ns 9.14ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.37μs 1.01ns 3.76ns 0.013 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.71μs 0.965ns 3.61ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.67μs 1.97ns 7.63ns 0.166 0 0 1.05 KB
#6589 CallElasticsearch net6.0 1.27μs 1.05ns 4.07ns 0.0139 0 0 976 B
#6589 CallElasticsearch netcoreapp3.1 1.44μs 0.574ns 2.07ns 0.013 0 0 976 B
#6589 CallElasticsearch net472 2.55μs 1.23ns 4.77ns 0.158 0 0 995 B
#6589 CallElasticsearchAsync net6.0 1.34μs 0.752ns 2.81ns 0.0135 0 0 952 B
#6589 CallElasticsearchAsync netcoreapp3.1 1.63μs 0.38ns 1.32ns 0.0138 0 0 1.02 KB
#6589 CallElasticsearchAsync net472 2.58μs 1.77ns 6.85ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.44μs 1.02ns 3.96ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.71μs 0.954ns 3.7ns 0.012 0 0 952 B
master ExecuteAsync net472 1.86μs 0.559ns 2.09ns 0.145 0 0 915 B
#6589 ExecuteAsync net6.0 1.31μs 0.584ns 2.18ns 0.0131 0 0 952 B
#6589 ExecuteAsync netcoreapp3.1 1.66μs 1.55ns 6.01ns 0.0125 0 0 952 B
#6589 ExecuteAsync net472 1.84μs 0.678ns 2.63ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.41μs 1.19ns 4.47ns 0.0331 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.35μs 3.47ns 13ns 0.0374 0 0 2.85 KB
master SendAsync net472 7.37μs 2.03ns 7.85ns 0.495 0 0 3.12 KB
#6589 SendAsync net6.0 4.42μs 2.18ns 8.17ns 0.0309 0 0 2.31 KB
#6589 SendAsync netcoreapp3.1 5.39μs 1.48ns 5.53ns 0.0373 0 0 2.85 KB
#6589 SendAsync net472 7.42μs 2.11ns 8.17ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.58μs 0.493ns 1.78ns 0.023 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.19μs 1.07ns 3.99ns 0.0228 0 0 1.64 KB
master EnrichedLog net472 2.67μs 4.35ns 16.9ns 0.25 0 0 1.57 KB
#6589 EnrichedLog net6.0 1.63μs 0.563ns 2.11ns 0.0228 0 0 1.64 KB
#6589 EnrichedLog netcoreapp3.1 2.25μs 1.17ns 4.38ns 0.0218 0 0 1.64 KB
#6589 EnrichedLog net472 2.55μs 1.45ns 5.43ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 212ns 822ns 0.0558 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 117μs 148ns 573ns 0.0582 0 0 4.28 KB
master EnrichedLog net472 151μs 82.1ns 307ns 0.681 0.227 0 4.46 KB
#6589 EnrichedLog net6.0 115μs 158ns 610ns 0.0568 0 0 4.28 KB
#6589 EnrichedLog netcoreapp3.1 119μs 238ns 923ns 0.059 0 0 4.28 KB
#6589 EnrichedLog net472 150μs 200ns 774ns 0.675 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.11μs 0.496ns 1.72ns 0.0311 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.2μs 2.35ns 8.79ns 0.0294 0 0 2.2 KB
master EnrichedLog net472 5.03μs 1.01ns 3.79ns 0.32 0 0 2.02 KB
#6589 EnrichedLog net6.0 2.98μs 0.673ns 2.52ns 0.0314 0 0 2.2 KB
#6589 EnrichedLog netcoreapp3.1 4.26μs 1.57ns 6.09ns 0.0299 0 0 2.2 KB
#6589 EnrichedLog net472 4.89μs 0.91ns 3.52ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6589

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.199 1,271.89 1,524.93

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.27μs 0.38ns 1.47ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.77μs 0.486ns 1.68ns 0.015 0 0 1.14 KB
master SendReceive net472 2.12μs 2.85ns 11.1ns 0.183 0 0 1.16 KB
#6589 SendReceive net6.0 1.52μs 1.24ns 4.81ns 0.0159 0 0 1.14 KB
#6589 SendReceive netcoreapp3.1 1.69μs 0.781ns 3.02ns 0.0159 0 0 1.14 KB
#6589 SendReceive net472 2.19μs 0.825ns 3.2ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.77μs 1.19ns 4.44ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.97μs 5.6ns 20.9ns 0.0217 0 0 1.65 KB
master EnrichedLog net472 4.3μs 3.26ns 12.6ns 0.323 0 0 2.04 KB
#6589 EnrichedLog net6.0 2.78μs 2.75ns 10.3ns 0.0222 0 0 1.6 KB
#6589 EnrichedLog netcoreapp3.1 3.92μs 1.99ns 7.73ns 0.0216 0 0 1.65 KB
#6589 EnrichedLog net472 4.22μs 2.84ns 11ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 391ns 0.461ns 1.79ns 0.00817 0 0 576 B
master StartFinishSpan netcoreapp3.1 557ns 0.82ns 3.18ns 0.00784 0 0 576 B
master StartFinishSpan net472 584ns 1.27ns 4.91ns 0.0915 0 0 578 B
master StartFinishScope net6.0 515ns 0.487ns 1.89ns 0.00983 0 0 696 B
master StartFinishScope netcoreapp3.1 742ns 1.68ns 6.07ns 0.00932 0 0 696 B
master StartFinishScope net472 839ns 2.27ns 8.78ns 0.105 0 0 658 B
#6589 StartFinishSpan net6.0 387ns 0.587ns 2.27ns 0.00805 0 0 576 B
#6589 StartFinishSpan netcoreapp3.1 615ns 1.17ns 4.54ns 0.00772 0 0 576 B
#6589 StartFinishSpan net472 620ns 1.02ns 3.94ns 0.0915 0 0 578 B
#6589 StartFinishScope net6.0 466ns 0.929ns 3.6ns 0.0098 0 0 696 B
#6589 StartFinishScope netcoreapp3.1 679ns 1.05ns 3.93ns 0.00958 0 0 696 B
#6589 StartFinishScope net472 841ns 1.83ns 7.1ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6589

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.206 731.18 606.26

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 733ns 1.3ns 5.05ns 0.00951 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 907ns 1.48ns 5.73ns 0.00936 0 0 696 B
master RunOnMethodBegin net472 1.16μs 1.52ns 5.88ns 0.105 0 0 658 B
#6589 RunOnMethodBegin net6.0 607ns 0.764ns 2.96ns 0.00989 0 0 696 B
#6589 RunOnMethodBegin netcoreapp3.1 948ns 1.33ns 5.13ns 0.00945 0 0 696 B
#6589 RunOnMethodBegin net472 1.13μs 2.64ns 10.2ns 0.104 0 0 658 B

@gleocadie gleocadie force-pushed the gleocadie/bump-libdatadog-15 branch 4 times, most recently from 9822db6 to 08b889b Compare January 27, 2025 12:08
@gleocadie gleocadie force-pushed the gleocadie/bump-libdatadog-15 branch 3 times, most recently from 0bf6824 to c51cf91 Compare February 10, 2025 08:43
@gleocadie gleocadie changed the title [Profiler/Crashtracker] Bump libdatadog 15 [Profiler/Crashtracker] Bump libdatadog 16.0.1 Feb 10, 2025
@gleocadie gleocadie force-pushed the gleocadie/bump-libdatadog-15 branch 2 times, most recently from 674746c to 97591c5 Compare February 11, 2025 13:37
@gleocadie gleocadie changed the title [Profiler/Crashtracker] Bump libdatadog 16.0.1 [Profiler/Crashtracker] Bump libdatadog 16.0.2 Feb 11, 2025
@gleocadie gleocadie force-pushed the gleocadie/bump-libdatadog-15 branch 2 times, most recently from 67ced7d to 734bc52 Compare February 18, 2025 16:50
@gleocadie gleocadie changed the title [Profiler/Crashtracker] Bump libdatadog 16.0.2 [Profiler/Crashtracker] Bump libdatadog 16.0.3 Feb 18, 2025
@gleocadie gleocadie force-pushed the gleocadie/bump-libdatadog-15 branch from 445ad63 to eab3518 Compare February 19, 2025 09:08
@gleocadie gleocadie marked this pull request as ready for review February 19, 2025 09:09
@gleocadie gleocadie requested review from a team as code owners February 19, 2025 09:09
@gleocadie gleocadie force-pushed the gleocadie/bump-libdatadog-15 branch from 0f35271 to e35c475 Compare February 19, 2025 09:54
@gleocadie gleocadie merged commit 20f2bf1 into master Feb 19, 2025
151 of 153 checks passed
@gleocadie gleocadie deleted the gleocadie/bump-libdatadog-15 branch February 19, 2025 16:39
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:profiler Issues related to the continous-profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants