Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Package Versions Bump] Updating package versions #6450

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[Test Package Versions Bump] Updating package versions #6450

merged 1 commit into from
Dec 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners December 17, 2024 12:28
andrewlock
andrewlock approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass, :shipit:

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Dec 17, 2024 •
edited
Loading

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 4d06736
Test service: dd-trace-dotnet

✅ 0 Failed, 459055 Passed, 2826 Skipped, 19h 26m 29.92s Total Time

@andrewlock
Copy link
Member

andrewlock commented Dec 17, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6450) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6450) - mean (975ms)  : 959, 992
     .   : milestone, 975,
    master - mean (977ms)  : 958, 996
     .   : milestone, 977,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6450) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6450) - mean (680ms)  : 667, 694
     .   : milestone, 680,
    master - mean (677ms)  : 662, 692
     .   : milestone, 677,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6450) - mean (91ms)  : 90, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 92
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6450) - mean (634ms)  : 615, 653
     .   : milestone, 634,
    master - mean (633ms)  : 611, 655
     .   : milestone, 633,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6450) - mean (194ms)  : 189, 199
     .   : milestone, 194,
    master - mean (194ms)  : 190, 198
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6450) - mean (1,115ms)  : 1085, 1146
     .   : milestone, 1115,
    master - mean (1,102ms)  : 1072, 1132
     .   : milestone, 1102,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6450) - mean (278ms)  : 274, 281
     .   : milestone, 278,
    master - mean (279ms)  : 275, 282
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6450) - mean (872ms)  : 848, 896
     .   : milestone, 872,
    master - mean (874ms)  : 844, 904
     .   : milestone, 874,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6450) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (267ms)  : 263, 272
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6450) - mean (858ms)  : 827, 890
     .   : milestone, 858,
    master - mean (851ms)  : 816, 885
     .   : milestone, 851,
Loading

@andrewlock
Copy link
Member

andrewlock commented Dec 17, 2024 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6450 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.139
  • 3 benchmarks are slower, with geometric mean 1.141
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.11μs 42ns 214ns 0.0196 0.0118 0.00392 5.61 KB
master StartStopWithChild netcoreapp3.1 10.4μs 57.6ns 373ns 0.0254 0.0102 0 5.8 KB
master StartStopWithChild net472 16.3μs 40ns 155ns 1.05 0.319 0.0982 6.2 KB
#6450 StartStopWithChild net6.0 7.92μs 45.1ns 344ns 0.0159 0.00794 0 5.61 KB
#6450 StartStopWithChild netcoreapp3.1 10μs 52.7ns 284ns 0.0156 0.00519 0 5.81 KB
#6450 StartStopWithChild net472 16.6μs 40.1ns 155ns 1.03 0.301 0.0895 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 483μs 284ns 1.1μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 657μs 552ns 2.06μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 854μs 523ns 1.96μs 0.425 0 0 3.3 KB
#6450 WriteAndFlushEnrichedTraces net6.0 495μs 249ns 898ns 0 0 0 2.7 KB
#6450 WriteAndFlushEnrichedTraces netcoreapp3.1 657μs 636ns 2.38μs 0 0 0 2.7 KB
#6450 WriteAndFlushEnrichedTraces net472 843μs 541ns 1.95μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 148μs 849ns 6.58μs 0.151 0 0 14.47 KB
master SendRequest netcoreapp3.1 170μs 972ns 7.27μs 0.165 0 0 17.27 KB
master SendRequest net472 0.00276ns 0.00103ns 0.00399ns 0 0 0 0 b
#6450 SendRequest net6.0 162μs 1.11μs 11μs 0.14 0 0 14.48 KB
#6450 SendRequest netcoreapp3.1 177μs 1.19μs 11.5μs 0.168 0 0 17.27 KB
#6450 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 571μs 2.48μs 9.27μs 0.561 0 0 41.47 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 666μs 3.63μs 21.5μs 0.334 0 0 41.73 KB
master WriteAndFlushEnrichedTraces net472 844μs 3.68μs 14.3μs 8.28 2.48 0.414 53.3 KB
#6450 WriteAndFlushEnrichedTraces net6.0 562μs 2.28μs 11.2μs 0.576 0 0 41.57 KB
#6450 WriteAndFlushEnrichedTraces netcoreapp3.1 718μs 4.19μs 39.1μs 0.355 0 0 41.53 KB
#6450 WriteAndFlushEnrichedTraces net472 893μs 4.54μs 21.3μs 8.8 2.64 0.44 53.3 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.28μs 1.26ns 4.72ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.77μs 0.992ns 3.71ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.07μs 1.84ns 7.11ns 0.156 0.00104 0 987 B
#6450 ExecuteNonQuery net6.0 1.37μs 1.91ns 7.14ns 0.0145 0 0 1.02 KB
#6450 ExecuteNonQuery netcoreapp3.1 1.79μs 1.94ns 7.51ns 0.0133 0 0 1.02 KB
#6450 ExecuteNonQuery net472 2.11μs 1.91ns 7.38ns 0.157 0.00105 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6450

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.147 1,268.16 1,454.36

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.3μs 0.655ns 2.45ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.58μs 1.02ns 3.83ns 0.0126 0 0 976 B
master CallElasticsearch net472 2.57μs 2.47ns 9.56ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.27μs 0.739ns 2.86ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.61μs 0.991ns 3.71ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.61μs 2.05ns 7.95ns 0.167 0 0 1.05 KB
#6450 CallElasticsearch net6.0 1.31μs 0.944ns 3.53ns 0.0136 0 0 976 B
#6450 CallElasticsearch netcoreapp3.1 1.54μs 1.39ns 5.2ns 0.0131 0 0 976 B
#6450 CallElasticsearch net472 2.45μs 2.78ns 10.8ns 0.158 0 0 995 B
#6450 CallElasticsearchAsync net6.0 1.46μs 2.67ns 9.64ns 0.0131 0 0 952 B
#6450 CallElasticsearchAsync netcoreapp3.1 1.68μs 0.52ns 1.94ns 0.0134 0 0 1.02 KB
#6450 CallElasticsearchAsync net472 2.52μs 2.14ns 8.28ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.4μs 0.731ns 2.74ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.57μs 0.918ns 3.56ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.72μs 0.428ns 1.66ns 0.145 0 0 915 B
#6450 ExecuteAsync net6.0 1.39μs 0.525ns 1.96ns 0.0133 0 0 952 B
#6450 ExecuteAsync netcoreapp3.1 1.67μs 0.778ns 2.91ns 0.0125 0 0 952 B
#6450 ExecuteAsync net472 1.76μs 0.597ns 2.23ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.36μs 1.36ns 5.1ns 0.0327 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.2μs 1.52ns 5.89ns 0.0363 0 0 2.85 KB
master SendAsync net472 7.37μs 1.75ns 6.56ns 0.495 0 0 3.12 KB
#6450 SendAsync net6.0 4.52μs 1.79ns 6.69ns 0.0315 0 0 2.31 KB
#6450 SendAsync netcoreapp3.1 5.21μs 2.13ns 7.96ns 0.0391 0 0 2.85 KB
#6450 SendAsync net472 7.37μs 2.82ns 10.5ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.58μs 1.01ns 3.91ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.21μs 1.18ns 4.56ns 0.0222 0 0 1.64 KB
master EnrichedLog net472 2.75μs 2.26ns 8.45ns 0.249 0 0 1.57 KB
#6450 EnrichedLog net6.0 1.5μs 1.7ns 6.35ns 0.0231 0 0 1.64 KB
#6450 EnrichedLog netcoreapp3.1 2.36μs 1.63ns 6.09ns 0.0213 0 0 1.64 KB
#6450 EnrichedLog net472 2.68μs 0.705ns 2.44ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 104ns 404ns 0.0582 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 170ns 659ns 0 0 0 4.28 KB
master EnrichedLog net472 150μs 93.9ns 364ns 0.677 0.226 0 4.46 KB
#6450 EnrichedLog net6.0 117μs 120ns 463ns 0.058 0 0 4.28 KB
#6450 EnrichedLog netcoreapp3.1 125μs 242ns 939ns 0 0 0 4.28 KB
#6450 EnrichedLog net472 153μs 187ns 726ns 0.685 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.08μs 1.32ns 5.13ns 0.0307 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.39μs 1.79ns 6.71ns 0.0284 0 0 2.2 KB
master EnrichedLog net472 4.85μs 1.05ns 4.06ns 0.32 0 0 2.02 KB
#6450 EnrichedLog net6.0 3.1μs 1.14ns 4.25ns 0.0312 0 0 2.2 KB
#6450 EnrichedLog netcoreapp3.1 4.18μs 2.18ns 8.44ns 0.0292 0 0 2.2 KB
#6450 EnrichedLog net472 5.14μs 1.72ns 6.67ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6450

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.125 2,310.74 2,054.66

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 0.554ns 2.15ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 1.06ns 4.1ns 0.0149 0 0 1.14 KB
master SendReceive net472 2.31μs 2.66ns 10.3ns 0.183 0 0 1.16 KB
#6450 SendReceive net6.0 1.41μs 0.703ns 2.54ns 0.0162 0 0 1.14 KB
#6450 SendReceive netcoreapp3.1 1.73μs 1.51ns 5.63ns 0.0157 0 0 1.14 KB
#6450 SendReceive net472 2.06μs 1.46ns 5.66ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.79μs 1.08ns 3.9ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4μs 2.07ns 8.01ns 0.0219 0 0 1.65 KB
master EnrichedLog net472 4.31μs 2.36ns 9.14ns 0.324 0 0 2.04 KB
#6450 EnrichedLog net6.0 2.71μs 0.389ns 1.4ns 0.0218 0 0 1.6 KB
#6450 EnrichedLog netcoreapp3.1 3.92μs 2.84ns 11ns 0.0217 0 0 1.65 KB
#6450 EnrichedLog net472 4.41μs 3.98ns 15.4ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6450

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.140 638.67 728.07
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.136 682.18 775.22

Faster 🎉 in #6450

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.153 952.73 825.96

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 398ns 0.208ns 0.806ns 0.00802 0 0 576 B
master StartFinishSpan netcoreapp3.1 614ns 0.369ns 1.33ns 0.00782 0 0 576 B
master StartFinishSpan net472 638ns 0.308ns 1.19ns 0.0917 0 0 578 B
master StartFinishScope net6.0 492ns 0.231ns 0.865ns 0.00969 0 0 696 B
master StartFinishScope netcoreapp3.1 683ns 1.07ns 4.16ns 0.00924 0 0 696 B
master StartFinishScope net472 952ns 0.591ns 2.29ns 0.104 0 0 658 B
#6450 StartFinishSpan net6.0 425ns 0.367ns 1.42ns 0.00806 0 0 576 B
#6450 StartFinishSpan netcoreapp3.1 590ns 0.621ns 2.4ns 0.0077 0 0 576 B
#6450 StartFinishSpan net472 727ns 0.961ns 3.72ns 0.0917 0 0 578 B
#6450 StartFinishScope net6.0 495ns 0.24ns 0.899ns 0.00965 0 0 696 B
#6450 StartFinishScope netcoreapp3.1 776ns 1.09ns 3.93ns 0.00933 0 0 696 B
#6450 StartFinishScope net472 826ns 0.493ns 1.91ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 614ns 0.303ns 1.18ns 0.00959 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 936ns 3.47ns 13.4ns 0.00939 0 0 696 B
master RunOnMethodBegin net472 1.17μs 1.06ns 4.1ns 0.104 0 0 658 B
#6450 RunOnMethodBegin net6.0 660ns 0.549ns 2.13ns 0.00971 0 0 696 B
#6450 RunOnMethodBegin netcoreapp3.1 993ns 1.32ns 5.13ns 0.00948 0 0 696 B
#6450 RunOnMethodBegin net472 1.15μs 0.521ns 1.95ns 0.104 0 0 658 B

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from ff26b5b to 4d06736 Compare December 17, 2024 16:29
@andrewlock andrewlock merged commit 19d60a0 into master Dec 19, 2024
91 of 93 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch December 19, 2024 15:16
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 19, 2024
@andrewlock andrewlock added area:tests unit tests, integration tests area:test-apps apps used to test integrations dependencies Pull requests that update a dependency file area:dependabot dependabot updates labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:dependabot dependabot updates area:test-apps apps used to test integrations area:tests unit tests, integration tests dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewlock