Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] Fix database tests (netcoreapp3.0) #6442

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[ASM] Fix database tests (netcoreapp3.0) #6442

merged 1 commit into from
Dec 16, 2024

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Dec 16, 2024

Summary of changes

The databases System.Data.SQLite and Microsoft.Data.Sqlite were swapped out in the tests.

Reason for change

Tests were failling on master with netcoreapp3.0:
There was a specific check to skip the test with Microsoft.Data.Sqlite on Alpine for netcoreapp3.0, this was failing on master.

@e-n-0 e-n-0 requested a review from a team as a code owner December 16, 2024 13:40
@github-actions github-actions bot added area:tests unit tests, integration tests area:asm labels Dec 16, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Dec 16, 2024 •
edited
Loading

Datadog Report

Branch report: flavien/db-fix-tests
Commit report: b7a3882
Test service: dd-trace-dotnet

✅ 0 Failed, 462753 Passed, 2855 Skipped, 20h 19m 39.18s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • EarlyFlakeDetection - Datadog.Trace.ClrProfiler.IntegrationTests.CI.NUnitEvpTests - Last Failure

    Expand for error 
     The sample did not exit in 600000ms. Memory dump taken: True. Killing process.

robertpi
robertpi approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@robertpi robertpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and taking care of it!

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6442) - mean (69ms)  : 65, 73
     .   : milestone, 69,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6442) - mean (977ms)  : 955, 1000
     .   : milestone, 977,
    master - mean (976ms)  : 953, 998
     .   : milestone, 976,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6442) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 104, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6442) - mean (677ms)  : 657, 697
     .   : milestone, 677,
    master - mean (679ms)  : 662, 695
     .   : milestone, 679,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6442) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 92
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6442) - mean (632ms)  : 619, 646
     .   : milestone, 632,
    master - mean (635ms)  : 619, 651
     .   : milestone, 635,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6442) - mean (195ms)  : 190, 199
     .   : milestone, 195,
    master - mean (193ms)  : 188, 198
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6442) - mean (1,102ms)  : 1067, 1137
     .   : milestone, 1102,
    master - mean (1,096ms)  : 1070, 1122
     .   : milestone, 1096,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6442) - mean (278ms)  : 273, 283
     .   : milestone, 278,
    master - mean (279ms)  : 275, 284
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6442) - mean (871ms)  : 847, 895
     .   : milestone, 871,
    master - mean (871ms)  : 845, 896
     .   : milestone, 871,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6442) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (266ms)  : 263, 269
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6442) - mean (855ms)  : 818, 892
     .   : milestone, 855,
    master - mean (851ms)  : 818, 884
     .   : milestone, 851,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for appsec 🐌

Benchmarks for #6442 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.129
  • 1 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6442

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net6.0 1.129 138.02 155.88

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 185μs 67.7ns 253ns 2.6 0 0 188.52 KB
master AllCycleSimpleBody netcoreapp3.1 287μs 134ns 503ns 2.71 0 0 195.8 KB
master AllCycleSimpleBody net472 257μs 169ns 653ns 35.7 2.04 0 225.32 KB
master AllCycleMoreComplexBody net6.0 199μs 132ns 493ns 2.71 0 0 192.02 KB
master AllCycleMoreComplexBody netcoreapp3.1 295μs 174ns 650ns 2.65 0 0 199.22 KB
master AllCycleMoreComplexBody net472 259μs 258ns 1E+03ns 36.3 2.08 0 228.83 KB
master ObjectExtractorSimpleBody net6.0 138ns 0.137ns 0.531ns 0.00393 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 190ns 0.113ns 0.408ns 0.00367 0 0 272 B
master ObjectExtractorSimpleBody net472 163ns 0.117ns 0.454ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.91μs 2.12ns 8.22ns 0.0528 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.77μs 2.53ns 9.8ns 0.05 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.64μs 2.81ns 10.5ns 0.603 0.00543 0 3.8 KB
#6442 AllCycleSimpleBody net6.0 204μs 91.8ns 318ns 2.66 0 0 188.38 KB
#6442 AllCycleSimpleBody netcoreapp3.1 302μs 158ns 547ns 2.56 0 0 195.66 KB
#6442 AllCycleSimpleBody net472 269μs 369ns 1.33μs 35.7 2.01 0 225.16 KB
#6442 AllCycleMoreComplexBody net6.0 209μs 206ns 770ns 2.71 0 0 191.88 KB
#6442 AllCycleMoreComplexBody netcoreapp3.1 307μs 136ns 526ns 2.76 0 0 199.07 KB
#6442 AllCycleMoreComplexBody net472 276μs 296ns 1.07μs 36.2 2.07 0 228.67 KB
#6442 ObjectExtractorSimpleBody net6.0 157ns 0.676ns 2.62ns 0.00394 0 0 280 B
#6442 ObjectExtractorSimpleBody netcoreapp3.1 203ns 0.309ns 1.2ns 0.00367 0 0 272 B
#6442 ObjectExtractorSimpleBody net472 175ns 0.222ns 0.831ns 0.0446 0 0 281 B
#6442 ObjectExtractorMoreComplexBody net6.0 2.93μs 2.2ns 8.52ns 0.0527 0 0 3.78 KB
#6442 ObjectExtractorMoreComplexBody netcoreapp3.1 3.89μs 1.78ns 6.66ns 0.0507 0 0 3.69 KB
#6442 ObjectExtractorMoreComplexBody net472 3.65μs 1.94ns 6.73ns 0.602 0.00548 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 36.9μs 28ns 108ns 0.444 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 54.5μs 42.1ns 163ns 0.431 0 0 32.4 KB
master EncodeArgs net472 67.2μs 60.2ns 225ns 5.14 0.0671 0 32.5 KB
master EncodeLegacyArgs net6.0 71.2μs 155ns 580ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 109μs 289ns 1.12μs 0 0 0 2.15 KB
master EncodeLegacyArgs net472 152μs 78.7ns 305ns 0.303 0 0 2.15 KB
#6442 EncodeArgs net6.0 36.3μs 18.4ns 71.2ns 0.455 0 0 32.4 KB
#6442 EncodeArgs netcoreapp3.1 54.3μs 36.3ns 136ns 0.433 0 0 32.4 KB
#6442 EncodeArgs net472 66.2μs 97.1ns 376ns 5.16 0.0662 0 32.5 KB
#6442 EncodeLegacyArgs net6.0 77.1μs 431ns 2.73μs 0 0 0 2.14 KB
#6442 EncodeLegacyArgs netcoreapp3.1 106μs 312ns 1.21μs 0 0 0 2.14 KB
#6442 EncodeLegacyArgs net472 153μs 78.4ns 304ns 0.306 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 182μs 172ns 668ns 0 0 0 2.44 KB
master RunWafRealisticBenchmark netcoreapp3.1 196μs 190ns 736ns 0 0 0 2.39 KB
master RunWafRealisticBenchmark net472 210μs 198ns 766ns 0.312 0 0 2.46 KB
master RunWafRealisticBenchmarkWithAttack net6.0 122μs 74.1ns 287ns 0 0 0 1.47 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 128μs 88ns 341ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack net472 140μs 40.3ns 151ns 0.209 0 0 1.49 KB
#6442 RunWafRealisticBenchmark net6.0 184μs 156ns 605ns 0 0 0 2.44 KB
#6442 RunWafRealisticBenchmark netcoreapp3.1 195μs 289ns 1.12μs 0 0 0 2.39 KB
#6442 RunWafRealisticBenchmark net472 208μs 111ns 414ns 0.314 0 0 2.46 KB
#6442 RunWafRealisticBenchmarkWithAttack net6.0 123μs 47.9ns 185ns 0 0 0 1.47 KB
#6442 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 130μs 104ns 401ns 0 0 0 1.46 KB
#6442 RunWafRealisticBenchmarkWithAttack net472 139μs 64.5ns 250ns 0.209 0 0 1.49 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6442

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 252.92 KB 264.78 KB 11.86 KB 4.69%

Fewer allocations 🎉 in #6442

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 62.46 KB 59.04 KB -3.42 KB -5.48%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 58.4μs 717ns 7.1μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 52.9μs 235ns 912ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 36.9μs 125ns 468ns 0 0 0 62.46 KB
master StringConcatAspectBenchmark net6.0 310μs 1.76μs 12.4μs 0 0 0 254.37 KB
master StringConcatAspectBenchmark netcoreapp3.1 338μs 1.6μs 6.59μs 0 0 0 252.92 KB
master StringConcatAspectBenchmark net472 281μs 5.99μs 58.1μs 0 0 0 278.53 KB
#6442 StringConcatBenchmark net6.0 59.7μs 943ns 9.43μs 0 0 0 43.44 KB
#6442 StringConcatBenchmark netcoreapp3.1 54.6μs 312ns 2.21μs 0 0 0 42.64 KB
#6442 StringConcatBenchmark net472 36.7μs 69.1ns 258ns 0 0 0 59.04 KB
#6442 StringConcatAspectBenchmark net6.0 297μs 5.02μs 48.7μs 0 0 0 253.74 KB
#6442 StringConcatAspectBenchmark netcoreapp3.1 353μs 1.94μs 12.4μs 0 0 0 264.78 KB
#6442 StringConcatAspectBenchmark net472 283μs 5.97μs 56.9μs 0 0 0 278.53 KB

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6442) (11.077M)   : 0, 11076540
    master (11.173M)   : 0, 11172862
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6442) (7.267M)   : 0, 7266854
    master (7.214M)   : 0, 7214402
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.560M)   : 0, 7559850

    section Manual
    master (11.194M)   : 0, 11193707

    section Manual + Automatic
    This PR (6442) (6.681M)   : 0, 6681305
    master (6.718M)   : 0, 6717525

    section DD_TRACE_ENABLED=0
    master (10.296M)   : 0, 10295976
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6442) (9.661M)   : 0, 9661239
    master (9.776M)   : 0, 9776047
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6442) (6.414M)   : 0, 6413770
    master (6.425M)   : 0, 6425271

    section Trace stats
    master (6.758M)   : 0, 6757513

    section Manual
    master (9.661M)   : 0, 9660549

    section Manual + Automatic
    This PR (6442) (5.920M)   : 0, 5920310
    master (6.039M)   : 0, 6038872

    section DD_TRACE_ENABLED=0
    master (8.861M)   : 0, 8860501
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6442) (9.636M)   : 0, 9635594
    master (9.399M)   : 0, 9399211
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6442) (6.106M)   : 0, 6105500
    master (5.619M)   : 0, 5618747
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.816M)   : 0, 6816490

    section Manual
    master (9.559M)   : 0, 9558747

    section Manual + Automatic
    This PR (6442) (5.624M)   : crit ,0, 5623818
    master (6.022M)   : 0, 6022498

    section DD_TRACE_ENABLED=0
    master (9.201M)   : 0, 9201064
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6442 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.130
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.02μs 43.7ns 287ns 0.0157 0.00784 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 46.8ns 181ns 0.0201 0.0101 0 5.8 KB
master StartStopWithChild net472 16.4μs 38.9ns 151ns 1.04 0.303 0.0983 6.2 KB
#6442 StartStopWithChild net6.0 8.02μs 43.8ns 270ns 0.0165 0.00413 0 5.61 KB
#6442 StartStopWithChild netcoreapp3.1 10.1μs 49.8ns 263ns 0.0205 0.0102 0 5.8 KB
#6442 StartStopWithChild net472 16.5μs 51.1ns 198ns 1.06 0.326 0.0977 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 484μs 785ns 3.04μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 666μs 1.74μs 6.75μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 847μs 757ns 2.62μs 0.422 0 0 3.3 KB
#6442 WriteAndFlushEnrichedTraces net6.0 477μs 324ns 1.25μs 0 0 0 2.7 KB
#6442 WriteAndFlushEnrichedTraces netcoreapp3.1 643μs 332ns 1.24μs 0 0 0 2.7 KB
#6442 WriteAndFlushEnrichedTraces net472 850μs 663ns 2.48μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 149μs 869ns 8.24μs 0.153 0 0 14.47 KB
master SendRequest netcoreapp3.1 169μs 976ns 8.4μs 0.17 0 0 17.27 KB
master SendRequest net472 0.000589ns 0.000489ns 0.00183ns 0 0 0 0 b
#6442 SendRequest net6.0 151μs 872ns 7.65μs 0.141 0 0 14.47 KB
#6442 SendRequest netcoreapp3.1 163μs 781ns 3.49μs 0.16 0 0 17.27 KB
#6442 SendRequest net472 0.000134ns 0.000134ns 0.000484ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 588μs 3.25μs 19.2μs 0.561 0 0 41.79 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 653μs 2.92μs 16μs 0.331 0 0 41.87 KB
master WriteAndFlushEnrichedTraces net472 838μs 4.22μs 17.9μs 8.52 2.44 0.406 53.26 KB
#6442 WriteAndFlushEnrichedTraces net6.0 556μs 2.12μs 8.2μs 0.546 0 0 41.71 KB
#6442 WriteAndFlushEnrichedTraces netcoreapp3.1 666μs 2.31μs 8.95μs 0.327 0 0 41.75 KB
#6442 WriteAndFlushEnrichedTraces net472 830μs 3.87μs 15μs 8.22 2.47 0.411 53.26 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.3μs 1.02ns 3.94ns 0.0146 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.81μs 2.54ns 9.85ns 0.0136 0 0 1.02 KB
master ExecuteNonQuery net472 2.14μs 1.84ns 7.12ns 0.157 0.00107 0 987 B
#6442 ExecuteNonQuery net6.0 1.3μs 1.14ns 4.4ns 0.0143 0 0 1.02 KB
#6442 ExecuteNonQuery netcoreapp3.1 1.74μs 1.99ns 7.73ns 0.0139 0 0 1.02 KB
#6442 ExecuteNonQuery net472 2.11μs 1.62ns 6.26ns 0.156 0.00105 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.33μs 0.64ns 2.48ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.55μs 1.39ns 5.2ns 0.013 0 0 976 B
master CallElasticsearch net472 2.59μs 2.4ns 9.28ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.36μs 0.422ns 1.52ns 0.0128 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.64μs 1.02ns 3.93ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.58μs 2.13ns 8.26ns 0.166 0 0 1.05 KB
#6442 CallElasticsearch net6.0 1.33μs 0.534ns 2ns 0.014 0 0 976 B
#6442 CallElasticsearch netcoreapp3.1 1.59μs 2.88ns 9.98ns 0.0126 0 0 976 B
#6442 CallElasticsearch net472 2.64μs 0.752ns 2.81ns 0.158 0 0 995 B
#6442 CallElasticsearchAsync net6.0 1.34μs 0.51ns 1.91ns 0.0134 0 0 952 B
#6442 CallElasticsearchAsync netcoreapp3.1 1.68μs 1.28ns 4.97ns 0.0132 0 0 1.02 KB
#6442 CallElasticsearchAsync net472 2.69μs 1.25ns 4.68ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.38μs 0.494ns 1.91ns 0.0128 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.6μs 0.436ns 1.63ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.82μs 0.371ns 1.39ns 0.145 0 0 915 B
#6442 ExecuteAsync net6.0 1.26μs 1.09ns 3.92ns 0.0131 0 0 952 B
#6442 ExecuteAsync netcoreapp3.1 1.58μs 1.44ns 5.59ns 0.0127 0 0 952 B
#6442 ExecuteAsync net472 1.84μs 0.378ns 1.46ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.3μs 1.95ns 7.54ns 0.0323 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.33μs 1.59ns 5.97ns 0.0374 0 0 2.85 KB
master SendAsync net472 7.38μs 1.78ns 6.88ns 0.494 0 0 3.12 KB
#6442 SendAsync net6.0 4.51μs 1.91ns 7.4ns 0.0315 0 0 2.31 KB
#6442 SendAsync netcoreapp3.1 5.13μs 2.46ns 9.21ns 0.0386 0 0 2.85 KB
#6442 SendAsync net472 7.37μs 1.95ns 7.03ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.48μs 0.72ns 2.69ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.43μs 2.01ns 7.79ns 0.0219 0 0 1.64 KB
master EnrichedLog net472 2.8μs 1.47ns 5.68ns 0.249 0 0 1.57 KB
#6442 EnrichedLog net6.0 1.54μs 1ns 3.47ns 0.0232 0 0 1.64 KB
#6442 EnrichedLog netcoreapp3.1 2.31μs 1.23ns 4.61ns 0.0221 0 0 1.64 KB
#6442 EnrichedLog net472 2.77μs 1.06ns 4.11ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 243ns 941ns 0.0591 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 171ns 662ns 0 0 0 4.28 KB
master EnrichedLog net472 154μs 81.5ns 294ns 0.684 0.228 0 4.46 KB
#6442 EnrichedLog net6.0 118μs 354ns 1.37μs 0.0591 0 0 4.28 KB
#6442 EnrichedLog netcoreapp3.1 120μs 172ns 666ns 0 0 0 4.28 KB
#6442 EnrichedLog net472 152μs 129ns 500ns 0.683 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.02μs 1.06ns 4.1ns 0.0299 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.25μs 2.98ns 11.5ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 4.89μs 1.4ns 5.42ns 0.32 0 0 2.02 KB
#6442 EnrichedLog net6.0 3.07μs 2.16ns 7.8ns 0.0309 0 0 2.2 KB
#6442 EnrichedLog netcoreapp3.1 4.04μs 1.71ns 6.64ns 0.0287 0 0 2.2 KB
#6442 EnrichedLog net472 4.82μs 1.45ns 5.63ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.31μs 0.911ns 3.53ns 0.0157 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.93μs 0.778ns 3.01ns 0.0154 0 0 1.14 KB
master SendReceive net472 2.21μs 0.887ns 3.44ns 0.183 0 0 1.16 KB
#6442 SendReceive net6.0 1.42μs 0.582ns 2.25ns 0.0157 0 0 1.14 KB
#6442 SendReceive netcoreapp3.1 1.78μs 0.954ns 3.69ns 0.0151 0 0 1.14 KB
#6442 SendReceive net472 2.1μs 1.56ns 5.83ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.75μs 0.668ns 2.41ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.9μs 2.14ns 8.29ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.42μs 3.49ns 13.5ns 0.322 0 0 2.04 KB
#6442 EnrichedLog net6.0 2.77μs 1.69ns 6.55ns 0.0222 0 0 1.6 KB
#6442 EnrichedLog netcoreapp3.1 3.87μs 1.69ns 6.55ns 0.0211 0 0 1.65 KB
#6442 EnrichedLog net472 4.49μs 2.48ns 9.6ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6442

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.121 849.04 951.83

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 402ns 0.238ns 0.921ns 0.00805 0 0 576 B
master StartFinishSpan netcoreapp3.1 616ns 0.76ns 2.95ns 0.00768 0 0 576 B
master StartFinishSpan net472 631ns 0.366ns 1.42ns 0.0916 0 0 578 B
master StartFinishScope net6.0 556ns 0.355ns 1.38ns 0.00982 0 0 696 B
master StartFinishScope netcoreapp3.1 733ns 0.697ns 2.7ns 0.00919 0 0 696 B
master StartFinishScope net472 849ns 0.866ns 3.35ns 0.104 0 0 658 B
#6442 StartFinishSpan net6.0 402ns 0.283ns 1.02ns 0.00806 0 0 576 B
#6442 StartFinishSpan netcoreapp3.1 586ns 0.818ns 3.06ns 0.00775 0 0 576 B
#6442 StartFinishSpan net472 702ns 0.487ns 1.89ns 0.0916 0 0 578 B
#6442 StartFinishScope net6.0 540ns 0.36ns 1.39ns 0.00972 0 0 696 B
#6442 StartFinishScope netcoreapp3.1 759ns 1.88ns 7.3ns 0.00944 0 0 696 B
#6442 StartFinishScope net472 951ns 0.648ns 2.51ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6442

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.138 591.12 672.97

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 591ns 0.394ns 1.47ns 0.00976 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 885ns 0.35ns 1.31ns 0.00973 0 0 696 B
master RunOnMethodBegin net472 1.16μs 1.04ns 4.04ns 0.104 0 0 658 B
#6442 RunOnMethodBegin net6.0 674ns 0.574ns 2.22ns 0.00968 0 0 696 B
#6442 RunOnMethodBegin netcoreapp3.1 904ns 0.719ns 2.79ns 0.00906 0 0 696 B
#6442 RunOnMethodBegin net472 1.22μs 0.967ns 3.75ns 0.104 0 0 658 B

@e-n-0 e-n-0 merged commit cb2f8f1 into master Dec 16, 2024
101 of 105 checks passed
@e-n-0 e-n-0 deleted the flavien/db-fix-tests branch December 16, 2024 16:36
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 16, 2024
veerbia pushed a commit that referenced this pull request Dec 16, 2024
@e-n-0 @veerbia
[ASM] Fix database tests (netcoreapp3.0) (#6442)
1e48f32 
## Summary of changes

The databases `System.Data.SQLite` and `Microsoft.Data.Sqlite` were
swapped out in the tests.

## Reason for change

Tests were failling on master with `netcoreapp3.0`:
There was a specific check to skip the test with Microsoft.Data.Sqlite
on Alpine for `netcoreapp3.0`, this was failing on master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertpi robertpi robertpi approved these changes

Assignees
No one assigned
Labels
area:asm area:tests unit tests, integration tests
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@e-n-0 @andrewlock @robertpi