Revert "[Crashtracking] Disable crashtracking on Windows by default" #6220

kevingosse · 2024-10-30T12:04:35Z

Reverts #6152

Now that PDB support is implemented, we can reactivate crashtracking by default on Windows.

…6152)" This reverts commit e94a4c3.

datadog-ddstaging · 2024-10-30T12:22:19Z

Datadog Report

Branch report: revert-6152-kevin/disable_ct_windows
Commit report: c61e12a
Test service: dd-trace-dotnet

✅ 0 Failed, 366162 Passed, 2393 Skipped, 16h 19m 4.59s Total Time

andrewlock · 2024-10-30T12:46:39Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6220) - mean (70ms)  : 68, 73
     .   : milestone, 70,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6220) - mean (1,117ms)  : 1097, 1137
     .   : milestone, 1117,
    master - mean (1,119ms)  : 1098, 1140
     .   : milestone, 1119,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6220) - mean (110ms)  : 107, 114
     .   : milestone, 110,
    master - mean (109ms)  : 107, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6220) - mean (777ms)  : 755, 799
     .   : milestone, 777,
    master - mean (773ms)  : 753, 794
     .   : milestone, 773,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6220) - mean (93ms)  : 89, 97
     .   : milestone, 93,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6220) - mean (733ms)  : 711, 755
     .   : milestone, 733,
    master - mean (733ms)  : 714, 752
     .   : milestone, 733,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6220) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6220) - mean (1,202ms)  : 1181, 1223
     .   : milestone, 1202,
    master - mean (1,200ms)  : 1167, 1233
     .   : milestone, 1200,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6220) - mean (276ms)  : 270, 281
     .   : milestone, 276,
    master - mean (278ms)  : 271, 284
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6220) - mean (944ms)  : 926, 962
     .   : milestone, 944,
    master - mean (945ms)  : 923, 967
     .   : milestone, 945,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6220) - mean (265ms)  : 260, 270
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6220) - mean (926ms)  : 910, 943
     .   : milestone, 926,
    master - mean (929ms)  : 911, 948
     .   : milestone, 929,

andrewlock · 2024-10-30T13:48:59Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6220) (11.065M)   : 0, 11064950
    master (10.970M)   : 0, 10969978
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6220) (7.412M)   : 0, 7411782
    master (7.292M)   : 0, 7292209
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.582M)   : 0, 7581616

    section Manual
    master (10.995M)   : 0, 10995398

    section Manual + Automatic
    This PR (6220) (6.975M)   : 0, 6975082
    master (6.739M)   : 0, 6738798

    section DD_TRACE_ENABLED=0
    master (10.175M)   : 0, 10175402

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6220) (9.737M)   : 0, 9736797
    master (9.569M)   : 0, 9568691
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6220) (6.697M)   : 0, 6696989
    master (6.420M)   : 0, 6420401

    section Trace stats
    master (6.834M)   : 0, 6833970

    section Manual
    master (9.445M)   : 0, 9445274

    section Manual + Automatic
    This PR (6220) (6.119M)   : 0, 6118848
    master (6.093M)   : 0, 6093411

    section DD_TRACE_ENABLED=0
    master (9.051M)   : 0, 9051079

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6220) (9.931M)   : 0, 9930792
    master (9.836M)   : 0, 9836175
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6220) (6.398M)   : 0, 6398329
    master (6.529M)   : 0, 6529158
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.181M)   : 0, 7181034

    section Manual
    master (9.635M)   : 0, 9634854

    section Manual + Automatic
    This PR (6220) (6.001M)   : 0, 6001214
    master (5.980M)   : 0, 5980484

    section DD_TRACE_ENABLED=0
    master (9.130M)   : 0, 9130402

andrewlock · 2024-10-30T18:55:35Z

Benchmarks Report for tracer 🐌

Benchmarks for #6220 compared to master:

2 benchmarks are faster, with geometric mean 1.143
1 benchmarks are slower, with geometric mean 1.155
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.7μs	42.8ns	267ns	0.0162	0.00406	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.92μs	53.5ns	288ns	0.0189	0.00943	0	5.61 KB
master	`StartStopWithChild`	net472	16μs	66.6ns	258ns	1.04	0.33	0.0967	6.06 KB
#6220	`StartStopWithChild`	net6.0	7.8μs	42.9ns	275ns	0.0153	0.00766	0	5.43 KB
#6220	`StartStopWithChild`	netcoreapp3.1	9.73μs	48.8ns	234ns	0.0206	0.0103	0	5.61 KB
#6220	`StartStopWithChild`	net472	16.2μs	69.8ns	270ns	1.04	0.331	0.0968	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	482μs	278ns	1.04μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	637μs	383ns	1.48μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	839μs	253ns	911ns	0.419	3.3 KB
#6220	`WriteAndFlushEnrichedTraces`	net6.0	465μs	262ns	981ns	0	2.7 KB
#6220	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	655μs	240ns	897ns	0	2.7 KB
#6220	`WriteAndFlushEnrichedTraces`	net472	839μs	471ns	1.83μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	200μs	1.15μs	9.6μs	0.19	18.45 KB
master	`SendRequest`	netcoreapp3.1	225μs	1.31μs	11.6μs	0.207	20.61 KB
master	`SendRequest`	net472	0.00136ns	0.000644ns	0.00241ns	0	0 b
#6220	`SendRequest`	net6.0	202μs	1.3μs	13μs	0.195	18.45 KB
#6220	`SendRequest`	netcoreapp3.1	219μs	1.28μs	12.1μs	0.217	20.61 KB
#6220	`SendRequest`	net472	0ns	0ns	0ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6220

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.64 KB	41.93 KB	289 B	0.69%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	558μs	2.95μs	14.7μs	0.556	0	0	41.45 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	3.57μs	18.2μs	0.329	0	0	41.64 KB
master	`WriteAndFlushEnrichedTraces`	net472	868μs	2.52μs	9.42μs	8.3	2.62	0.437	53.34 KB
#6220	`WriteAndFlushEnrichedTraces`	net6.0	554μs	2.42μs	9.36μs	0.568	0	0	41.66 KB
#6220	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	687μs	3.75μs	21.2μs	0.372	0	0	41.93 KB
#6220	`WriteAndFlushEnrichedTraces`	net472	885μs	4.4μs	19.2μs	8.25	2.6	0.434	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.33μs	1.23ns	4.76ns	0.0145	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.82μs	1.45ns	5.6ns	0.0137	1.02 KB
master	`ExecuteNonQuery`	net472	2.08μs	2.74ns	10.6ns	0.157	987 B
#6220	`ExecuteNonQuery`	net6.0	1.22μs	0.914ns	3.54ns	0.0141	1.02 KB
#6220	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	2.21ns	8.56ns	0.0134	1.02 KB
#6220	`ExecuteNonQuery`	net472	2.06μs	2.36ns	8.83ns	0.157	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	0.585ns	2.19ns	0.014	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.82ns	3.07ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.53μs	2.45ns	9.49ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.23μs	0.381ns	1.43ns	0.0135	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.686ns	2.66ns	0.0139	1.02 KB
master	`CallElasticsearchAsync`	net472	2.59μs	2ns	7.74ns	0.167	1.05 KB
#6220	`CallElasticsearch`	net6.0	1.23μs	0.616ns	2.39ns	0.0136	976 B
#6220	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.629ns	2.44ns	0.0134	976 B
#6220	`CallElasticsearch`	net472	2.47μs	2.2ns	8.23ns	0.157	995 B
#6220	`CallElasticsearchAsync`	net6.0	1.23μs	0.558ns	2.09ns	0.0136	952 B
#6220	`CallElasticsearchAsync`	netcoreapp3.1	1.54μs	0.75ns	2.8ns	0.0139	1.02 KB
#6220	`CallElasticsearchAsync`	net472	2.63μs	1.75ns	6.78ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.33μs	0.646ns	2.42ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.71μs	0.61ns	2.28ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.77μs	1.19ns	4.6ns	0.145	915 B
#6220	`ExecuteAsync`	net6.0	1.29μs	0.492ns	1.77ns	0.013	952 B
#6220	`ExecuteAsync`	netcoreapp3.1	1.65μs	1.43ns	5.53ns	0.0131	952 B
#6220	`ExecuteAsync`	net472	1.8μs	0.719ns	2.79ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.13μs	1.38ns	5.15ns	0.031	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.08μs	1.79ns	6.93ns	0.0382	2.76 KB
master	`SendAsync`	net472	7.83μs	3.37ns	12.6ns	0.497	3.15 KB
#6220	`SendAsync`	net6.0	4.29μs	1.67ns	6.46ns	0.0301	2.22 KB
#6220	`SendAsync`	netcoreapp3.1	5.23μs	3.73ns	14ns	0.0365	2.76 KB
#6220	`SendAsync`	net472	7.76μs	2.71ns	10.5ns	0.496	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6220

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0	1.155	1,453.98	1,679.97

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.45μs	0.988ns	3.7ns	0.0233	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.21μs	1.44ns	5.39ns	0.0227	1.64 KB
master	`EnrichedLog`	net472	2.5μs	1.24ns	4.79ns	0.249	1.57 KB
#6220	`EnrichedLog`	net6.0	1.68μs	0.639ns	2.39ns	0.0234	1.64 KB
#6220	`EnrichedLog`	netcoreapp3.1	2.32μs	1.63ns	6.3ns	0.0222	1.64 KB
#6220	`EnrichedLog`	net472	2.6μs	0.98ns	3.67ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	117μs	162ns	628ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	169ns	655ns	0.0622	0	4.28 KB
master	`EnrichedLog`	net472	152μs	241ns	932ns	0.684	0.228	4.46 KB
#6220	`EnrichedLog`	net6.0	118μs	164ns	633ns	0.059	0	4.28 KB
#6220	`EnrichedLog`	netcoreapp3.1	121μs	139ns	521ns	0.0601	0	4.28 KB
#6220	`EnrichedLog`	net472	152μs	135ns	521ns	0.684	0.228	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.18ns	4.57ns	0.0305	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.15μs	1.99ns	7.7ns	0.0292	2.2 KB
master	`EnrichedLog`	net472	4.78μs	1.12ns	3.88ns	0.32	2.02 KB
#6220	`EnrichedLog`	net6.0	3.18μs	1.14ns	4.42ns	0.0306	2.2 KB
#6220	`EnrichedLog`	netcoreapp3.1	4.23μs	1.92ns	7.42ns	0.0296	2.2 KB
#6220	`EnrichedLog`	net472	4.98μs	1.61ns	6.02ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.3μs	0.596ns	2.31ns	0.016	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	0.518ns	2.01ns	0.0151	0	1.14 KB
master	`SendReceive`	net472	2.16μs	1.02ns	3.95ns	0.183	0	1.16 KB
#6220	`SendReceive`	net6.0	1.26μs	0.897ns	3.47ns	0.0158	0	1.14 KB
#6220	`SendReceive`	netcoreapp3.1	1.84μs	1.23ns	4.77ns	0.0156	0	1.14 KB
#6220	`SendReceive`	net472	2.06μs	0.894ns	3.22ns	0.183	0.00103	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.82μs	1.1ns	4.28ns	0.0226	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.78μs	1.74ns	6.52ns	0.0209	1.65 KB
master	`EnrichedLog`	net472	4.39μs	1.86ns	6.71ns	0.324	2.04 KB
#6220	`EnrichedLog`	net6.0	2.81μs	0.783ns	3.03ns	0.0226	1.6 KB
#6220	`EnrichedLog`	netcoreapp3.1	3.89μs	0.851ns	3.07ns	0.0214	1.65 KB
#6220	`EnrichedLog`	net472	4.24μs	2.01ns	7.77ns	0.324	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6220

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.153	471.32	408.95

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	471ns	0.337ns	1.26ns	0.0081	576 B
master	`StartFinishSpan`	netcoreapp3.1	544ns	0.28ns	1.01ns	0.00786	576 B
master	`StartFinishSpan`	net472	662ns	0.729ns	2.82ns	0.0915	578 B
master	`StartFinishScope`	net6.0	500ns	0.388ns	1.5ns	0.0097	696 B
master	`StartFinishScope`	netcoreapp3.1	796ns	3.86ns	15.9ns	0.0095	696 B
master	`StartFinishScope`	net472	909ns	0.415ns	1.55ns	0.104	658 B
#6220	`StartFinishSpan`	net6.0	409ns	0.265ns	1.03ns	0.008	576 B
#6220	`StartFinishSpan`	netcoreapp3.1	554ns	0.435ns	1.69ns	0.00795	576 B
#6220	`StartFinishSpan`	net472	684ns	0.85ns	3.29ns	0.0915	578 B
#6220	`StartFinishScope`	net6.0	522ns	0.699ns	2.62ns	0.0098	696 B
#6220	`StartFinishScope`	netcoreapp3.1	761ns	0.993ns	3.85ns	0.00917	696 B
#6220	`StartFinishScope`	net472	903ns	0.805ns	3.12ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6220

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1	1.134	954.22	841.16

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	669ns	0.569ns	2.2ns	0.00972	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	954ns	0.395ns	1.53ns	0.00913	696 B
master	`RunOnMethodBegin`	net472	1.17μs	0.489ns	1.89ns	0.104	658 B
#6220	`RunOnMethodBegin`	net6.0	641ns	0.563ns	2.1ns	0.00973	696 B
#6220	`RunOnMethodBegin`	netcoreapp3.1	841ns	0.431ns	1.61ns	0.00914	696 B
#6220	`RunOnMethodBegin`	net472	1.1μs	0.598ns	2.32ns	0.104	658 B

Revert "[Crashtracking] Disable crashtracking on Windows by default (#…

c61e12a

…6152)" This reverts commit e94a4c3.

kevingosse added the area:crashtracking label Oct 30, 2024

kevingosse requested review from a team as code owners October 30, 2024 12:04

andrewlock approved these changes Oct 30, 2024

View reviewed changes

kevingosse merged commit 42e161a into master Oct 31, 2024
85 checks passed

kevingosse deleted the revert-6152-kevin/disable_ct_windows branch October 31, 2024 09:50

github-actions bot added this to the vNext-v3 milestone Oct 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "[Crashtracking] Disable crashtracking on Windows by default" #6220

Revert "[Crashtracking] Disable crashtracking on Windows by default" #6220

kevingosse commented Oct 30, 2024

datadog-ddstaging bot commented Oct 30, 2024 •

edited

Loading

andrewlock commented Oct 30, 2024

andrewlock commented Oct 30, 2024

andrewlock commented Oct 30, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #6220

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6220

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6220

Raw results

Faster 🎉 in #6220

Raw results

Revert "[Crashtracking] Disable crashtracking on Windows by default" #6220

Revert "[Crashtracking] Disable crashtracking on Windows by default" #6220

Conversation

kevingosse commented Oct 30, 2024

datadog-ddstaging bot commented Oct 30, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 30, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 30, 2024

Throughput/Crank Report ⚡

andrewlock commented Oct 30, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6220

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6220

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6220

Raw results

Faster 🎉 in #6220

Raw results

datadog-ddstaging bot commented Oct 30, 2024 •

edited

Loading