Prevent an unhandled SecurityException in DatadogLogging #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gLogging to the constructor to catch possible SecurityExceptions.
…n DatadogLogging to the constructor to catch possible SecurityExceptions." This reverts commit 0b2cbe4.
lucaspimentel
added
the
area:tracer
|
I know this isn't part of the code you modified, but would you mind moving the constants (They should probably use |
…riable in DatadogLogging to the constructor to catch possible SecurityExceptions."" This reverts commit 9bc3728.
lucaspimentel
approved these changes
Jan 23, 2020
zacharycmontoya
deleted the
zach/bug-fix/logging-fileio-securityexception
branch
MikeGoldsmith
pushed a commit
to lightstep/ls-trace-dotnet
that referenced
this pull request
Mar 20, 2020
Move initialization of the WindowsDefaultDirectory variable in DatadogLogging to the constructor to catch possible SecurityExceptions. Also, add DD_MAX_LOGFILE_SIZE and DD_TRACE_LOG_PATH as ConfigurationKeys constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move initialization of the WindowsDefaultDirectory field in DatadogLogging to the constructor to catch possible SecurityExceptions.
@DataDog/apm-dotnet