Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Package Versions Bump] Updating package versions #6123

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[Test Package Versions Bump] Updating package versions #6123

merged 1 commit into from
Oct 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 6, 2024

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners October 6, 2024 00:22
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6123) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (70ms)  : 67, 74
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6123) - mean (1,109ms)  : 1088, 1130
     .   : milestone, 1109,
    master - mean (1,110ms)  : 1088, 1133
     .   : milestone, 1110,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6123) - mean (110ms)  : 105, 116
     .   : milestone, 110,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6123) - mean (775ms)  : 757, 793
     .   : milestone, 775,
    master - mean (773ms)  : 760, 785
     .   : milestone, 773,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6123) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 90, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6123) - mean (731ms)  : 711, 752
     .   : milestone, 731,
    master - mean (728ms)  : 712, 743
     .   : milestone, 728,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6123) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (196ms)  : 193, 199
     .   : milestone, 196,

    section CallTarget+Inlining+NGEN
    This PR (6123) - mean (1,196ms)  : 1175, 1217
     .   : milestone, 1196,
    master - mean (1,221ms)  : 1200, 1242
     .   : milestone, 1221,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6123) - mean (275ms)  : 270, 279
     .   : milestone, 275,
    master - mean (283ms)  : 279, 287
     .   : milestone, 283,

    section CallTarget+Inlining+NGEN
    This PR (6123) - mean (936ms)  : 921, 951
     .   : milestone, 936,
    master - mean (958ms)  : 941, 976
     .   : milestone, 958,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6123) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (272ms)  : 267, 277
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (6123) - mean (924ms)  : 905, 944
     .   : milestone, 924,
    master - mean (945ms)  : 924, 966
     .   : milestone, 945,
Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 6, 2024 •
edited
Loading

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 3d13e4d
Test service: dd-trace-dotnet

✅ 0 Failed, 364784 Passed, 2074 Skipped, 15h 44m 7.38s Total Time
⌛ 2 Performance Regressions

⌛ Performance Regressions vs Default Branch (2)

  • WriteAndFlushEnrichedTraces - Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark 656.25µs (+89.07µs, +16%) - Details
  • WriteAndFlushEnrichedTraces - Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark 779.07µs (+97.2µs, +14%) - Details

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6123) (10.675M)   : 0, 10674500
    master (11.064M)   : 0, 11064046
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6123) (7.097M)   : 0, 7097042
    master (7.259M)   : 0, 7258625
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.713M)   : 0, 7712937

    section Manual
    master (11.009M)   : 0, 11009117

    section Manual + Automatic
    This PR (6123) (6.589M)   : 0, 6589333
    master (6.750M)   : 0, 6749665

    section DD_TRACE_ENABLED=0
    master (10.101M)   : 0, 10100673
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6123) (9.210M)   : 0, 9209903
    master (9.593M)   : 0, 9592702
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6123) (6.635M)   : 0, 6634852
    master (6.636M)   : 0, 6635556

    section Trace stats
    master (6.829M)   : 0, 6828762

    section Manual
    master (9.514M)   : 0, 9514338

    section Manual + Automatic
    This PR (6123) (6.116M)   : 0, 6116327
    master (6.179M)   : 0, 6179419

    section DD_TRACE_ENABLED=0
    master (9.026M)   : 0, 9025973
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6123) (9.920M)   : 0, 9919786
    master (10.092M)   : 0, 10092078
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6123) (6.583M)   : 0, 6582820
    master (6.624M)   : 0, 6623918
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.353M)   : 0, 7352916

    section Manual
    master (9.633M)   : 0, 9632891

    section Manual + Automatic
    This PR (6123) (6.000M)   : 0, 6000360
    master (6.083M)   : 0, 6083001

    section DD_TRACE_ENABLED=0
    master (9.240M)   : 0, 9240149
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6123 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.155
  • 3 benchmarks are slower, with geometric mean 1.165
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.64μs 43ns 282ns 0.0147 0.00733 0 5.42 KB
master StartStopWithChild netcoreapp3.1 10μs 56.1ns 381ns 0.0204 0.0102 0 5.62 KB
master StartStopWithChild net472 15.9μs 51.4ns 199ns 1.03 0.308 0.103 6.07 KB
#6123 StartStopWithChild net6.0 8.01μs 43.9ns 319ns 0.0155 0.00774 0 5.43 KB
#6123 StartStopWithChild netcoreapp3.1 10μs 52.4ns 282ns 0.0147 0.00977 0 5.62 KB
#6123 StartStopWithChild net472 16.1μs 34.7ns 135ns 1.02 0.306 0.0966 6.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 467μs 223ns 865ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 307ns 1.15μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 837μs 422ns 1.64μs 0.419 0 0 3.3 KB
#6123 WriteAndFlushEnrichedTraces net6.0 475μs 185ns 718ns 0 0 0 2.7 KB
#6123 WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 345ns 1.34μs 0 0 0 2.7 KB
#6123 WriteAndFlushEnrichedTraces net472 847μs 531ns 1.99μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 196μs 1.12μs 9.14μs 0.21 0 0 18.45 KB
master SendRequest netcoreapp3.1 217μs 1.26μs 10.6μs 0.2 0 0 20.61 KB
master SendRequest net472 0.00173ns 0.000528ns 0.0019ns 0 0 0 0 b
#6123 SendRequest net6.0 187μs 906ns 4.71μs 0.188 0 0 18.45 KB
#6123 SendRequest netcoreapp3.1 216μs 1.2μs 8.16μs 0.223 0 0 20.61 KB
#6123 SendRequest net472 0.00161ns 0.000639ns 0.00248ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6123

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.189 545,909.95 648,872.10
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.142 680,552.14 777,401.39

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 548μs 1.79μs 6.92μs 0.561 0 0 41.42 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 682μs 3.19μs 12.3μs 0.34 0 0 41.83 KB
master WriteAndFlushEnrichedTraces net472 859μs 3.67μs 14.2μs 8.19 2.59 0.431 53.31 KB
#6123 WriteAndFlushEnrichedTraces net6.0 656μs 4.33μs 42.4μs 0.587 0 0 41.54 KB
#6123 WriteAndFlushEnrichedTraces netcoreapp3.1 779μs 5.34μs 53.4μs 0.365 0 0 41.69 KB
#6123 WriteAndFlushEnrichedTraces net472 884μs 4.6μs 23.9μs 8.04 2.23 0.446 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.22μs 1.02ns 3.93ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.74μs 1.15ns 4.3ns 0.0131 0 0 1.02 KB
master ExecuteNonQuery net472 2.15μs 3.25ns 12.6ns 0.156 0 0 987 B
#6123 ExecuteNonQuery net6.0 1.36μs 1.9ns 7.36ns 0.0142 0 0 1.02 KB
#6123 ExecuteNonQuery netcoreapp3.1 1.77μs 2.61ns 10.1ns 0.0133 0 0 1.02 KB
#6123 ExecuteNonQuery net472 2.23μs 12.4ns 83.1ns 0.156 0.00108 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.23μs 0.657ns 2.46ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.56μs 1.36ns 5.27ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.47μs 0.993ns 3.84ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.2μs 0.957ns 3.7ns 0.0132 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.57μs 0.588ns 2.12ns 0.0137 0 0 1.02 KB
master CallElasticsearchAsync net472 2.58μs 1.51ns 5.85ns 0.166 0 0 1.05 KB
#6123 CallElasticsearch net6.0 1.24μs 0.42ns 1.51ns 0.0137 0 0 976 B
#6123 CallElasticsearch netcoreapp3.1 1.52μs 1.6ns 5.99ns 0.013 0 0 976 B
#6123 CallElasticsearch net472 2.47μs 1.1ns 4.25ns 0.157 0 0 995 B
#6123 CallElasticsearchAsync net6.0 1.26μs 0.624ns 2.42ns 0.0132 0 0 952 B
#6123 CallElasticsearchAsync netcoreapp3.1 1.73μs 1.27ns 4.76ns 0.0138 0 0 1.02 KB
#6123 CallElasticsearchAsync net472 2.57μs 2.32ns 8.99ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.22μs 0.703ns 2.63ns 0.0135 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.67μs 0.534ns 2ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.75μs 0.508ns 1.97ns 0.145 0 0 915 B
#6123 ExecuteAsync net6.0 1.28μs 0.588ns 2.28ns 0.0134 0 0 952 B
#6123 ExecuteAsync netcoreapp3.1 1.6μs 1.19ns 4.62ns 0.0128 0 0 952 B
#6123 ExecuteAsync net472 1.69μs 1.07ns 4.14ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.32μs 1.5ns 5.42ns 0.0301 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.16μs 1.48ns 5.72ns 0.0363 0 0 2.76 KB
master SendAsync net472 7.65μs 1.16ns 4.2ns 0.496 0 0 3.15 KB
#6123 SendAsync net6.0 4.2μs 3.5ns 13.1ns 0.0316 0 0 2.22 KB
#6123 SendAsync netcoreapp3.1 5.13μs 3.08ns 11.5ns 0.0361 0 0 2.76 KB
#6123 SendAsync net472 7.81μs 3.81ns 14.8ns 0.498 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 1.16ns 4.32ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.19μs 1.61ns 5.81ns 0.0219 0 0 1.64 KB
master EnrichedLog net472 2.57μs 0.868ns 3.36ns 0.249 0 0 1.57 KB
#6123 EnrichedLog net6.0 1.62μs 0.533ns 1.99ns 0.0226 0 0 1.64 KB
#6123 EnrichedLog netcoreapp3.1 2.21μs 0.707ns 2.74ns 0.0222 0 0 1.64 KB
#6123 EnrichedLog net472 2.53μs 0.832ns 3.11ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 127ns 490ns 0.0562 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 198ns 767ns 0.0598 0 0 4.28 KB
master EnrichedLog net472 147μs 212ns 819ns 0.659 0.22 0 4.46 KB
#6123 EnrichedLog net6.0 113μs 121ns 469ns 0 0 0 4.28 KB
#6123 EnrichedLog netcoreapp3.1 118μs 182ns 706ns 0 0 0 4.28 KB
#6123 EnrichedLog net472 147μs 176ns 682ns 0.66 0.22 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.98μs 0.88ns 3.41ns 0.0299 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.26μs 1.73ns 6.46ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 5.01μs 0.957ns 3.71ns 0.32 0 0 2.02 KB
#6123 EnrichedLog net6.0 2.87μs 1.29ns 4.99ns 0.0317 0 0 2.2 KB
#6123 EnrichedLog netcoreapp3.1 4.06μs 1.52ns 5.88ns 0.0302 0 0 2.2 KB
#6123 EnrichedLog net472 4.68μs 2.49ns 9.65ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 0.886ns 3.32ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.7μs 1.07ns 4.14ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.05μs 1.16ns 4.49ns 0.183 0.00103 0 1.16 KB
#6123 SendReceive net6.0 1.4μs 0.373ns 1.4ns 0.0161 0 0 1.14 KB
#6123 SendReceive netcoreapp3.1 1.75μs 1.47ns 5.7ns 0.0156 0 0 1.14 KB
#6123 SendReceive net472 2.1μs 0.625ns 2.34ns 0.183 0.00105 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 1.18ns 4.59ns 0.0227 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4.01μs 1.9ns 7.36ns 0.0221 0 0 1.65 KB
master EnrichedLog net472 4.31μs 1.18ns 4.27ns 0.322 0 0 2.04 KB
#6123 EnrichedLog net6.0 2.75μs 1.02ns 3.96ns 0.0219 0 0 1.6 KB
#6123 EnrichedLog netcoreapp3.1 3.84μs 1.29ns 5ns 0.0212 0 0 1.65 KB
#6123 EnrichedLog net472 4.42μs 1.27ns 4.9ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6123

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.165 472.34 550.34

Faster 🎉 in #6123

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.155 845.97 732.32

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 401ns 0.199ns 0.77ns 0.00807 0 0 576 B
master StartFinishSpan netcoreapp3.1 617ns 0.552ns 2.14ns 0.0078 0 0 576 B
master StartFinishSpan net472 721ns 0.561ns 2.17ns 0.0917 0 0 578 B
master StartFinishScope net6.0 473ns 0.252ns 0.975ns 0.00975 0 0 696 B
master StartFinishScope netcoreapp3.1 847ns 0.883ns 3.42ns 0.00948 0 0 696 B
master StartFinishScope net472 854ns 0.984ns 3.81ns 0.104 0 0 658 B
#6123 StartFinishSpan net6.0 402ns 0.165ns 0.639ns 0.00806 0 0 576 B
#6123 StartFinishSpan netcoreapp3.1 643ns 0.411ns 1.59ns 0.00776 0 0 576 B
#6123 StartFinishSpan net472 702ns 0.5ns 1.94ns 0.0917 0 0 578 B
#6123 StartFinishScope net6.0 550ns 0.251ns 0.974ns 0.00972 0 0 696 B
#6123 StartFinishScope netcoreapp3.1 732ns 0.863ns 3.34ns 0.00946 0 0 696 B
#6123 StartFinishScope net472 832ns 0.408ns 1.53ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 649ns 0.309ns 1.2ns 0.00977 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 983ns 0.447ns 1.73ns 0.00911 0 0 696 B
master RunOnMethodBegin net472 1.1μs 0.702ns 2.72ns 0.104 0 0 658 B
#6123 RunOnMethodBegin net6.0 608ns 0.172ns 0.643ns 0.00978 0 0 696 B
#6123 RunOnMethodBegin netcoreapp3.1 942ns 0.408ns 1.53ns 0.00939 0 0 696 B
#6123 RunOnMethodBegin net472 1.12μs 0.575ns 2.23ns 0.104 0 0 658 B

andrewlock
andrewlock approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bouwkast bouwkast merged commit 0c543e3 into master Oct 7, 2024
60 of 63 checks passed
@bouwkast bouwkast deleted the bot/test-package-versions-bump branch October 7, 2024 14:42
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 7, 2024
@andrewlock andrewlock added dependencies Pull requests that update a dependency file area:dependabot dependabot updates area:tests unit tests, integration tests area:test-apps apps used to test integrations and removed dependencies Pull requests that update a dependency file labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouwkast bouwkast bouwkast approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:dependabot dependabot updates area:test-apps apps used to test integrations area:tests unit tests, integration tests
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlock @bouwkast