Add more info when GenerateDumpIfDbgRequested fails #6113

kevingosse · 2024-10-03T13:22:17Z

Summary of changes

Moar info

Reason for change

Need moar info

Implementation details

Add moar info

datadog-ddstaging · 2024-10-03T13:45:42Z

Datadog Report

Branch report: kevin/createdump_hang
Commit report: 4a4c2e4
Test service: dd-trace-dotnet

✅ 0 Failed, 363022 Passed, 2352 Skipped, 19h 26m 4.47s Total Time

andrewlock · 2024-10-03T13:54:20Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6113) - mean (71ms)  : 69, 73
     .   : milestone, 71,
    master - mean (70ms)  : 68, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6113) - mean (1,120ms)  : 1067, 1174
     .   : milestone, 1120,
    master - mean (1,110ms)  : 1093, 1128
     .   : milestone, 1110,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6113) - mean (109ms)  : 107, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6113) - mean (791ms)  : 745, 836
     .   : milestone, 791,
    master - mean (772ms)  : 758, 787
     .   : milestone, 772,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6113) - mean (94ms)  : 91, 96
     .   : milestone, 94,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6113) - mean (748ms)  : 672, 824
     .   : milestone, 748,
    master - mean (729ms)  : 713, 745
     .   : milestone, 729,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6113) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6113) - mean (1,209ms)  : 1178, 1239
     .   : milestone, 1209,
    master - mean (1,194ms)  : 1172, 1216
     .   : milestone, 1194,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6113) - mean (278ms)  : 273, 283
     .   : milestone, 278,
    master - mean (275ms)  : 272, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6113) - mean (953ms)  : 927, 979
     .   : milestone, 953,
    master - mean (937ms)  : 921, 954
     .   : milestone, 937,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6113) - mean (267ms)  : 262, 273
     .   : milestone, 267,
    master - mean (264ms)  : 260, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6113) - mean (936ms)  : 914, 957
     .   : milestone, 936,
    master - mean (924ms)  : 905, 942
     .   : milestone, 924,

andrewlock · 2024-10-03T14:49:37Z

Benchmarks Report for tracer 🐌

Benchmarks for #6113 compared to master:

2 benchmarks are slower, with geometric mean 1.226
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.69μs	43.6ns	299ns	0.0189	0.0114	0.00379	5.42 KB
master	`StartStopWithChild`	netcoreapp3.1	9.75μs	42.2ns	158ns	0.0141	0.00471	0	5.62 KB
master	`StartStopWithChild`	net472	16.1μs	47.8ns	185ns	1.03	0.33	0.105	6.07 KB
#6113	`StartStopWithChild`	net6.0	7.9μs	44.4ns	301ns	0.0158	0.00792	0	5.43 KB
#6113	`StartStopWithChild`	netcoreapp3.1	9.89μs	49.9ns	229ns	0.0142	0.00473	0	5.62 KB
#6113	`StartStopWithChild`	net472	16.1μs	37.5ns	140ns	1.03	0.319	0.0957	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	471μs	284ns	1.02μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	206ns	799ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	836μs	326ns	1.26μs	0.414	3.3 KB
#6113	`WriteAndFlushEnrichedTraces`	net6.0	480μs	247ns	955ns	0	2.7 KB
#6113	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	235ns	880ns	0	2.7 KB
#6113	`WriteAndFlushEnrichedTraces`	net472	827μs	409ns	1.53μs	0.411	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	193μs	1.1μs	8.22μs	0.195	18.45 KB
master	`SendRequest`	netcoreapp3.1	220μs	1.23μs	8.37μs	0.211	20.61 KB
master	`SendRequest`	net472	0.00145ns	0.000664ns	0.00257ns	0	0 b
#6113	`SendRequest`	net6.0	189μs	1.04μs	5.87μs	0.181	18.45 KB
#6113	`SendRequest`	netcoreapp3.1	219μs	1.24μs	8.5μs	0.205	20.61 KB
#6113	`SendRequest`	net472	0.00188ns	0.000805ns	0.00301ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6113

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.92 KB	41.58 KB	-345 B	-0.82%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	550μs	2.41μs	10.8μs	0.568	0	0	41.46 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	691μs	2.52μs	9.1μs	0.343	0	0	41.92 KB
master	`WriteAndFlushEnrichedTraces`	net472	847μs	3.52μs	13.6μs	8.39	2.52	0.419	53.26 KB
#6113	`WriteAndFlushEnrichedTraces`	net6.0	547μs	2.17μs	8.41μs	0.576	0	0	41.49 KB
#6113	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	660μs	2.37μs	9.17μs	0.324	0	0	41.58 KB
#6113	`WriteAndFlushEnrichedTraces`	net472	878μs	4.48μs	20μs	8.19	2.59	0.431	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.35μs	0.925ns	3.46ns	0.0142	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	0.934ns	3.62ns	0.0139	1.02 KB
master	`ExecuteNonQuery`	net472	2.08μs	2.37ns	8.85ns	0.156	987 B
#6113	`ExecuteNonQuery`	net6.0	1.31μs	1.11ns	4.3ns	0.0144	1.02 KB
#6113	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.62ns	6.27ns	0.0133	1.02 KB
#6113	`ExecuteNonQuery`	net472	2.13μs	1.7ns	6.37ns	0.157	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6113

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0	1.164	1,107.06	1,288.48

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.11μs	0.393ns	1.52ns	0.0134	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.49μs	0.871ns	3.02ns	0.0133	976 B
master	`CallElasticsearch`	net472	2.5μs	1.17ns	4.37ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.3μs	1.23ns	4.58ns	0.0136	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	0.781ns	2.81ns	0.0137	1.02 KB
master	`CallElasticsearchAsync`	net472	2.47μs	1.86ns	7.19ns	0.166	1.05 KB
#6113	`CallElasticsearch`	net6.0	1.29μs	0.873ns	3.38ns	0.0135	976 B
#6113	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.46ns	1.72ns	0.0132	976 B
#6113	`CallElasticsearch`	net472	2.51μs	1.71ns	6.61ns	0.158	995 B
#6113	`CallElasticsearchAsync`	net6.0	1.26μs	1.24ns	4.63ns	0.0133	952 B
#6113	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	0.852ns	3.3ns	0.0136	1.02 KB
#6113	`CallElasticsearchAsync`	net472	2.6μs	1.2ns	4.47ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.27μs	0.457ns	1.58ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.57μs	1.37ns	5.13ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.75μs	0.643ns	2.32ns	0.145	915 B
#6113	`ExecuteAsync`	net6.0	1.37μs	1.89ns	7.33ns	0.013	952 B
#6113	`ExecuteAsync`	netcoreapp3.1	1.63μs	1.66ns	6.2ns	0.0123	952 B
#6113	`ExecuteAsync`	net472	1.77μs	0.54ns	2.09ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.17μs	1.95ns	7.54ns	0.0316	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.07μs	3.05ns	11ns	0.0354	2.76 KB
master	`SendAsync`	net472	7.73μs	4.45ns	17.2ns	0.496	3.15 KB
#6113	`SendAsync`	net6.0	4.11μs	3.92ns	14.7ns	0.0308	2.22 KB
#6113	`SendAsync`	netcoreapp3.1	5.22μs	1.91ns	7.4ns	0.0364	2.76 KB
#6113	`SendAsync`	net472	7.77μs	1.46ns	5.47ns	0.498	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.47μs	2.54ns	8.8ns	0.0227	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.24μs	1.07ns	4.01ns	0.0223	1.64 KB
master	`EnrichedLog`	net472	2.47μs	1.03ns	4ns	0.249	1.57 KB
#6113	`EnrichedLog`	net6.0	1.61μs	0.766ns	2.97ns	0.0234	1.64 KB
#6113	`EnrichedLog`	netcoreapp3.1	2.32μs	1.38ns	5.34ns	0.022	1.64 KB
#6113	`EnrichedLog`	net472	2.54μs	1.12ns	4.35ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	58ns	209ns	0.0566	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	92.1ns	344ns	0	0	4.28 KB
master	`EnrichedLog`	net472	147μs	176ns	681ns	0.656	0.219	4.46 KB
#6113	`EnrichedLog`	net6.0	114μs	126ns	473ns	0.0565	0	4.28 KB
#6113	`EnrichedLog`	netcoreapp3.1	120μs	111ns	414ns	0	0	4.28 KB
#6113	`EnrichedLog`	net472	147μs	168ns	651ns	0.663	0.221	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3μs	1.18ns	4.58ns	0.0314	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.02μs	2.32ns	8.99ns	0.03	2.2 KB
master	`EnrichedLog`	net472	4.94μs	1.72ns	6.21ns	0.319	2.02 KB
#6113	`EnrichedLog`	net6.0	3.07μs	1.11ns	4.29ns	0.0307	2.2 KB
#6113	`EnrichedLog`	netcoreapp3.1	4.14μs	1.04ns	3.91ns	0.029	2.2 KB
#6113	`EnrichedLog`	net472	4.86μs	0.999ns	3.87ns	0.318	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.38μs	0.42ns	1.63ns	0.0159	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.87μs	0.808ns	3.13ns	0.015	0	1.14 KB
master	`SendReceive`	net472	2.02μs	0.984ns	3.81ns	0.184	0.00101	1.16 KB
#6113	`SendReceive`	net6.0	1.34μs	1.08ns	4.17ns	0.0161	0	1.14 KB
#6113	`SendReceive`	netcoreapp3.1	1.76μs	1.14ns	4.26ns	0.0151	0	1.14 KB
#6113	`SendReceive`	net472	2.12μs	2.37ns	9.18ns	0.183	0.00106	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.8μs	1.05ns	4.08ns	0.0224	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.84μs	3.8ns	14.7ns	0.023	1.65 KB
master	`EnrichedLog`	net472	4.41μs	2.16ns	8.35ns	0.323	2.04 KB
#6113	`EnrichedLog`	net6.0	2.7μs	0.925ns	3.58ns	0.0215	1.6 KB
#6113	`EnrichedLog`	netcoreapp3.1	3.88μs	1.23ns	4.61ns	0.0214	1.65 KB
#6113	`EnrichedLog`	net472	4.42μs	2.49ns	9.64ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	401ns	0.149ns	0.575ns	0.0081	576 B
master	`StartFinishSpan`	netcoreapp3.1	571ns	0.836ns	3.13ns	0.00794	576 B
master	`StartFinishSpan`	net472	602ns	1.05ns	4.07ns	0.0917	578 B
master	`StartFinishScope`	net6.0	507ns	0.301ns	1.17ns	0.00987	696 B
master	`StartFinishScope`	netcoreapp3.1	785ns	0.908ns	3.52ns	0.00933	696 B
master	`StartFinishScope`	net472	867ns	0.867ns	3.36ns	0.104	658 B
#6113	`StartFinishSpan`	net6.0	396ns	0.439ns	1.7ns	0.00815	576 B
#6113	`StartFinishSpan`	netcoreapp3.1	571ns	1.05ns	3.92ns	0.00777	576 B
#6113	`StartFinishSpan`	net472	669ns	0.739ns	2.86ns	0.0915	578 B
#6113	`StartFinishScope`	net6.0	557ns	0.513ns	1.99ns	0.0098	696 B
#6113	`StartFinishScope`	netcoreapp3.1	745ns	0.701ns	2.71ns	0.00943	696 B
#6113	`StartFinishScope`	net472	822ns	0.856ns	3.31ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6113

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.291	585.68	756.33

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	586ns	0.395ns	1.48ns	0.00985	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	882ns	0.575ns	2.23ns	0.00932	696 B
master	`RunOnMethodBegin`	net472	1.11μs	0.828ns	3.21ns	0.104	658 B
#6113	`RunOnMethodBegin`	net6.0	757ns	0.284ns	1.1ns	0.00954	696 B
#6113	`RunOnMethodBegin`	netcoreapp3.1	920ns	0.547ns	2.05ns	0.00929	696 B
#6113	`RunOnMethodBegin`	net472	1.14μs	0.286ns	1.07ns	0.104	658 B

andrewlock · 2024-10-03T19:26:29Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6113) (10.986M)   : 0, 10986175
    master (11.149M)   : 0, 11148867
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6113) (7.406M)   : 0, 7405580
    master (7.362M)   : 0, 7361740
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.709M)   : 0, 7709050

    section Manual
    master (11.071M)   : 0, 11070685

    section Manual + Automatic
    This PR (6113) (6.769M)   : 0, 6769342
    master (6.781M)   : 0, 6780963

    section DD_TRACE_ENABLED=0
    master (10.367M)   : 0, 10366772

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6113) (9.542M)   : 0, 9542147
    master (9.405M)   : 0, 9404946
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6113) (6.544M)   : 0, 6543600
    master (6.481M)   : 0, 6481255

    section Trace stats
    master (6.811M)   : 0, 6810924

    section Manual
    master (9.363M)   : 0, 9363048

    section Manual + Automatic
    This PR (6113) (6.172M)   : 0, 6171732
    master (6.119M)   : 0, 6119346

    section DD_TRACE_ENABLED=0
    master (8.751M)   : 0, 8751189

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6113) (10.196M)   : 0, 10195617
    master (10.000M)   : 0, 10000071
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6113) (6.903M)   : 0, 6902586
    master (6.587M)   : 0, 6586687
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.408M)   : 0, 7408035

    section Manual
    master (9.830M)   : 0, 9830358

    section Manual + Automatic
    This PR (6113) (6.247M)   : 0, 6247466
    master (6.190M)   : 0, 6190487

    section DD_TRACE_ENABLED=0
    master (9.382M)   : 0, 9381654

gleocadie

Let's see what the runs on master have to say

## Summary of changes List the status of the threads when GenerateDumpIfDbgRequested fails. This is a continuation of #6113. I enumerated the files, but the threads are directories 🤦 ## Reason for change Flaky test

gleocadie force-pushed the kevin/createdump_hang branch from b73b7ef to f0d7b62 Compare October 7, 2024 11:37

kevingosse added 3 commits October 7, 2024 17:10

Add more info when GenerateDumpIfDbgRequested fails

8bb131e

Moar info

09a9ac0

More moar info

4a4c2e4

gleocadie force-pushed the kevin/createdump_hang branch from f0d7b62 to 4a4c2e4 Compare October 7, 2024 15:10

github-actions bot added the area:profiler Issues related to the continous-profiler label Oct 7, 2024

kevingosse marked this pull request as ready for review October 8, 2024 14:26

kevingosse requested a review from a team as a code owner October 8, 2024 14:26

gleocadie approved these changes Oct 8, 2024

View reviewed changes

kevingosse merged commit 9f6957c into master Oct 8, 2024
80 of 82 checks passed

kevingosse deleted the kevin/createdump_hang branch October 8, 2024 14:29

github-actions bot added this to the vNext-v3 milestone Oct 8, 2024

andrewlock added area:tests unit tests, integration tests and removed area:profiler Issues related to the continous-profiler labels Oct 23, 2024

kevingosse mentioned this pull request Oct 24, 2024

Add more info when GenerateDumpIfDbgRequested fails (take 2) #6197

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more info when GenerateDumpIfDbgRequested fails #6113

Add more info when GenerateDumpIfDbgRequested fails #6113

kevingosse commented Oct 3, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 3, 2024 •

edited

Loading

andrewlock commented Oct 3, 2024 •

edited

Loading

andrewlock commented Oct 3, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6113

Raw results

Raw results

Slower ⚠️ in #6113

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6113

Raw results

andrewlock commented Oct 3, 2024 •

edited

Loading

gleocadie left a comment

Add more info when GenerateDumpIfDbgRequested fails #6113

Add more info when GenerateDumpIfDbgRequested fails #6113

Conversation

kevingosse commented Oct 3, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

datadog-ddstaging bot commented Oct 3, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 3, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 3, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6113

Raw results

Raw results

Slower ⚠️ in #6113

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6113

Raw results

andrewlock commented Oct 3, 2024 • edited Loading

Throughput/Crank Report ⚡

gleocadie left a comment

Choose a reason for hiding this comment

kevingosse commented Oct 3, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 3, 2024 •

edited

Loading

andrewlock commented Oct 3, 2024 •

edited

Loading

andrewlock commented Oct 3, 2024 •

edited

Loading

andrewlock commented Oct 3, 2024 •

edited

Loading