Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert WebRequestIntegration to MethodBuilder / ModuleVersionId #496

Merged
merged 8 commits into from
Aug 30, 2019
Merged

Convert WebRequestIntegration to MethodBuilder / ModuleVersionId #496

merged 8 commits into from
Aug 30, 2019

Conversation

zacharycmontoya
Copy link
Contributor

Changes proposed in this pull request:

Convert the WebRequest integration to the MethodBuilder API

@DataDog/apm-dotnet

@zacharycmontoya
Edit WebRequestIntegration to use the MethodBuilder.
4685dbd 
This change leaves the static WebRequest types unchanged.
@zacharycmontoya zacharycmontoya added type:enhancement Improvement to an existing feature area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) labels Aug 29, 2019
@zacharycmontoya zacharycmontoya added this to the 1.6.3 milestone Aug 29, 2019
@zacharycmontoya zacharycmontoya requested a review from a team as a code owner August 29, 2019 20:52
@zacharycmontoya zacharycmontoya self-assigned this Aug 29, 2019
colin-higgins
colin-higgins previously approved these changes Aug 30, 2019
View reviewed changes
@zacharycmontoya zacharycmontoya merged commit 53094f5 into master Aug 30, 2019
@zacharycmontoya zacharycmontoya deleted the zach/stability/webrequest-mdtoken branch August 30, 2019 18:05
OmerRaviv added a commit that referenced this pull request Feb 16, 2022
@OmerRaviv
Resurrect code fragment from #496 that improves detection of used ports
7479f81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@colin-higgins colin-higgins colin-higgins left review comments

Assignees

@zacharycmontoya zacharycmontoya

Labels
area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) type:enhancement Improvement to an existing feature
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zacharycmontoya @colin-higgins @lucaspimentel