[Linux] Eager assembly load of managed profiler code #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we need to add the directory of the native profiler to the environment variable LD_LIBRARY_PATH.
…in the GetAssemblyAndSymbolsBytes P/Invoke.
zacharycmontoya
added
the
status:work-in-progress
zacharycmontoya
commented
Aug 13, 2019
…eNotFoundException smoke test for all platforms.
zacharycmontoya
force-pushed
the
zach/unix/eager-profiler-load
branch
from
b194e7d to
15e3359
Compare
…un by the integration tests.
On Linux, BIT64 is always defined (previous behavior). In the native profiler for Linux, get the path for the PInvoke by checking the platform-specific profiler path environment variable and falling back to the general environment variable if the first is undefined.
lucaspimentel
added
area:native-library
zacharycmontoya
removed
the
status:work-in-progress
|
Tests are clean except for the Linux run of the |
|
Tests pass minus the Linux StackExchange SmokeTest 😄 |
|
Do you guys have any other feedback on this PR? The integration tests are passing so the Linux port is working correctly. |
lucaspimentel
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main mechanism for loading the managed profiler code was introduced in #462 (commit 4ce932f).
This PR turns on the feature for Linux. The main components are embedding the resources into the shared library, retrieving the embedded resources in the native profiler, and adding the correct PInvoke from the injected assembly load.
@DataDog/apm-dotnet