Colin/apply safe version ranges #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-higgins
added
area:automatic-instrumentation
src/Datadog.Trace.ClrProfiler.Managed/Integrations/AspNetIntegration.cs
Outdated
Show resolved
Hide resolved
src/Datadog.Trace.ClrProfiler.Managed/Integrations/StackExchange.Redis/ConnectionMultiplexer.cs
Outdated
Show resolved
Hide resolved
src/Datadog.Trace.ClrProfiler.Managed/Integrations/ServiceStackRedisIntegration.cs
Outdated
Show resolved
Hide resolved
colin-higgins
force-pushed
the
colin/apply-safe-version-ranges
branch
from
9b0c290 to
8488860
Compare
colin-higgins
removed
the
status:work-in-progress
src/Datadog.Trace.ClrProfiler.Managed/Integrations/AspNetCoreMvc2Integration.cs
Show resolved
Hide resolved
|
This PR looks good to me but I'd prefer @lucaspimentel approve since I have less context on the supported version numbers. |
lucaspimentel
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply version ranges to each relevant integration.
Cleanup unused namespaces.
Update devenv.bat.