-
Notifications
You must be signed in to change notification settings - Fork 147
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix stack overflow when overriding HttpClientHandler.SendAsync() (#367)
* add app that reproduces issue * clean up comments * update props to only include dll/so files * add opcode parameter to DynamicMethodBuilder methods and use it when emitting IL * add an additional argument to every wrapper method with the original call's opcode (value not used yet) * split HttpMessageHandlerIntegration into separate wrappers, use new opcode argument to emit the correct IL * keep using CALL for static method calls * fix build error in AutomapperTest project * fix integrations.json * rename several variables for clarity * include profiler pdb files in sample projects * add test to ensure all wrapper methods have the last "int opCode" parameter
- Loading branch information
1 parent
98e83fa
commit cf8326c
Showing
26 changed files
with
387 additions
and
140 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,24 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <Platforms>x64;x86</Platforms> | ||
| <PlatformTarget>$(Platform)</PlatformTarget> | ||
| <IsPackable>false</IsPackable> | ||
| <GenerateDocumentationFile>false</GenerateDocumentationFile> | ||
| <ProfilerOutputDirectory>..\..\src\Datadog.Trace.ClrProfiler.Native\bin\$(Configuration)\$(Platform)</ProfilerOutputDirectory> | ||
| </PropertyGroup> | ||
| </Project> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\src\Datadog.Trace.ClrProfiler.Managed\Datadog.Trace.ClrProfiler.Managed.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Include="$(ProfilerOutputDirectory)\*.dll;$(ProfilerOutputDirectory)\*.so;$(ProfilerOutputDirectory)\*.pdb" | ||
| CopyToOutputDirectory="Always" | ||
| CopyToPublishDirectory="Always" | ||
| Link="profiler-lib\%(RecursiveDir)\%(Filename)%(Extension)" /> | ||
| <Content Include="..\..\integrations.json" | ||
| CopyToOutputDirectory="Always" | ||
| CopyToPublishDirectory="Always" | ||
| Link="profiler-lib\integrations.json" /> | ||
| </ItemGroup> | ||
| </Project> |
11 changes: 11 additions & 0 deletions
11
reproductions/HttpMessageHandler.StackOverflow/HttpMessageHandler.StackOverflow.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFrameworks>netcoreapp2.2;netcoreapp2.1;netcoreapp2.0</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(TargetFrameworks);net461</TargetFrameworks> | ||
| <Platforms>x64;x86</Platforms> | ||
| <PlatformTarget>$(Platform)</PlatformTarget> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
Oops, something went wrong.