Skip to content

Commit

Permalink
fix build
Browse files Browse the repository at this point in the history
  • Loading branch information
dudikeleti committed Mar 6, 2025
1 parent 5b402b4 commit 159ed19
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions tracer/src/Datadog.Trace/Debugger/Upload/SymbolUploadApi.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ private SymbolUploadApi(
discoveryService.SubscribeToChanges(c => Endpoint = c.SymbolDbEndpoint);
}

public static IBatchUploadApi Create(
internal static IBatchUploadApi Create(
IApiRequestFactory apiRequestFactory,
IDiscoveryService discoveryService,
IGitMetadataTagsProvider gitMetadataTagsProvider,
Expand Down Expand Up @@ -90,7 +90,7 @@ public override async Task<bool> SendBatchAsync(ArraySegment<byte> symbols)
}
else
{
var compressedSymbols = await CompressDataAsync(symbols);
var compressedSymbols = await CompressDataAsync(symbols).ConfigureAwait(false);
if (compressedSymbols == null)
{
return false;
Expand Down Expand Up @@ -126,7 +126,7 @@ public override async Task<bool> SendBatchAsync(ArraySegment<byte> symbols)
return false;
}

public static async Task<ArraySegment<byte>?> CompressDataAsync(ArraySegment<byte> data)
internal async Task<ArraySegment<byte>?> CompressDataAsync(ArraySegment<byte> data)
{
using var memoryStream = new MemoryStream();

Expand All @@ -143,13 +143,15 @@ public override async Task<bool> SendBatchAsync(ArraySegment<byte> symbols)
var compressedData = memoryStream.ToArray();

// see here about the following validation: https://forensics.wiki/gzip/
if (compressedData.Length < 18) // minimum size for header + footer
// minimum size for header + footer
if (compressedData.Length < 18)
{
Log.Error("Compression produced invalid data: size {Size} bytes is below minimum valid GZip size", property: compressedData.Length);
return null;
}

if (compressedData[0] != 0x1F || compressedData[1] != 0x8B) // header magic numbers
// header magic numbers
if (compressedData[0] != 0x1F || compressedData[1] != 0x8B)
{
Log.Error(
"Compression produced invalid data: invalid GZip header {Header}",
Expand Down

0 comments on commit 159ed19

Please sign in to comment.