Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1607 fix: use currentRequest instead originalRequest for interception #1609

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jan 2, 2024

Fixes #1607

What and why?

Because we intercept originalRequest which could have already been mutated, we end up using a stale version of the request.

How?

Use currentRequest for interception.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 2, 2024

Datadog Report

Branch report: ganeshnj/fix/gh-1607-use-current-request
Commit report: c50e81a

dd-sdk-ios: 0 Failed, 0 New Flaky, 2761 Passed, 0 Skipped, 29m 6s Wall Time

@ganeshnj ganeshnj marked this pull request as ready for review January 2, 2024 13:19
@ganeshnj ganeshnj requested review from a team as code owners January 2, 2024 13:19
@ganeshnj ganeshnj merged commit 3c7eaf2 into develop Jan 2, 2024
11 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/fix/gh-1607-use-current-request branch January 2, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected replacing currentRequest with originalRequest
2 participants