Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPLAY-1936 Session Replay Objective-C interface #1419

Merged
merged 3 commits into from
Aug 18, 2023
Merged

REPLAY-1936 Session Replay Objective-C interface #1419

merged 3 commits into from
Aug 18, 2023

Conversation

maxep
Copy link
Member

@maxep maxep commented Aug 17, 2023

What and why?

Expose Session Replay to Objective-C.
Fix #1387

How?

Add SessionReplay objective-c interface to DatadogObjc module.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maxep maxep self-assigned this Aug 17, 2023
@maxep maxep requested a review from a team as a code owner August 17, 2023 12:31
@maxep maxep mentioned this pull request Aug 17, 2023
Closed
6 tasks
@maxep maxep changed the title REPLAY-1936 add objective-c interface REPLAY-1936 Session Replay Objective-C interface Aug 17, 2023
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Aug 17, 2023 •
edited
Loading

Datadog Report

Branch report: maxep/REPLAY-1936/sr-objc-2
Commit report: 1bb2566

✅ dd-sdk-ios: 0 Failed, 0 New Flaky, 118 Passed, 0 Skipped, 2m 33.89s Wall Time

ncreated
ncreated previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 💯 Looks good. Thanks for the earlier draft earlier - looking forward make Objc offering modular 🙂!

DatadogObjc/Sources/SessionReplay/SessionReplay+objc.swift Outdated Show resolved Hide resolved
DatadogObjc/Sources/SessionReplay/SessionReplay+objc.swift Outdated Show resolved Hide resolved
DatadogObjc/Sources/SessionReplay/SessionReplay+objc.swift Outdated Show resolved Hide resolved
@maxep maxep force-pushed the maxep/REPLAY-1936/sr-objc-2 branch from 597da94 to 1bb2566 Compare August 17, 2023 16:26
@maxep maxep requested a review from ncreated August 17, 2023 16:48
@maxep maxep merged commit cbb720c into develop Aug 18, 2023
15 checks passed
This was referenced Aug 18, 2023
Merged
Merged
@maxep maxep deleted the maxep/REPLAY-1936/sr-objc-2 branch August 23, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees

@maxep maxep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session Replay Beta - in objective - c
2 participants
@maxep @ncreated