Increase error count by 1 on the view update event following a crash #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
maciejburda
approved these changes
Jan 31, 2023
| @@ -399,7 +399,7 @@ internal struct CrashReportReceiver: FeatureMessageReceiver { | |||
| domComplete: original.view.domComplete, | |||
| domContentLoaded: original.view.domContentLoaded, | |||
| domInteractive: original.view.domInteractive, | |||
| error: original.view.error, | |||
| error: .init(count: original.view.error.count + 1), | |||
There was a problem hiding this comment.
Error model for now only has count, but I think it would be safer to copy object original.view.error and then add 1 to the count (just so it doesn't break when we alter the model).
maxep
approved these changes
Jan 31, 2023
xgouchet
approved these changes
Jan 31, 2023
maxep
deleted the
plousada/RUMM-2992/view-error-count-not-being-incremented
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Following a crash, when updating a view with the crash count increase we should also increase the error count.
How?
A brief description of implementation details of this PR.
Review checklist
Custom CI job configuration (optional)