-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-2718 Automatic otel b3 headers injection #1061
RUMM-2718 Automatic otel b3 headers injection #1061
Conversation
Datadog ReportBranch report: ✅ |
bd4397b
to
fc62b79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, it's very clear and I like the ability to use both header type 👍 I left minor suggestions.
Sources/Datadog/Tracing/Propagation/TracePropagationHeadersExctractor.swift
Outdated
Show resolved
Hide resolved
fc62b79
to
2d173f4
Compare
b62a130
to
b9178f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really, well done 💪🏅. I left few comments, mainly on the public APIs and their comments. I'd like we first discuss it before merge. Implementation looks great 💯.
What and why?
Adds SDK wide configuration for automatic OTel support.
How?
Adds configuration enum and leverages mechanisms added in the previous PR.
Review checklist
Custom CI job configuration (optional)