Repository navigation
RUM-18981: Add Flags single-fit integration tests - #3989
Conversation
Add an in-memory datastore, stubbable network responses, opt-in event forwarding between features, a way to stop all features, and no-op periodic scheduling to the stub SDK core. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cover the FlagsClient registry, flag resolution, exposure and evaluation events, persistence across restarts and the RUM integration against a stub SDK core, and run them in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
✅ All CI checks and tests passed. Datadog automation helped this PR pass. 🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: db52c7c | Docs | View more details | Give us feedback! |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
035d890 to
6353f7d
Compare
Drop the unit tests whose behavior is now verified end-to-end in reliability/single-fit/flags: client registry lookups, happy-path flag resolution and resolution details, exposure and RUM evaluation tracking toggles, and a duplicated Flags.enable test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6353f7d to
3714031
Compare
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![datadog-datadog-prod-us1-2[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The Flags test migration and shared SDK stub changes produced no reportable correctness concerns in the completed static review. Integration-test execution remains unverified.
🤖 Bits Code Review · Commit 3714031
typotter
left a comment
typotter
left a comment
There was a problem hiding this comment.
just a nonblocking asserting which I think was lost in the trimming of the tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 participants
What does this PR do?
This PR adds integration tests for the Flags module.
Also removes tests from
features/dd-sdk-android-flagswhich are rather integration tests.Review checklist (to be filled by reviewers)