Skip to content

feat: Add flushing destructor for Tracer #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DS-Serafin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add flushing destructor for Tracer #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/tracer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,13 @@ Tracer::Tracer(TracerOptions options, std::shared_ptr<Writer> writer,
options.service, traceTagsPropagationMaxLength(options, *logger_)});
}

Tracer::~Tracer() {
try {
Close();
} catch (...) {
}
}

std::unique_ptr<ot::Span> Tracer::StartSpanWithOptions(ot::string_view operation_name,
const ot::StartSpanOptions &options) const
noexcept try {
Expand Down
3 changes: 3 additions & 0 deletions src/tracer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ class Tracer : public ot::Tracer, public std::enable_shared_from_this<Tracer> {

Tracer() = delete;

// Destructs tracer and flushes internal buffers
virtual ~Tracer();

// Starts a new span.
std::unique_ptr<ot::Span> StartSpanWithOptions(ot::string_view operation_name,
const ot::StartSpanOptions &options) const
Expand Down