Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos that break dogshell #755

Closed
wants to merge 2 commits into from
Closed

Fix typos that break dogshell #755

wants to merge 2 commits into from

Conversation

louy
Copy link

@louy louy commented Jan 24, 2023

What does this PR do?

Fix a few typos that break dogshell cli

➜  Projects dog --help
Traceback (most recent call last):
  File "/Users/louay/.asdf/installs/python/3.11.1/bin/dog", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/site-packages/datadog/dogshell/__init__.py", line 96, in main
    DashboardListClient.setup_parser(subparsers)
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/site-packages/datadog/dogshell/dashboard_list.py", line 128, in setup_parser
    delete_dashboards_v2_parser = verb_parsers.add_parser(
                                  ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/argparse.py", line 1185, in add_parser
    raise ArgumentError(self, _('conflicting subparser: %s') % name)
argparse.ArgumentError: argument verb: conflicting subparser: delete_dashboards
➜  Projects dog --help
Traceback (most recent call last):
  File "/Users/louay/.asdf/installs/python/3.11.1/bin/dog", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/site-packages/datadog/dogshell/__init__.py", line 100, in main
    ServiceLevelObjectiveClient.setup_parser(subparsers)
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/site-packages/datadog/dogshell/service_level_objective.py", line 150, in setup_parser
    delete_timeframe_parser = verb_parsers.add_parser("delete_many", help="Delete a SLO timeframe")
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/louay/.asdf/installs/python/3.11.1/lib/python3.11/argparse.py", line 1185, in add_parser
    raise ArgumentError(self, _('conflicting subparser: %s') % name)
argparse.ArgumentError: argument verb: conflicting subparser: delete_many

Description of the Change

Typos in arguments passed to argparse

Alternate Designs

Possible Drawbacks

Verification Process

Tested locally, no more errors being thrown

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@louy louy requested a review from a team as a code owner January 24, 2023 15:22
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label Feb 24, 2023
@louy
Copy link
Author

louy commented Feb 27, 2023

Not stale

@nkzou
Copy link
Contributor

nkzou commented Jul 10, 2023

Fixed by #760

@nkzou nkzou closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale - Bot reminder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants