Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Set metric type to threadstats #545

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Add Set metric type to threadstats #545

merged 2 commits into from
Mar 6, 2020

Conversation

zippolyte
Copy link
Contributor

What does this PR do?

Closes #131

Description of the Change

Add Set class and set method to threadstats object to support set metrics in threadstats

Verification Process

unit tests

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@zippolyte zippolyte added resource/threadstats changelog/Added Added features results into a minor version bump labels Mar 6, 2020
@zippolyte zippolyte requested a review from a team as a code owner March 6, 2020 13:01
gzussa
gzussa previously approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jirikuncar
jirikuncar suggested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@jirikuncar jirikuncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have only style comments and probably one copy&paste typo.

datadog/threadstats/base.py Show resolved Hide resolved
datadog/threadstats/base.py Show resolved Hide resolved
datadog/threadstats/base.py Show resolved Hide resolved
datadog/threadstats/metrics.py Outdated Show resolved Hide resolved
tests/unit/threadstats/test_threadstats.py Show resolved Hide resolved
@zippolyte @jirikuncar
Update datadog/threadstats/metrics.py
cda8168 
Co-Authored-By: Jiri Kuncar <jiri.kuncar@datadoghq.com>
@jirikuncar
Copy link
Contributor

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

gzussa
gzussa approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests!

@zippolyte zippolyte merged commit 62e8d99 into master Mar 6, 2020
@zippolyte zippolyte deleted the hippo/tsm branch March 6, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa approved these changes

@jirikuncar jirikuncar jirikuncar approved these changes

Assignees
No one assigned
Labels
changelog/Added Added features results into a minor version bump resource/threadstats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Threadstatsd set metric
3 participants
@zippolyte @jirikuncar @gzussa