Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize role name in log forwarder CFN template #594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpassaro
Copy link

What does this PR do?

Allow users to specify the prefix for the AWS/IAM role the Cloudformation stack creates

Motivation

In some regulated AWS environments, there are constraints on how resources can be named. That means the stack as it currently exists will fail because the auto-generated role name does not comply with these constraints. This change allows me to use the stack and comply with those constraints.

Testing Guidelines

Ran it in my organization's environment and observed that the role could be created.

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant