feat(appsec): enable request blocking #630
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables Appsec to block request if they are deemed dangerous by the in-app WAF.
There are three cases:
asm_start_request
BlockingException
asm_start_response
Motivation
Expand the capabilities of Appsec inside the datadog-lambda-python layer.
Testing Guidelines
I added unit tests to both
test_asm.py
andtest_wrapper.py
to ensure requests are blocked only if necessary and at the right stage.Integration tests will be run as part of the system-test, APPSEC_BLOCKING scenario.
Types of Changes
Check all that apply