Skip to content

feat: Enable sqs -> lambda support for DSM #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixes
  • Loading branch information
michael-zhao459 committed Jun 5, 2025
commit 1f888b14934ca5010cdc7b10fbdeeeedbb08131a
26 changes: 11 additions & 15 deletions tests/test_dsm.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
from unittest.mock import patch, MagicMock

from datadog_lambda.dsm import set_dsm_context, _dsm_set_sqs_context
from datadog_lambda.trigger import EventTypes
from datadog_lambda.trigger import EventTypes, _EventSource


class TestDsmContext(unittest.TestCase):
class TestDsmSQSContext(unittest.TestCase):
def setUp(self):
patcher = patch("datadog_lambda.dsm._dsm_set_sqs_context")
self.mock_dsm_set_sqs_context = patcher.start()
Expand Down Expand Up @@ -33,17 +33,15 @@ def setUp(self):

def test_non_sqs_event_source_does_nothing(self):
"""Test that non-SQS event sources don't trigger DSM context setting"""
event = {"Records": [{"body": "test"}]}
event = {}
# Use Unknown Event Source
event_source = _EventSource(EventTypes.UNKNOWN)
set_dsm_context(event, event_source)

mock_event_source = MagicMock()
mock_event_source.equals.return_value = False # Not SQS

set_dsm_context(event, mock_event_source)

mock_event_source.equals.assert_called_once_with(EventTypes.SQS)
# DSM context should not be set for non-SQS events
self.mock_dsm_set_sqs_context.assert_not_called()

def test_event_with_no_records_does_nothing(self):
def test_sqs_event_with_no_records_does_nothing(self):
"""Test that events where Records is None don't trigger DSM processing"""
events_with_no_records = [
{},
Expand All @@ -67,14 +65,12 @@ def test_sqs_event_triggers_dsm_sqs_context(self):
]
}

mock_event_source = MagicMock()
mock_event_source.equals.return_value = True

set_dsm_context(sqs_event, mock_event_source)
event_source = _EventSource(EventTypes.SQS)
set_dsm_context(sqs_event, event_source)

self.mock_dsm_set_sqs_context.assert_called_once_with(sqs_event)

def test_multiple_records_process_each_record(self):
def test_sqs_multiple_records_process_each_record(self):
"""Test that each record in an SQS event gets processed individually"""
multi_record_event = {
"Records": [
Expand Down
Loading