Move span pointer to inferred span; add env var to toggle span pointers#607
Merged
Move span pointer to inferred span; add env var to toggle span pointers#607
Conversation
11 tasks
purple4reina
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DD_TRACE_AWS_ADD_SPAN_POINTERSto toggle span pointersspan.addSpanPointerswith try/catch, sincespanis of type any.Note that moving the location of the span pointer has no actual effect on the functionality and requires no changes on the UI side. As long as a span is found with a matching hash, span pointers work. Since the spans are on the same trace, this has no noticeable change for our users. This change just aligns span pointers with bottlecap (universally instrumented) runtimes.
Motivation
Testing Guidelines
Manual testing. The span links are now on the root (inferred) span.

Additional Notes
Types of Changes
Check all that apply