chore: Use rust-license-tool for license file #741
Merged
+268
−33,353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
added a commit
that referenced
this pull request
Jul 14, 2025
# This PR Allows the workflow `rs_ci.yml` to be triggered manually. # Motivation Right now `rs_ci.yml` can only use the workflow from the main branch, making it hard to test #741.
lym953
force-pushed
the
yiming.luo/csv-license
branch
from
0f9f00e to
c23b651
Compare
duncanista
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The license check often fails, which requires extra engineering time to fix.
This PR
Switch to using Datadog's
rust-license-toolto manage the license file. https://github.com/DataDog/rust-license-toolThis replaces
bottlecap/LICENSE-3rdparty.ymlwithbottlecap/LICENSE-3rdparty.csv.Testing
Success case
Run this workflow on
yiming.luo/csv-licensebranch, which was successfulhttps://github.com/DataDog/datadog-lambda-extension/actions/runs/16274305134
Failure case
Delete a line in the license file then run the workflow, which failed as expected
https://github.com/DataDog/datadog-lambda-extension/actions/runs/16274444263