Skip to content

Add 'mute_buttons' argument to slack channel definition #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-02 20:49:29.894380",
"spec_repo_commit": "9ea284b5"
"regenerated": "2025-04-03 09:26:30.518843",
"spec_repo_commit": "f1a43647"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-02 20:49:29.913373",
"spec_repo_commit": "9ea284b5"
"regenerated": "2025-04-03 09:26:30.534200",
"spec_repo_commit": "f1a43647"
}
}
}
6 changes: 6 additions & 0 deletions .generator/schemas/v1/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13489,6 +13489,10 @@ components:
default: true
description: Show the main body of the alert event.
type: boolean
mute_buttons:
default: false
description: Show interactive buttons to mute the alerting monitor.
type: boolean
notified:
default: true
description: Show the list of @-handles in the alert event.
Expand All @@ -13507,12 +13511,14 @@ components:
example:
- display:
message: true
mute_buttons: true
notified: true
snapshot: true
tags: true
name: '#channel_name_main_account'
- display:
message: true
mute_buttons: true
notified: true
snapshot: false
tags: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const params: v1.SlackIntegrationApiCreateSlackIntegrationChannelRequest = {
body: {
display: {
message: true,
muteButtons: false,
notified: true,
snapshot: true,
tags: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const params: v1.SlackIntegrationApiUpdateSlackIntegrationChannelRequest = {
body: {
display: {
message: true,
muteButtons: false,
notified: true,
snapshot: true,
tags: true,
Expand Down
42 changes: 21 additions & 21 deletions features/v1/slack_integration.feature
Original file line number Diff line number Diff line change
Expand Up @@ -9,122 +9,122 @@ Feature: Slack Integration
And a valid "appKeyAuth" key in the system
And an instance of "SlackIntegration" API

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Create a Slack integration channel returns "Bad Request" response
Given new "CreateSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Create a Slack integration channel returns "Item Not Found" response
Given new "CreateSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
When the request is sent
Then the response status is 404 Item Not Found

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Create a Slack integration channel returns "OK" response
Given new "CreateSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
When the request is sent
Then the response status is 200 OK

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Get a Slack integration channel returns "Bad Request" response
Given new "GetSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And request contains "channel_name" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Get a Slack integration channel returns "Item Not Found" response
Given new "GetSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And request contains "channel_name" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 404 Item Not Found

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Get a Slack integration channel returns "OK" response
Given new "GetSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And request contains "channel_name" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 200 OK

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Get all channels in a Slack integration returns "Bad Request" response
Given new "GetSlackIntegrationChannels" request
And request contains "account_name" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Get all channels in a Slack integration returns "Item Not Found" response
Given new "GetSlackIntegrationChannels" request
And request contains "account_name" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 404 Item Not Found

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Get all channels in a Slack integration returns "OK" response
Given new "GetSlackIntegrationChannels" request
And request contains "account_name" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 200 OK

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Remove a Slack integration channel returns "Bad Request" response
Given new "RemoveSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And request contains "channel_name" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Remove a Slack integration channel returns "Item Not Found" response
Given new "RemoveSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And request contains "channel_name" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 404 Item Not Found

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Remove a Slack integration channel returns "The channel was removed successfully." response
Given new "RemoveSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And request contains "channel_name" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 204 The channel was removed successfully.

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Update a Slack integration channel returns "Bad Request" response
Given new "UpdateSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And request contains "channel_name" parameter from "REPLACE.ME"
And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Update a Slack integration channel returns "Item Not Found" response
Given new "UpdateSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And request contains "channel_name" parameter from "REPLACE.ME"
And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
When the request is sent
Then the response status is 404 Item Not Found

@generated @skip @team:DataDog/saas-integrations
@generated @skip @team:DataDog/chat-integrations
Scenario: Update a Slack integration channel returns "OK" response
Given new "UpdateSlackIntegrationChannel" request
And request contains "account_name" parameter from "REPLACE.ME"
And request contains "channel_name" parameter from "REPLACE.ME"
And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
When the request is sent
Then the response status is 200 OK
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ export class SlackIntegrationChannelDisplay {
* Show the main body of the alert event.
*/
"message"?: boolean;
/**
* Show interactive buttons to mute the alerting monitor.
*/
"muteButtons"?: boolean;
/**
* Show the list of @-handles in the alert event.
*/
Expand Down Expand Up @@ -47,6 +51,10 @@ export class SlackIntegrationChannelDisplay {
baseName: "message",
type: "boolean",
},
muteButtons: {
baseName: "mute_buttons",
type: "boolean",
},
notified: {
baseName: "notified",
type: "boolean",
Expand Down