Skip to content

dashboards add support for time-slice SLOs #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2024-07-16 18:49:24.330562",
"spec_repo_commit": "a669b93e"
"regenerated": "2024-07-17 08:36:19.870752",
"spec_repo_commit": "f77e7cb2"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2024-07-16 18:49:24.349453",
"spec_repo_commit": "a669b93e"
"regenerated": "2024-07-17 08:36:19.888753",
"spec_repo_commit": "f77e7cb2"
}
}
}
2 changes: 2 additions & 0 deletions .generator/schemas/v1/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3087,10 +3087,12 @@ components:
description: Name of the query for use in formulas.
enum:
- metric
- time_slice
example: metric
type: string
x-enum-varnames:
- METRIC
- TIME_SLICE
FormulaType:
description: Set the sort type to formula.
enum:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,9 @@ import { UnparsedObject } from "../../datadog-api-client-common/util";
* Name of the query for use in formulas.
*/

export type FormulaAndFunctionSLOQueryType = typeof METRIC | UnparsedObject;
export type FormulaAndFunctionSLOQueryType =
| typeof METRIC
| typeof TIME_SLICE
| UnparsedObject;
export const METRIC = "metric";
export const TIME_SLICE = "time_slice";
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ const enumsMap: { [key: string]: any[] } = {
"burn_rate",
"error_budget_burndown",
],
FormulaAndFunctionSLOQueryType: ["metric"],
FormulaAndFunctionSLOQueryType: ["metric", "time_slice"],
FormulaType: ["formula"],
FreeTextWidgetDefinitionType: ["free_text"],
FunnelRequestType: ["funnel"],
Expand Down
Loading