-
Notifications
You must be signed in to change notification settings - Fork 22
add custom extent prop for geomap widget #2448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add custom extent prop for geomap widget #2448
Conversation
@@ -60,6 +65,12 @@ def initialize(attributes = {}) | |||
end | |||
} | |||
|
|||
if attributes.key?(:'custom_extent') | |||
if (value = attributes[:'custom_extent']).is_a?(Array) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ Code Quality Violation
Consider using Array() to ensure the type is that of an array (...read more)
The rule "Use Array()
to ensure your variable is an array" is important for ensuring your code behaves as expected, regardless of the type of data it receives. It is common in Ruby to need to iterate through an array of items. However, if the variable is not an array, this can lead to unexpected behavior or errors.
The Array()
method in Ruby is a Kernel method that converts its argument to an Array. If the argument is already an Array, it returns the argument. If the argument is nil, it returns an empty Array. This can be used to ensure that a variable is an array before trying to iterate over it, preventing potential errors or unexpected behavior.
By using Array(foos)
, you can ensure that foos
is an array before you try to iterate over it with each
. This prevents the need to check if foos
is an array with foos.is_a?(Array)
and makes your code cleaner and easier to understand.
Datadog ReportBranch report: ✅ 0 Failed, 1345 Passed, 1889 Skipped, 2m 12.15s Total duration (1m 8.56s time saved) |
83ab8af
to
b566c60
Compare
8602a00
to
70124ae
Compare
70124ae
to
64b75be
Compare
64b75be
to
22d22d5
Compare
See DataDog/datadog-api-spec#3923
Test branch datadog-api-spec/test/victor.wei/DEX-114/add_custom_extent_to_tiledef