Conversation
HantingZhang2
added
the
changelog/Added
…lient-java into hantingz/add-retry
HantingZhang2
changed the title
therve
reviewed
Aug 9, 2023
therve
reviewed
Aug 9, 2023
src/test/resources/cassettes/v2/RetryTest.retryWithDashboardListItemGetTest429.json
Show resolved
Hide resolved
| if (statusCode == 429 || statusCode >= 500) { | ||
| statusToRetry = true; | ||
| } | ||
| return (retryConfig.maxRetries >= retryCount && statusToRetry && retryConfig.isEnableRetry()); |
Contributor
There was a problem hiding this comment.
Suggested change
| return (retryConfig.maxRetries >= retryCount && statusToRetry && retryConfig.isEnableRetry()); | |
| return (retryConfig.maxRetries > retryCount && statusToRetry && retryConfig.isEnableRetry()); |
As you start with 0 this should be a strict comparison.
therve
requested changes
Aug 11, 2023
README.md
Outdated
| To enable the client to retry when rate limited (status 429) or status 500 and above: | ||
|
|
||
| ```java | ||
| defaultClient.setRetry(new RetryConfig(true, int <multiplier_for_retry_backoff>, int <base_for_retry_backoff>,int <max_retry_attemps>)) |
Contributor
There was a problem hiding this comment.
Let's document enableRetry here insread.
| if (statusCode == 429 || statusCode >= 500) { | ||
| statusToRetry = true; | ||
| } | ||
| return (retryConfig.maxRetries >= retryCount && statusToRetry && retryConfig.isEnableRetry()); |
therve
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds retry support and corresponding config options.
Additional Notes
Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR that includes tests.