Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark groupby_simple_monitor as deprecated #2658

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2024-09-03 18:07:15.535510",
"spec_repo_commit": "2d21d782"
"regenerated": "2024-09-04 13:35:30.135409",
"spec_repo_commit": "b289628c"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2024-09-03 18:07:15.553692",
"spec_repo_commit": "2d21d782"
"regenerated": "2024-09-04 13:35:30.153470",
"spec_repo_commit": "b289628c"
}
}
}
3 changes: 2 additions & 1 deletion .generator/schemas/v1/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7066,8 +7066,9 @@ components:
Error Tracking, Event, Logs, and RUM monitors.'
type: string
groupby_simple_monitor:
deprecated: true
description: Whether the log alert monitor triggers a single alert or multiple
alerts when any group breaches a threshold.
alerts when any group breaches a threshold. Use `notify_by` instead.
type: boolean
include_tags:
default: true
Expand Down
6 changes: 5 additions & 1 deletion api/datadogV1/model_monitor_options.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ type MonitorOptions struct {
// Example values are: "60m", "1h", and "2d".
// This option is only available for APM Trace Analytics, Audit Trail, CI, Error Tracking, Event, Logs, and RUM monitors.
GroupRetentionDuration *string `json:"group_retention_duration,omitempty"`
// Whether the log alert monitor triggers a single alert or multiple alerts when any group breaches a threshold.
// Whether the log alert monitor triggers a single alert or multiple alerts when any group breaches a threshold. Use `notify_by` instead.
// Deprecated
GroupbySimpleMonitor *bool `json:"groupby_simple_monitor,omitempty"`
// A Boolean indicating whether notifications from this monitor automatically inserts its triggering tags into the title.
//
Expand Down Expand Up @@ -377,6 +378,7 @@ func (o *MonitorOptions) SetGroupRetentionDuration(v string) {
}

// GetGroupbySimpleMonitor returns the GroupbySimpleMonitor field value if set, zero value otherwise.
// Deprecated
func (o *MonitorOptions) GetGroupbySimpleMonitor() bool {
if o == nil || o.GroupbySimpleMonitor == nil {
var ret bool
Expand All @@ -387,6 +389,7 @@ func (o *MonitorOptions) GetGroupbySimpleMonitor() bool {

// GetGroupbySimpleMonitorOk returns a tuple with the GroupbySimpleMonitor field value if set, nil otherwise
// and a boolean to check if the value has been set.
// Deprecated
func (o *MonitorOptions) GetGroupbySimpleMonitorOk() (*bool, bool) {
if o == nil || o.GroupbySimpleMonitor == nil {
return nil, false
Expand All @@ -400,6 +403,7 @@ func (o *MonitorOptions) HasGroupbySimpleMonitor() bool {
}

// SetGroupbySimpleMonitor gets a reference to the given bool and assigns it to the GroupbySimpleMonitor field.
// Deprecated
func (o *MonitorOptions) SetGroupbySimpleMonitor(v bool) {
o.GroupbySimpleMonitor = &v
}
Expand Down
Loading