Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable/beta note since Metrics Without Limits is GA #1526

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.2",
"regenerated": "2022-06-01 08:09:47.329559",
"spec_repo_commit": "921d5a27"
"regenerated": "2022-06-03 14:41:28.816296",
"spec_repo_commit": "dfe05b82"
},
"v2": {
"apigentools_version": "1.6.2",
"regenerated": "2022-06-01 08:09:47.341885",
"spec_repo_commit": "921d5a27"
"regenerated": "2022-06-03 14:41:28.831457",
"spec_repo_commit": "dfe05b82"
}
}
}
26 changes: 0 additions & 26 deletions .generator/schemas/v2/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9575,10 +9575,6 @@ paths:
x-menu-order: 5
x-undo:
type: safe
x-unstable: "**Note: Use of this endpoint for count/gauge/rate metric types
is only accessible for Metrics without Limits™ beta customers.\nIf you\u2019re
interested in Metrics without Limits™, please contact your Customer
Success Manager.**"
/api/v2/metrics/config/bulk-tags:
delete:
description: 'Delete all custom lists of queryable tag keys for a set of existing
Expand Down Expand Up @@ -9885,10 +9881,6 @@ paths:
x-menu-order: 4
x-undo:
type: idempotent
x-unstable: "**Note: Use of this endpoint for count/gauge/rate metric types
is only accessible for Metrics without Limits™ beta customers.\nIf you\u2019re
interested in Metrics without Limits™, please contact your Customer
Success Manager.**"
get:
description: Returns the tag configuration for the given metric name.
operationId: ListTagConfigurationByName
Expand Down Expand Up @@ -9925,10 +9917,6 @@ paths:
x-menu-order: 2
x-undo:
type: safe
x-unstable: "**Note: Use of this endpoint for count/gauge/rate metric types
is only accessible for Metrics without Limits™ beta customers.\nIf you\u2019re
interested in Metrics without Limits™, please contact your Customer
Success Manager.**"
patch:
description: 'Update the tag configuration of a metric or percentile aggregations
of a distribution metric or custom aggregations
Expand Down Expand Up @@ -9984,10 +9972,6 @@ paths:
x-menu-order: 3
x-undo:
type: idempotent
x-unstable: "**Note: Use of this endpoint for count/gauge/rate metric types
is only accessible for Metrics without Limits™ beta customers.\nIf you\u2019re
interested in Metrics without Limits™, please contact your Customer
Success Manager.**"
post:
description: 'Create and define a list of queryable tag keys for an existing
count/gauge/rate/distribution metric.
Expand Down Expand Up @@ -10061,21 +10045,11 @@ paths:
- name: metric_name
source: data.id
type: unsafe
x-unstable: "**Note: Use of this endpoint for count/gauge/rate metric types
is only accessible for Metrics without Limits™ beta customers.\nIf you\u2019re
interested in Metrics without Limits™, please contact your Customer
Success Manager.**"
/api/v2/metrics/{metric_name}/volumes:
get:
description: 'View distinct metrics volumes for the given metric name.


Custom distribution metrics will return both ingested and indexed custom metric
volumes.

For Metrics without Limits™ beta customers, all metrics will return
both ingested/indexed volumes.

Custom metrics generated in-app from other products will return `null` for
ingested volumes.'
operationId: ListVolumesByMetricName
Expand Down
39 changes: 0 additions & 39 deletions api/v2/datadog/api_metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ package datadog
import (
"bytes"
_context "context"
_fmt "fmt"
_ioutil "io/ioutil"
_log "log"
_nethttp "net/http"
_neturl "net/url"
"strings"
Expand Down Expand Up @@ -236,13 +234,6 @@ func (a *MetricsApiService) createTagConfigurationExecute(r apiCreateTagConfigur
localVarReturnValue MetricTagConfigurationResponse
)

operationId := "CreateTagConfiguration"
if r.ApiService.client.cfg.IsUnstableOperationEnabled(operationId) {
_log.Printf("WARNING: Using unstable operation '%s'", operationId)
} else {
return localVarReturnValue, nil, GenericOpenAPIError{error: _fmt.Sprintf("Unstable operation '%s' is disabled", operationId)}
}

localBasePath, err := a.client.cfg.ServerURLWithContext(r.ctx, "MetricsApiService.CreateTagConfiguration")
if err != nil {
return localVarReturnValue, nil, GenericOpenAPIError{error: err.Error()}
Expand Down Expand Up @@ -592,13 +583,6 @@ func (a *MetricsApiService) deleteTagConfigurationExecute(r apiDeleteTagConfigur
localVarPostBody interface{}
)

operationId := "DeleteTagConfiguration"
if r.ApiService.client.cfg.IsUnstableOperationEnabled(operationId) {
_log.Printf("WARNING: Using unstable operation '%s'", operationId)
} else {
return nil, GenericOpenAPIError{error: _fmt.Sprintf("Unstable operation '%s' is disabled", operationId)}
}

localBasePath, err := a.client.cfg.ServerURLWithContext(r.ctx, "MetricsApiService.DeleteTagConfiguration")
if err != nil {
return nil, GenericOpenAPIError{error: err.Error()}
Expand Down Expand Up @@ -975,13 +959,6 @@ func (a *MetricsApiService) listTagConfigurationByNameExecute(r apiListTagConfig
localVarReturnValue MetricTagConfigurationResponse
)

operationId := "ListTagConfigurationByName"
if r.ApiService.client.cfg.IsUnstableOperationEnabled(operationId) {
_log.Printf("WARNING: Using unstable operation '%s'", operationId)
} else {
return localVarReturnValue, nil, GenericOpenAPIError{error: _fmt.Sprintf("Unstable operation '%s' is disabled", operationId)}
}

localBasePath, err := a.client.cfg.ServerURLWithContext(r.ctx, "MetricsApiService.ListTagConfigurationByName")
if err != nil {
return localVarReturnValue, nil, GenericOpenAPIError{error: err.Error()}
Expand Down Expand Up @@ -1201,13 +1178,6 @@ func (a *MetricsApiService) listTagConfigurationsExecute(r apiListTagConfigurati
localVarReturnValue MetricsAndMetricTagConfigurationsResponse
)

operationId := "ListTagConfigurations"
if r.ApiService.client.cfg.IsUnstableOperationEnabled(operationId) {
_log.Printf("WARNING: Using unstable operation '%s'", operationId)
} else {
return localVarReturnValue, nil, GenericOpenAPIError{error: _fmt.Sprintf("Unstable operation '%s' is disabled", operationId)}
}

localBasePath, err := a.client.cfg.ServerURLWithContext(r.ctx, "MetricsApiService.ListTagConfigurations")
if err != nil {
return localVarReturnValue, nil, GenericOpenAPIError{error: err.Error()}
Expand Down Expand Up @@ -1516,8 +1486,6 @@ func (a *MetricsApiService) buildListVolumesByMetricNameRequest(ctx _context.Con
// ListVolumesByMetricName List distinct metric volumes by metric name.
// View distinct metrics volumes for the given metric name.
//
// Custom distribution metrics will return both ingested and indexed custom metric volumes.
// For Metrics without Limits™ beta customers, all metrics will return both ingested/indexed volumes.
// Custom metrics generated in-app from other products will return `null` for ingested volumes.
func (a *MetricsApiService) ListVolumesByMetricName(ctx _context.Context, metricName string) (MetricVolumesResponse, *_nethttp.Response, error) {
req, err := a.buildListVolumesByMetricNameRequest(ctx, metricName)
Expand Down Expand Up @@ -1908,13 +1876,6 @@ func (a *MetricsApiService) updateTagConfigurationExecute(r apiUpdateTagConfigur
localVarReturnValue MetricTagConfigurationResponse
)

operationId := "UpdateTagConfiguration"
if r.ApiService.client.cfg.IsUnstableOperationEnabled(operationId) {
_log.Printf("WARNING: Using unstable operation '%s'", operationId)
} else {
return localVarReturnValue, nil, GenericOpenAPIError{error: _fmt.Sprintf("Unstable operation '%s' is disabled", operationId)}
}

localBasePath, err := a.client.cfg.ServerURLWithContext(r.ctx, "MetricsApiService.UpdateTagConfiguration")
if err != nil {
return localVarReturnValue, nil, GenericOpenAPIError{error: err.Error()}
Expand Down
5 changes: 0 additions & 5 deletions api/v2/datadog/configuration.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,6 @@ func NewConfiguration() *Configuration {
"DeleteIncident": false,
"GetIncident": false,
"UpdateIncident": false,
"ListTagConfigurations": false,
"DeleteTagConfiguration": false,
"ListTagConfigurationByName": false,
"UpdateTagConfiguration": false,
"CreateTagConfiguration": false,
"ListSecurityMonitoringSignals": false,
"SearchSecurityMonitoringSignals": false,
"ListIncidentServices": false,
Expand Down
1 change: 0 additions & 1 deletion examples/v2/metrics/CreateTagConfiguration.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ func main() {
}
ctx := datadog.NewDefaultContext(context.Background())
configuration := datadog.NewConfiguration()
configuration.SetUnstableOperationEnabled("CreateTagConfiguration", true)
apiClient := datadog.NewAPIClient(configuration)
resp, r, err := apiClient.MetricsApi.CreateTagConfiguration(ctx, "ExampleCreateatagconfigurationreturnsCreatedresponse", body)

Expand Down
1 change: 0 additions & 1 deletion examples/v2/metrics/DeleteTagConfiguration.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
func main() {
ctx := datadog.NewDefaultContext(context.Background())
configuration := datadog.NewConfiguration()
configuration.SetUnstableOperationEnabled("DeleteTagConfiguration", true)
apiClient := datadog.NewAPIClient(configuration)
r, err := apiClient.MetricsApi.DeleteTagConfiguration(ctx, "ExampleDeleteatagconfigurationreturnsNoContentresponse")

Expand Down
1 change: 0 additions & 1 deletion examples/v2/metrics/ListTagConfigurationByName.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ func main() {

ctx := datadog.NewDefaultContext(context.Background())
configuration := datadog.NewConfiguration()
configuration.SetUnstableOperationEnabled("ListTagConfigurationByName", true)
apiClient := datadog.NewAPIClient(configuration)
resp, r, err := apiClient.MetricsApi.ListTagConfigurationByName(ctx, MetricTagConfigurationDataID)

Expand Down
1 change: 0 additions & 1 deletion examples/v2/metrics/ListTagConfigurations.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
func main() {
ctx := datadog.NewDefaultContext(context.Background())
configuration := datadog.NewConfiguration()
configuration.SetUnstableOperationEnabled("ListTagConfigurations", true)
apiClient := datadog.NewAPIClient(configuration)
resp, r, err := apiClient.MetricsApi.ListTagConfigurations(ctx, *datadog.NewListTagConfigurationsOptionalParameters())

Expand Down
1 change: 0 additions & 1 deletion examples/v2/metrics/ListTagConfigurations_103226315.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
func main() {
ctx := datadog.NewDefaultContext(context.Background())
configuration := datadog.NewConfiguration()
configuration.SetUnstableOperationEnabled("ListTagConfigurations", true)
apiClient := datadog.NewAPIClient(configuration)
resp, r, err := apiClient.MetricsApi.ListTagConfigurations(ctx, *datadog.NewListTagConfigurationsOptionalParameters().WithFilterConfigured(true))

Expand Down
1 change: 0 additions & 1 deletion examples/v2/metrics/ListTagConfigurations_1799362914.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
func main() {
ctx := datadog.NewDefaultContext(context.Background())
configuration := datadog.NewConfiguration()
configuration.SetUnstableOperationEnabled("ListTagConfigurations", true)
apiClient := datadog.NewAPIClient(configuration)
resp, r, err := apiClient.MetricsApi.ListTagConfigurations(ctx, *datadog.NewListTagConfigurationsOptionalParameters().WithFilterTags("ExampleListtagconfigurationswithatagfilterreturnsSuccessresponse"))

Expand Down
1 change: 0 additions & 1 deletion examples/v2/metrics/UpdateTagConfiguration.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ func main() {
}
ctx := datadog.NewDefaultContext(context.Background())
configuration := datadog.NewConfiguration()
configuration.SetUnstableOperationEnabled("UpdateTagConfiguration", true)
apiClient := datadog.NewAPIClient(configuration)
resp, r, err := apiClient.MetricsApi.UpdateTagConfiguration(ctx, MetricTagConfigurationDataID, body)

Expand Down
14 changes: 0 additions & 14 deletions tests/scenarios/features/v2/metrics.feature
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ Feature: Metrics
@generated @skip @team:DataDog/points-aggregation
Scenario: Create a tag configuration returns "Bad Request" response
Given a valid "appKeyAuth" key in the system
And operation "CreateTagConfiguration" enabled
And new "CreateTagConfiguration" request
And request contains "metric_name" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"include_percentiles": false, "metric_type": "distribution", "tags": ["app", "datacenter"]}, "id": "http.endpoint.request", "type": "manage_tags"}}
Expand All @@ -51,7 +50,6 @@ Feature: Metrics
@generated @skip @team:DataDog/points-aggregation
Scenario: Create a tag configuration returns "Conflict" response
Given a valid "appKeyAuth" key in the system
And operation "CreateTagConfiguration" enabled
And new "CreateTagConfiguration" request
And request contains "metric_name" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"include_percentiles": false, "metric_type": "distribution", "tags": ["app", "datacenter"]}, "id": "http.endpoint.request", "type": "manage_tags"}}
Expand All @@ -61,7 +59,6 @@ Feature: Metrics
@replay-only @team:DataDog/points-aggregation
Scenario: Create a tag configuration returns "Created" response
Given a valid "appKeyAuth" key in the system
And operation "CreateTagConfiguration" enabled
And new "CreateTagConfiguration" request
And there is a valid "metric" in the system
And request contains "metric_name" parameter with value "{{ unique_alnum }}"
Expand All @@ -74,7 +71,6 @@ Feature: Metrics
Given there is a valid "metric" in the system
And there is a valid "metric_tag_configuration" in the system
And a valid "appKeyAuth" key in the system
And operation "DeleteTagConfiguration" enabled
And new "DeleteTagConfiguration" request
And request contains "metric_name" parameter with value "{{ unique_alnum }}"
When the request is sent
Expand All @@ -83,7 +79,6 @@ Feature: Metrics
@generated @skip @team:DataDog/points-aggregation
Scenario: Delete a tag configuration returns "Not found" response
Given a valid "appKeyAuth" key in the system
And operation "DeleteTagConfiguration" enabled
And new "DeleteTagConfiguration" request
And request contains "metric_name" parameter from "REPLACE.ME"
When the request is sent
Expand Down Expand Up @@ -119,7 +114,6 @@ Feature: Metrics
@generated @skip @team:DataDog/points-aggregation
Scenario: List tag configuration by name returns "Not Found" response
Given a valid "appKeyAuth" key in the system
And operation "ListTagConfigurationByName" enabled
And new "ListTagConfigurationByName" request
And request contains "metric_name" parameter from "REPLACE.ME"
When the request is sent
Expand All @@ -130,7 +124,6 @@ Feature: Metrics
Given a valid "appKeyAuth" key in the system
And there is a valid "metric" in the system
And there is a valid "metric_tag_configuration" in the system
And operation "ListTagConfigurationByName" enabled
And new "ListTagConfigurationByName" request
And request contains "metric_name" parameter from "metric_tag_configuration.data.id"
When the request is sent
Expand All @@ -140,7 +133,6 @@ Feature: Metrics
@generated @skip @team:DataDog/points-aggregation
Scenario: List tag configurations returns "Bad Request" response
Given a valid "appKeyAuth" key in the system
And operation "ListTagConfigurations" enabled
And new "ListTagConfigurations" request
When the request is sent
Then the response status is 400 Bad Request
Expand All @@ -149,15 +141,13 @@ Feature: Metrics
Scenario: List tag configurations returns "Success" response
Given a valid "appKeyAuth" key in the system
And there is a valid "metric_tag_configuration" in the system
And operation "ListTagConfigurations" enabled
And new "ListTagConfigurations" request
When the request is sent
Then the response status is 200 Success

@team:DataDog/points-aggregation
Scenario: List tag configurations with a tag filter returns "Success" response
Given a valid "appKeyAuth" key in the system
And operation "ListTagConfigurations" enabled
And new "ListTagConfigurations" request
And request contains "filter[tags]" parameter with value "{{ unique_alnum }}"
When the request is sent
Expand All @@ -166,7 +156,6 @@ Feature: Metrics
@team:DataDog/points-aggregation
Scenario: List tag configurations with configured filter returns "Success" response
Given a valid "appKeyAuth" key in the system
And operation "ListTagConfigurations" enabled
And new "ListTagConfigurations" request
And request contains "filter[configured]" parameter with value true
When the request is sent
Expand Down Expand Up @@ -247,7 +236,6 @@ Feature: Metrics
@generated @skip @team:DataDog/points-aggregation
Scenario: Update a tag configuration returns "Bad Request" response
Given a valid "appKeyAuth" key in the system
And operation "UpdateTagConfiguration" enabled
And new "UpdateTagConfiguration" request
And request contains "metric_name" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"group_by": ["app", "datacenter"], "include_percentiles": false}, "id": "http.endpoint.request", "type": "manage_tags"}}
Expand All @@ -257,7 +245,6 @@ Feature: Metrics
@replay-only @team:DataDog/points-aggregation
Scenario: Update a tag configuration returns "OK" response
Given a valid "appKeyAuth" key in the system
And operation "UpdateTagConfiguration" enabled
And there is a valid "metric" in the system
And there is a valid "metric_tag_configuration" in the system
And new "UpdateTagConfiguration" request
Expand All @@ -270,7 +257,6 @@ Feature: Metrics
@generated @skip @team:DataDog/points-aggregation
Scenario: Update a tag configuration returns "Unprocessable Entity" response
Given a valid "appKeyAuth" key in the system
And operation "UpdateTagConfiguration" enabled
And new "UpdateTagConfiguration" request
And request contains "metric_name" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"group_by": ["app", "datacenter"], "include_percentiles": false}, "id": "http.endpoint.request", "type": "manage_tags"}}
Expand Down