Creating a 'cloudproviders' package #9738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
added
[deprecated] team/agent-core
hush-hush
force-pushed
the
maxime/cloudproviders-package
branch
3 times, most recently
from
7d4de55 to
659bb42
Compare
djmitche
approved these changes
Nov 3, 2021
pkg/util/hostname.go
Outdated
| @@ -179,7 +179,7 @@ func GetHostnameData(ctx context.Context) (HostnameData, error) { | |||
| configHostnameFilepath := config.Datadog.GetString("hostname_file") | |||
| if configHostnameFilepath != "" { | |||
| log.Debug("GetHostname trying `hostname_file` config option...") | |||
| if fileHostnameProvider, found := hostname.ProviderCatalog["file"]; found { | |||
There was a problem hiding this comment.
Does it make sense to move this file to pkg/util/hostname?
There was a problem hiding this comment.
I would very much so. I started looking into it and the change was massive. I'll open another PR dedicated to this.
hush-hush
force-pushed
the
maxime/cloudproviders-package
branch
from
659bb42 to
7538b9a
Compare
sgnn7
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
@hush-hush 2 tiny nits but LGTM. Great improvements all around!
mx-psi
reviewed
Nov 4, 2021
ahmed-mez
reviewed
Nov 4, 2021
ahmed-mez
approved these changes
Nov 4, 2021
mx-psi
approved these changes
Nov 4, 2021
This includes for now Azure, Tencent and Alibaba providers. The goal is to encapsulate all the cloud provider logic spread out in the util package.
hush-hush
force-pushed
the
maxime/cloudproviders-package
branch
from
7538b9a to
d1ee9ac
Compare
robertjli
approved these changes
Nov 4, 2021
NouemanKHAL
approved these changes
Nov 10, 2021
|
I'll rebase this shortly. The conflict is with one of my PRs (and Maxime is away). |
mfpierre
approved these changes
Nov 10, 2021
|
It looks like the |
zandrewitte
pushed a commit
to StackVista/stackstate-agent
that referenced
this pull request
Nov 17, 2022
The goal is to encapsulate all the cloud provider logic spread out in the util package. Co-authored-by: Dustin J. Mitchell <dustin.mitchell@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The logic around cloudproviders is spread out all over the
utilpackage. This PR create a dedicatedcloudproviderspackage.Motivation
Make it easier to add new cloudproviders.
Additional Notes
Describe how to test your changes
Install the agent on different cloudproviders and test that tags and hostname are still well reported.
Ensure that cluster name detection is working, too.
Also test that the metadata payload (printed in the logs in debug log level) is the same.
Checklist
changelog/no-changeloglabel has been applied.need-change/operatorandneed-change/helmlabels has been applied if applicable.team/..label has been applied, if known.Triagemilestone is set.Note: Adding GitHub labels is only possible for contributors with write access.