[tasks] Go modules RFC release tooling #7527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
commented
Feb 25, 2021
mx-psi
commented
Feb 26, 2021
mx-psi
added
changelog/no-changelog
[deprecated] qa/skip-qa - use other qa/ labels
Some runners do not have a sufficiently new Python version
mx-psi
commented
Feb 26, 2021
|
|
||
| * --commit COMMIT will tag COMMIT with the tags (default HEAD) | ||
| * --verify checks for correctness on the Agent version (on by default). | ||
| * --push will push the tags to the origin remote (on by default). |
There was a problem hiding this comment.
Should this be on by default? I think it's fine (the worst that can happen is an artifact on the staging repo) but we can have it off by default.
Comment on lines
+30
to
+31
| if self.path == ".": | ||
| return ["6" + agent_version[1:], "7" + agent_version[1:]] |
There was a problem hiding this comment.
We always return Agent 6 and Agent 7 tags. Do we want to have an option for releases that are just for one of them?
There was a problem hiding this comment.
We can leave it like this for now. We can change it when we decouple the release cycles of A6 and A7 in the future.
albertvaka
approved these changes
Mar 2, 2021
| if self.path == ".": | ||
| return "v" + agent_version | ||
|
|
||
| return "v0" + agent_version[1:] |
There was a problem hiding this comment.
I think we will catch that when the time comes 😄
Comment on lines
+30
to
+31
| if self.path == ".": | ||
| return ["6" + agent_version[1:], "7" + agent_version[1:]] |
There was a problem hiding this comment.
We can leave it like this for now. We can change it when we decouple the release cycles of A6 and A7 in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GoModuleto its own fileupdate_moduleandtag_versiontasks to respectively update inter-module dependencies and tag versions.Open questions
pushbe on by default?Motivation
Additional Notes
update_modulesis a no-op andtag_versiononly tags the main module with the 6 and 7 version tags.Describe your test plan